From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: davem@davemloft.net
Cc: "Maxime Chevallier" <maxime.chevallier@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com, gregory.clement@bootlin.com,
"Andrew Lunn" <andrew@lunn.ch>, "Pali Rohár" <pali@kernel.org>,
"Jakub Kicinski" <kuba@kernel.org>
Subject: [PATCH net-next v2 2/4] net: mvneta: Don't force-set the offloading flag
Date: Fri, 26 Nov 2021 12:20:54 +0100 [thread overview]
Message-ID: <20211126112056.849123-3-maxime.chevallier@bootlin.com> (raw)
In-Reply-To: <20211126112056.849123-1-maxime.chevallier@bootlin.com>
The qopt->hw flag is set by the TC code according to the offloading mode
asked by user. Don't force-set it in the driver, but instead read it to
make sure we do what's asked.
Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
---
V2 : No changes
drivers/net/ethernet/marvell/mvneta.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index 46b7604805f7..d3ce87e69d2a 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -4915,7 +4915,9 @@ static int mvneta_setup_mqprio(struct net_device *dev,
u8 num_tc;
int i;
- mqprio->qopt.hw = TC_MQPRIO_HW_OFFLOAD_TCS;
+ if (mqprio->qopt.hw != TC_MQPRIO_HW_OFFLOAD_TCS)
+ return 0;
+
num_tc = mqprio->qopt.num_tc;
if (num_tc > rxq_number)
--
2.25.4
next prev parent reply other threads:[~2021-11-26 11:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 11:20 [PATCH net-next v2 0/4] net: mvneta: mqprio cleanups and shaping support Maxime Chevallier
2021-11-26 11:20 ` [PATCH net-next v2 1/4] net: mvneta: Use struct tc_mqprio_qopt_offload for MQPrio configuration Maxime Chevallier
2021-11-26 11:20 ` Maxime Chevallier [this message]
2021-11-26 11:20 ` [PATCH net-next v2 3/4] net: mvneta: Allow having more than one queue per TC Maxime Chevallier
2021-11-26 11:20 ` [PATCH net-next v2 4/4] net: mvneta: Add TC traffic shaping offload Maxime Chevallier
2021-11-29 12:20 ` [PATCH net-next v2 0/4] net: mvneta: mqprio cleanups and shaping support patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211126112056.849123-3-maxime.chevallier@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=gregory.clement@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pali@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).