From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: intel-wired-lan@lists.osuosl.org
Cc: Vinicius Costa Gomes <vinicius.gomes@intel.com>,
netdev@vger.kernel.org, roots@gmx.de, jesse.brandeburg@intel.com,
anthony.l.nguyen@intel.com, regressions@leemhuis.info,
greg@kroah.com, kuba@kernel.org
Subject: [PATCH net v1] igc: Do not enable crosstimestamping for i225-V models
Date: Mon, 13 Dec 2021 16:39:49 -0800 [thread overview]
Message-ID: <20211214003949.666642-1-vinicius.gomes@intel.com> (raw)
In-Reply-To: <87wnk8qrt8.fsf@intel.com>
It was reported that when PCIe PTM is enabled, some lockups could
be observed with some integrated i225-V models.
While the issue is investigated, we can disable crosstimestamp for
those models and see no loss of functionality, because those models
don't have any support for time synchronization.
Fixes: a90ec8483732 ("igc: Add support for PTP getcrosststamp()")
Link: https://lore.kernel.org/all/924175a188159f4e03bd69908a91e606b574139b.camel@gmx.de/
Reported-by: Stefan Dietrich <roots@gmx.de>
Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
---
drivers/net/ethernet/intel/igc/igc_ptp.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_ptp.c b/drivers/net/ethernet/intel/igc/igc_ptp.c
index 30568e3544cd..4f9245aa79a1 100644
--- a/drivers/net/ethernet/intel/igc/igc_ptp.c
+++ b/drivers/net/ethernet/intel/igc/igc_ptp.c
@@ -768,7 +768,20 @@ int igc_ptp_get_ts_config(struct net_device *netdev, struct ifreq *ifr)
*/
static bool igc_is_crosststamp_supported(struct igc_adapter *adapter)
{
- return IS_ENABLED(CONFIG_X86_TSC) ? pcie_ptm_enabled(adapter->pdev) : false;
+ if (!IS_ENABLED(CONFIG_X86_TSC))
+ return false;
+
+ /* FIXME: it was noticed that enabling support for PCIe PTM in
+ * some i225-V models could cause lockups when bringing the
+ * interface up/down. There should be no downsides to
+ * disabling crosstimestamping support for i225-V, as it
+ * doesn't have any PTP support. That way we gain some time
+ * while root causing the issue.
+ */
+ if (adapter->pdev->device == IGC_DEV_ID_I225_V)
+ return false;
+
+ return pcie_ptm_enabled(adapter->pdev);
}
static struct system_counterval_t igc_device_tstamp_to_system(u64 tstamp)
--
2.34.1
next prev parent reply other threads:[~2021-12-14 0:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <924175a188159f4e03bd69908a91e606b574139b.camel@gmx.de>
2021-11-24 8:05 ` [REGRESSION] Kernel 5.15 reboots / freezes upon ifup/ifdown Stefan Dietrich
[not found] ` <YZ3q4OKhU2EPPttE@kroah.com>
2021-11-24 17:20 ` Stefan Dietrich
2021-11-24 23:34 ` Jakub Kicinski
2021-11-25 1:07 ` Vinicius Costa Gomes
2021-11-25 1:13 ` Jakub Kicinski
2021-11-25 8:41 ` Stefan Dietrich
2021-12-01 11:45 ` Thorsten Leemhuis
2021-12-01 17:47 ` Vinicius Costa Gomes
2021-12-01 18:57 ` [PATCH] igc: Avoid possible deadlock during suspend/resume Vinicius Costa Gomes
2021-12-02 6:41 ` Greg KH
2021-12-02 6:50 ` Vinicius Costa Gomes
2021-12-02 8:34 ` Stefan Dietrich
2021-12-02 22:34 ` Vinicius Costa Gomes
2021-12-10 9:40 ` Thorsten Leemhuis
2021-12-10 13:45 ` Stefan Dietrich
2021-12-10 14:01 ` Thorsten Leemhuis
2021-12-10 14:51 ` Stefan Dietrich
2021-12-11 0:41 ` Vinicius Costa Gomes
2021-12-11 9:50 ` Stefan Dietrich
2021-12-13 18:32 ` Vinicius Costa Gomes
2021-12-14 0:39 ` Vinicius Costa Gomes [this message]
2021-12-14 5:49 ` [PATCH net v1] igc: Do not enable crosstimestamping for i225-V models Thorsten Leemhuis
2021-12-23 7:21 ` Thorsten Leemhuis
2021-12-27 20:35 ` [Intel-wired-lan] " Kraus, NechamaX
2021-12-14 6:39 ` [PATCH] igc: Avoid possible deadlock during suspend/resume Stefan Dietrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211214003949.666642-1-vinicius.gomes@intel.com \
--to=vinicius.gomes@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=greg@kroah.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=regressions@leemhuis.info \
--cc=roots@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).