From: Jakub Kicinski <kuba@kernel.org>
To: Dimitris Michailidis <d.michailidis@fungible.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, andrew@lunn.ch
Subject: Re: [PATCH net-next v6 7/8] net/funeth: add kTLS TX control part
Date: Wed, 12 Jan 2022 14:32:13 -0800 [thread overview]
Message-ID: <20220112143213.0ad3c9c9@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <20220110015636.245666-8-dmichail@fungible.com>
On Sun, 9 Jan 2022 17:56:35 -0800 Dimitris Michailidis wrote:
> +static inline int fun_ktls_init(struct net_device *netdev)
> +{
> + return -ENOTSUPP;
ENOTSUPP is best avoided - EOPNOTSUPP is the proper error code which
can be returned to user space if needed. But you should make this
function void since the return value is ignored, anyway.
next prev parent reply other threads:[~2022-01-12 22:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 1:56 [PATCH net-next v6 0/8] new Fungible Ethernet driver Dimitris Michailidis
2022-01-10 1:56 ` [PATCH net-next v6 1/8] PCI: Add Fungible Vendor ID to pci_ids.h Dimitris Michailidis
2022-01-10 1:56 ` [PATCH net-next v6 2/8] net/fungible: Add service module for Fungible drivers Dimitris Michailidis
2022-01-10 1:56 ` [PATCH net-next v6 3/8] net/funeth: probing and netdev ops Dimitris Michailidis
2022-01-12 22:45 ` Jakub Kicinski
2022-02-17 2:57 ` Dimitris Michailidis
2022-01-12 22:51 ` Jakub Kicinski
2022-02-17 3:06 ` Dimitris Michailidis
2022-01-12 22:56 ` Jakub Kicinski
2022-02-17 3:07 ` Dimitris Michailidis
2022-01-10 1:56 ` [PATCH net-next v6 4/8] net/funeth: ethtool operations Dimitris Michailidis
2022-01-10 1:56 ` [PATCH net-next v6 5/8] net/funeth: devlink support Dimitris Michailidis
2022-01-10 1:56 ` [PATCH net-next v6 6/8] net/funeth: add the data path Dimitris Michailidis
2022-01-10 1:56 ` [PATCH net-next v6 7/8] net/funeth: add kTLS TX control part Dimitris Michailidis
2022-01-12 22:32 ` Jakub Kicinski [this message]
2022-01-12 22:35 ` Jakub Kicinski
2022-01-12 22:40 ` Jakub Kicinski
2022-02-17 3:10 ` Dimitris Michailidis
2022-01-10 1:56 ` [PATCH net-next v6 8/8] net/fungible: Kconfig, Makefiles, and MAINTAINERS Dimitris Michailidis
2022-01-10 2:55 ` [PATCH net-next v6 0/8] new Fungible Ethernet driver Jakub Kicinski
2022-01-12 23:17 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220112143213.0ad3c9c9@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=d.michailidis@fungible.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).