From: Jakub Kicinski <kuba@kernel.org>
To: ooppublic@163.com
Cc: davem@davemloft.net, dsahern@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: fix fragments have the disallowed options
Date: Tue, 18 Jan 2022 13:10:06 -0800 [thread overview]
Message-ID: <20220118131006.083f8b23@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <20220112104324.61b15b51@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
On Wed, 12 Jan 2022 10:43:24 -0800 Jakub Kicinski wrote:
> On Fri, 7 Jan 2022 16:05:59 +0800 ooppublic@163.com wrote:
> > From: caixf <ooppublic@163.com>
> >
> > When in function ip_do_fragment() enter fsat path,
>
> fsat -> fast
>
> > if skb have opthons, all fragments will have the same options.
>
> opthons -> options
>
> > Just guarantee the second fragment not have the disallowed options.
>
> You're right. Can you send a patch which explicitly reverts these
> two commits instead:
>
> 1b9fbe813016b08e08b22ddba4ddbf9cb1b04b00
> faf482ca196a5b16007190529b3b2dd32ab3f761
>
> I prefer the code the way it was before them, plus keeping the code how
> it was could help backports.
Please let us know if you're planning to send the new patch otherwise
I'll do the revert myself, it's a clear bug.
next prev parent reply other threads:[~2022-01-18 21:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 8:05 [PATCH] net: fix fragments have the disallowed options ooppublic
2022-01-12 18:43 ` Jakub Kicinski
2022-01-18 21:10 ` Jakub Kicinski [this message]
2022-01-12 18:46 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220118131006.083f8b23@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ooppublic@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).