* [PATCH] net: usb: asix: remove redundant assignment to variable reg
@ 2022-01-23 18:40 Colin Ian King
2022-01-24 5:45 ` Oleksij Rempel
2022-01-25 1:26 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Colin Ian King @ 2022-01-23 18:40 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski, Oleksij Rempel, linux-usb, netdev
Cc: kernel-janitors, linux-kernel
Variable reg is being masked however the variable is never read
after this. The assignment is redundant and can be removed.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/net/usb/asix_devices.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
index 4514d35ef4c4..9b72334aabb6 100644
--- a/drivers/net/usb/asix_devices.c
+++ b/drivers/net/usb/asix_devices.c
@@ -858,7 +858,6 @@ static int marvell_phy_init(struct usbnet *dev)
reg = asix_mdio_read(dev->net, dev->mii.phy_id,
MII_MARVELL_LED_CTRL);
netdev_dbg(dev->net, "MII_MARVELL_LED_CTRL (2) = 0x%04x\n", reg);
- reg &= 0xfc0f;
}
return 0;
--
2.33.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: usb: asix: remove redundant assignment to variable reg
2022-01-23 18:40 [PATCH] net: usb: asix: remove redundant assignment to variable reg Colin Ian King
@ 2022-01-24 5:45 ` Oleksij Rempel
2022-01-25 1:26 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Oleksij Rempel @ 2022-01-24 5:45 UTC (permalink / raw)
To: Colin Ian King
Cc: David S . Miller, Jakub Kicinski, Oleksij Rempel, linux-usb,
netdev, kernel-janitors, linux-kernel
On Sun, Jan 23, 2022 at 06:40:35PM +0000, Colin Ian King wrote:
> Variable reg is being masked however the variable is never read
> after this. The assignment is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Thank you!
> ---
> drivers/net/usb/asix_devices.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
> index 4514d35ef4c4..9b72334aabb6 100644
> --- a/drivers/net/usb/asix_devices.c
> +++ b/drivers/net/usb/asix_devices.c
> @@ -858,7 +858,6 @@ static int marvell_phy_init(struct usbnet *dev)
> reg = asix_mdio_read(dev->net, dev->mii.phy_id,
> MII_MARVELL_LED_CTRL);
> netdev_dbg(dev->net, "MII_MARVELL_LED_CTRL (2) = 0x%04x\n", reg);
> - reg &= 0xfc0f;
> }
>
> return 0;
> --
> 2.33.1
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: usb: asix: remove redundant assignment to variable reg
2022-01-23 18:40 [PATCH] net: usb: asix: remove redundant assignment to variable reg Colin Ian King
2022-01-24 5:45 ` Oleksij Rempel
@ 2022-01-25 1:26 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-01-25 1:26 UTC (permalink / raw)
To: Colin Ian King
Cc: davem, kuba, linux, linux-usb, netdev, kernel-janitors, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Sun, 23 Jan 2022 18:40:35 +0000 you wrote:
> Variable reg is being masked however the variable is never read
> after this. The assignment is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/net/usb/asix_devices.c | 1 -
> 1 file changed, 1 deletion(-)
Here is the summary with links:
- net: usb: asix: remove redundant assignment to variable reg
https://git.kernel.org/netdev/net-next/c/9f16e0fa1079
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-25 3:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-23 18:40 [PATCH] net: usb: asix: remove redundant assignment to variable reg Colin Ian King
2022-01-24 5:45 ` Oleksij Rempel
2022-01-25 1:26 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).