From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8C18C433FE for ; Mon, 24 Jan 2022 14:35:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239073AbiAXOfx (ORCPT ); Mon, 24 Jan 2022 09:35:53 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:58243 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238694AbiAXOfw (ORCPT ); Mon, 24 Jan 2022 09:35:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643034952; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BeGDvrkkjvA1xh6gxUs0jIKGaesitIVDxuSpQPVYy6o=; b=A+1OYaomQ9BRVEn7qyDwSJULgwZyihC/EHlr0H0qCFUbp8AGFUglyH4ZF9pRgSNCU/Imhy ZpxsBEvtqJAjsUTInfVfuhWfaM+tGPcEACkry+BgOSxyAdG94WbAjaiAcZf3BaM0gHWoFz XOOgBt9Yzop/UIyqnxlCsEoWeJLWha0= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-548-OI1lQhtmOaWVR62oBywznw-1; Mon, 24 Jan 2022 09:35:50 -0500 X-MC-Unique: OI1lQhtmOaWVR62oBywznw-1 Received: by mail-ej1-f70.google.com with SMTP id k16-20020a17090632d000b006ae1cdb0f07so2154148ejk.16 for ; Mon, 24 Jan 2022 06:35:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=BeGDvrkkjvA1xh6gxUs0jIKGaesitIVDxuSpQPVYy6o=; b=4S3cQgpIrqz48seE34MimRU1px0B4FOvL2iHSRaMoD8amFpx82uFTC1ho7S8w9egg5 r++FRlTSBy8YAWxHEJPJNHb7Qst8ZBQeJkOXdXpsh1QMjl5pwDo8nUC6sk1Y1Gx0RUoP qvfa3rA2N3IPpbVGvwtLxNHl6LwNC2k3v8yU3CbWosEtcZcvarZooKn8Wl0/g/g5xbkx 0J7NkWQgV7iGFonh0KbRubMo7ILw+6OGZavyvCy2He8qDvne4avJ4Zy0EBh9MTj719ak FNyayRJ+DSbuyc8x/i0td+5ahD9VDe/jy/3ME2n+V50sqFa/e3osbgnapVn+fhGVWnTi PpQg== X-Gm-Message-State: AOAM530qcrLACd3ygeDI/HH2L2trUtgmI40aG0ilHBZxJrONHGyBJ5IQ M3xmEFDIPuo9DXVldda09D0Ppi8f0ssbxAImr7DpBSxdwa7ngjWve2CNSNcJhgShoY9TYOQ9Jv3 6LsMdVEPYIKynCHJP X-Received: by 2002:a17:906:6691:: with SMTP id z17mr12670615ejo.763.1643034949435; Mon, 24 Jan 2022 06:35:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJxTSN51Yp9SFRdp+9vVc5pIboTbtwWIVGk8Stug4CViUxXq8GFJQSFVd47ivrVfsXg8ZbQYig== X-Received: by 2002:a17:906:6691:: with SMTP id z17mr12670584ejo.763.1643034949010; Mon, 24 Jan 2022 06:35:49 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id h16sm4961702ejj.56.2022.01.24.06.35.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 06:35:48 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id DCF9E1805FB; Mon, 24 Jan 2022 15:35:46 +0100 (CET) From: =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= To: Grygorii Strashko , Ilias Apalodimas , Murali Karicheri , "David S. Miller" , Jesper Dangaard Brouer , Ivan Khoronzhuk Cc: =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Alexei Starovoitov , Colin Foster , Jakub Kicinski , linux-omap@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH net] net: cpsw: Properly initialise struct page_pool_params Date: Mon, 24 Jan 2022 15:35:29 +0100 Message-Id: <20220124143531.361005-1-toke@redhat.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The cpsw driver didn't properly initialise the struct page_pool_params before calling page_pool_create(), which leads to crashes after the struct has been expanded with new parameters. The second Fixes tag below is where the buggy code was introduced, but because the code was moved around this patch will only apply on top of the commit in the first Fixes tag. Fixes: c5013ac1dd0e ("net: ethernet: ti: cpsw: move set of common functions in cpsw_priv") Fixes: 9ed4050c0d75 ("net: ethernet: ti: cpsw: add XDP support") Reported-by: Colin Foster Signed-off-by: Toke Høiland-Jørgensen --- drivers/net/ethernet/ti/cpsw_priv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ti/cpsw_priv.c b/drivers/net/ethernet/ti/cpsw_priv.c index ba220593e6db..8f6817f346ba 100644 --- a/drivers/net/ethernet/ti/cpsw_priv.c +++ b/drivers/net/ethernet/ti/cpsw_priv.c @@ -1146,7 +1146,7 @@ int cpsw_fill_rx_channels(struct cpsw_priv *priv) static struct page_pool *cpsw_create_page_pool(struct cpsw_common *cpsw, int size) { - struct page_pool_params pp_params; + struct page_pool_params pp_params = {}; struct page_pool *pool; pp_params.order = 0; -- 2.34.1