From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Tony Lu <tonylu@linux.alibaba.com>
Cc: kgraul@linux.ibm.com, kuba@kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, linux-s390@vger.kernel.org,
linux-rdma@vger.kernel.org, linux-api@vger.kernel.org
Subject: Re: [PATCH 2/4] net/smc: Add netlink net namespace support
Date: Mon, 31 Jan 2022 03:24:54 +0300 [thread overview]
Message-ID: <20220131002453.GA7599@altlinux.org> (raw)
In-Reply-To: <20211228130611.19124-3-tonylu@linux.alibaba.com>
On Tue, Dec 28, 2021 at 09:06:10PM +0800, Tony Lu wrote:
> This adds net namespace ID to diag of linkgroup, helps us to distinguish
> different namespaces, and net_cookie is unique in the whole system.
>
> Signed-off-by: Tony Lu <tonylu@linux.alibaba.com>
> ---
> include/uapi/linux/smc.h | 2 ++
> include/uapi/linux/smc_diag.h | 11 ++++++-----
> net/smc/smc_core.c | 3 +++
> net/smc/smc_diag.c | 16 +++++++++-------
> 4 files changed, 20 insertions(+), 12 deletions(-)
>
> diff --git a/include/uapi/linux/smc.h b/include/uapi/linux/smc.h
> index 20f33b27787f..6c2874fd2c00 100644
> --- a/include/uapi/linux/smc.h
> +++ b/include/uapi/linux/smc.h
> @@ -119,6 +119,8 @@ enum {
> SMC_NLA_LGR_R_CONNS_NUM, /* u32 */
> SMC_NLA_LGR_R_V2_COMMON, /* nest */
> SMC_NLA_LGR_R_V2, /* nest */
> + SMC_NLA_LGR_R_NET_COOKIE, /* u64 */
> + SMC_NLA_LGR_R_PAD, /* flag */
> __SMC_NLA_LGR_R_MAX,
> SMC_NLA_LGR_R_MAX = __SMC_NLA_LGR_R_MAX - 1
> };
> diff --git a/include/uapi/linux/smc_diag.h b/include/uapi/linux/smc_diag.h
> index 8cb3a6fef553..c7008d87f1a4 100644
> --- a/include/uapi/linux/smc_diag.h
> +++ b/include/uapi/linux/smc_diag.h
> @@ -84,11 +84,12 @@ struct smc_diag_conninfo {
> /* SMC_DIAG_LINKINFO */
>
> struct smc_diag_linkinfo {
> - __u8 link_id; /* link identifier */
> - __u8 ibname[IB_DEVICE_NAME_MAX]; /* name of the RDMA device */
> - __u8 ibport; /* RDMA device port number */
> - __u8 gid[40]; /* local GID */
> - __u8 peer_gid[40]; /* peer GID */
> + __u8 link_id; /* link identifier */
> + __u8 ibname[IB_DEVICE_NAME_MAX]; /* name of the RDMA device */
> + __u8 ibport; /* RDMA device port number */
> + __u8 gid[40]; /* local GID */
> + __u8 peer_gid[40]; /* peer GID */
> + __aligned_u64 net_cookie; /* RDMA device net namespace */
> };
>
> struct smc_diag_lgrinfo {
I'm sorry but this is an ABI regression.
Since struct smc_diag_lgrinfo contains an object of type "struct smc_diag_linkinfo",
offset of all subsequent members of struct smc_diag_lgrinfo is changed by
this patch.
As result, applications compiled with the old version of struct smc_diag_linkinfo
will receive garbage in struct smc_diag_lgrinfo.role if the kernel implements
this new version of struct smc_diag_linkinfo.
--
ldv
next prev parent reply other threads:[~2022-01-31 0:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-28 13:06 [PATCH 0/4] RDMA device net namespace support for SMC Tony Lu
2021-12-28 13:06 ` [PATCH 1/4] net/smc: Introduce net namespace support for linkgroup Tony Lu
2021-12-28 13:06 ` [PATCH 2/4] net/smc: Add netlink net namespace support Tony Lu
2022-01-31 0:24 ` Dmitry V. Levin [this message]
2022-01-31 13:49 ` Karsten Graul
2022-02-02 3:09 ` [PATCH] Partially revert "net/smc: Add netlink net namespace support" Dmitry V. Levin
2022-02-02 7:26 ` Karsten Graul
2022-02-09 9:43 ` Tony Lu
2021-12-28 13:06 ` [PATCH 3/4] net/smc: Print net namespace in log Tony Lu
2021-12-28 13:06 ` [PATCH 4/4] net/smc: Add net namespace for tracepoints Tony Lu
2022-01-02 12:20 ` [PATCH 0/4] RDMA device net namespace support for SMC patchwork-bot+netdevbpf
2022-02-17 11:33 ` Niklas Schnelle
2022-02-21 6:54 ` Tony Lu
2022-02-21 15:30 ` Niklas Schnelle
2022-02-25 6:49 ` Tony Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220131002453.GA7599@altlinux.org \
--to=ldv@altlinux.org \
--cc=davem@davemloft.net \
--cc=kgraul@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tonylu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).