From: "Marek Behún" <kabel@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
devicetree@vger.kernel.org, Vladimir Oltean <olteanv@gmail.com>,
Holger Brunck <holger.brunck@hitachienergy.com>,
Andrew Lunn <andrew@lunn.ch>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Russell King <rmk+kernel@armlinux.org.uk>,
linux-phy@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>
Subject: Re: [PATCH devicetree v3] dt-bindings: phy: Add `tx-p2p-microvolt` property binding
Date: Sun, 6 Feb 2022 18:54:13 +0100 [thread overview]
Message-ID: <20220206185413.4c1ac00d@thinkpad> (raw)
In-Reply-To: <Yf3egEVYyyXUkklM@robh.at.kernel.org>
On Fri, 4 Feb 2022 20:18:40 -0600
Rob Herring <robh@kernel.org> wrote:
> On Fri, Jan 21, 2022 at 11:18:09AM -0800, Florian Fainelli wrote:
> > On 1/19/22 5:11 AM, Marek Behún wrote:
> > > Common PHYs and network PCSes often have the possibility to specify
> > > peak-to-peak voltage on the differential pair - the default voltage
> > > sometimes needs to be changed for a particular board.
> > >
> > > Add properties `tx-p2p-microvolt` and `tx-p2p-microvolt-names` for this
> > > purpose. The second property is needed to specify the mode for the
> > > corresponding voltage in the `tx-p2p-microvolt` property, if the voltage
> > > is to be used only for speficic mode. More voltage-mode pairs can be
> > > specified.
> > >
> > > Example usage with only one voltage (it will be used for all supported
> > > PHY modes, the `tx-p2p-microvolt-names` property is not needed in this
> > > case):
> > >
> > > tx-p2p-microvolt = <915000>;
> > >
> > > Example usage with voltages for multiple modes:
> > >
> > > tx-p2p-microvolt = <915000>, <1100000>, <1200000>;
> > > tx-p2p-microvolt-names = "2500base-x", "usb", "pcie";
> > >
> > > Add these properties into a separate file phy/transmit-amplitude.yaml,
> > > which should be referenced by any binding that uses it.
> >
> > p2p commonly means peer to peer which incidentally could be confusing,
> > can you spell out the property entire:
> >
> > tx-peaktopeak-microvolt or:
> >
> > tx-pk2pk-microvolt for a more compact name maybe?
>
> Peer to peer makes little sense in terms of a voltage. I think this is
> fine as-is.
Cool. Should this get merged via devicetree, or via phy maintainers?
Or should I resend this together with patches that make use of this
property? (In that case can you add your Ack?)
Thanks.
Marek
next prev parent reply other threads:[~2022-02-06 17:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 13:11 [PATCH devicetree v3] dt-bindings: phy: Add `tx-p2p-microvolt` property binding Marek Behún
2022-01-20 8:49 ` Marc Kleine-Budde
2022-01-20 18:01 ` Marek Behún
2022-01-20 19:50 ` Marc Kleine-Budde
2022-01-21 19:18 ` Florian Fainelli
2022-02-05 2:18 ` Rob Herring
2022-02-05 3:18 ` Florian Fainelli
2022-02-06 17:54 ` Marek Behún [this message]
2022-02-07 5:29 ` Vinod Koul
2022-02-07 20:30 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220206185413.4c1ac00d@thinkpad \
--to=kabel@kernel.org \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=holger.brunck@hitachienergy.com \
--cc=kishon@ti.com \
--cc=linux-phy@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).