From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41F4CC433EF for ; Sat, 19 Feb 2022 04:33:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234421AbiBSEdw (ORCPT ); Fri, 18 Feb 2022 23:33:52 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:47970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232527AbiBSEdv (ORCPT ); Fri, 18 Feb 2022 23:33:51 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4AAA50E3B for ; Fri, 18 Feb 2022 20:33:30 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 710BA60018 for ; Sat, 19 Feb 2022 04:33:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 548C4C340EC; Sat, 19 Feb 2022 04:33:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645245209; bh=Rs4cMPN9TM4IX/vQWrInXDPL6gf4BDqIhlJMXPdzig4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tnRqV7FW16sCEwlmc039O5/sVLO6OtKxIdSxWPMTw9C1VWTL6uZw+6/6rf8C3Rr+R Kdi6t/WHyF0xICWUasHPw+4wn1PhMz0c3HRijAgWVN9Zusq3OfRqmMufrw10Bfi7pQ AwtM9aeciKHbL7Xn3q3raVYV24cdJwbcG033m23dXuVuo6Ggp4YBZQL8mtY5ZcYYaG w+2LzSl5KFbB6CO42N2TtWP+aDVB3QGerlA50BiqyHUzyXrnOXYnpub6CZYYoeAqiM hqt2LNCWhTBTDLVPs61sQ8JmSgbTDf4YVImbv8qtqo3k02kmmO97sZHcwXP3snNfdx g5Um/TFMgvZRg== Date: Fri, 18 Feb 2022 20:33:28 -0800 From: Jakub Kicinski To: Marc Kleine-Budde Cc: Vincent Whitchurch , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Maxime Coquelin , kernel@axis.com, Lars Persson , Srinivas Kandagatla , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] net: stmmac: Enable NAPI before interrupts go live Message-ID: <20220218203328.20318a68@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20220218104504.62sfwbc4yoaceqdw@pengutronix.de> References: <20220217145527.2696444-1-vincent.whitchurch@axis.com> <20220217203604.39e318d0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20220218104504.62sfwbc4yoaceqdw@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 18 Feb 2022 11:45:04 +0100 Marc Kleine-Budde wrote: > > - request irq > > - mask irq > > I think you can merge these, to avoid a race condition, see: > > | cbe16f35bee6 genirq: Add IRQF_NO_AUTOEN for request_irq/nmi() GTK, finally someone implemented it! :)