From: Jakub Kicinski <kuba@kernel.org>
To: Michael Chan <michael.chan@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, gospo@broadcom.com
Subject: Re: [PATCH net-next 8/9] bnxt_en: implement hw health reporter
Date: Mon, 7 Mar 2022 14:21:57 -0800 [thread overview]
Message-ID: <20220307142157.143c9beb@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <1646470482-13763-9-git-send-email-michael.chan@broadcom.com>
On Sat, 5 Mar 2022 03:54:41 -0500 Michael Chan wrote:
> +static int bnxt_hw_recover(struct devlink_health_reporter *reporter,
> + void *priv_ctx,
> + struct netlink_ext_ack *extack)
> +{
> + struct bnxt *bp = devlink_health_reporter_priv(reporter);
> + struct bnxt_hw_health *hw_health = &bp->hw_health;
> +
> + hw_health->synd = BNXT_HW_STATUS_HEALTHY;
> + return 0;
> +}
This seems like a very weird recovery function.
I guess the FW automatically does auto-recovery and the driver
has no control over it?
next prev parent reply other threads:[~2022-03-07 22:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-05 8:54 [PATCH net-next 0/9] bnxt_en: Updates Michael Chan
2022-03-05 8:54 ` [PATCH net-next 1/9] bnxt_en: refactor error handling of HWRM_NVM_INSTALL_UPDATE Michael Chan
2022-03-05 8:54 ` [PATCH net-next 2/9] bnxt_en: add more error checks to HWRM_NVM_INSTALL_UPDATE Michael Chan
2022-03-05 8:54 ` [PATCH net-next 3/9] bnxt_en: parse result field when NVRAM package install fails Michael Chan
2022-03-07 22:13 ` Jakub Kicinski
2022-03-05 8:54 ` [PATCH net-next 4/9] bnxt_en: introduce initial link state of unknown Michael Chan
2022-03-05 8:54 ` [PATCH net-next 5/9] bnxt_en: Properly report no pause support on some cards Michael Chan
2022-03-05 8:54 ` [PATCH net-next 6/9] bnxt_en: Eliminate unintended link toggle during FW reset Michael Chan
2022-03-05 8:54 ` [PATCH net-next 7/9] bnxt_en: Do not destroy health reporters during reset Michael Chan
2022-03-05 8:54 ` [PATCH net-next 8/9] bnxt_en: implement hw health reporter Michael Chan
2022-03-07 22:21 ` Jakub Kicinski [this message]
2022-03-05 8:54 ` [PATCH net-next 9/9] bnxt_en: add an nvm test for hw diagnose Michael Chan
2022-03-07 22:24 ` Jakub Kicinski
2022-03-05 11:20 ` [PATCH net-next 0/9] bnxt_en: Updates patchwork-bot+netdevbpf
2022-03-07 22:27 ` Jakub Kicinski
2022-03-07 23:56 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220307142157.143c9beb@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=gospo@broadcom.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).