From: Jakub Kicinski <kuba@kernel.org>
To: "wangjie (L)" <wangjie125@huawei.com>
Cc: Michal Kubecek <mkubecek@suse.cz>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <huangguangbin2@huawei.com>,
<lipeng321@huawei.com>, <shenjian15@huawei.com>,
<moyufeng@huawei.com>, <linyunsheng@huawei.com>,
<tanhuazhong@huawei.com>, <salil.mehta@huawei.com>,
<chenhao288@hisilicon.com>
Subject: Re: [RFC net-next 1/2] net: ethtool: add ethtool ability to set/get fresh device features
Date: Mon, 21 Mar 2022 11:20:58 -0700 [thread overview]
Message-ID: <20220321112058.4f2de739@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <d7fce582-4eb7-9b66-8a19-dd7633154a72@huawei.com>
On Mon, 21 Mar 2022 14:17:16 +0800 wangjie (L) wrote:
> I think SET_RINGS is OK for tx push, but next new device feature would
> still have this problem. As far as I know, features such as promisc,
> tx push are driver features. So should I still work on the new devfeature
> command netlink version for these standard driver features?
No.
next prev parent reply other threads:[~2022-03-21 18:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 3:21 [RFC net-next 0/2] add ethtool ops support for fresh device features Jie Wang
2022-03-15 3:21 ` [RFC net-next 1/2] net: ethtool: add ethtool ability to set/get " Jie Wang
2022-03-15 19:15 ` Jakub Kicinski
2022-03-15 19:56 ` Michal Kubecek
2022-03-16 1:45 ` Jakub Kicinski
2022-03-21 6:17 ` wangjie (L)
2022-03-21 18:20 ` Jakub Kicinski [this message]
2022-03-15 20:03 ` Roopa Prabhu
2022-03-16 1:40 ` Jakub Kicinski
2022-03-15 19:18 ` Michal Kubecek
2022-03-18 6:28 ` wangjie (L)
2022-03-15 3:21 ` [RFC net-next 2/2] net: hns3: add ethtool set/get device features support for hns3 driver Jie Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220321112058.4f2de739@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=chenhao288@hisilicon.com \
--cc=davem@davemloft.net \
--cc=huangguangbin2@huawei.com \
--cc=linyunsheng@huawei.com \
--cc=lipeng321@huawei.com \
--cc=mkubecek@suse.cz \
--cc=moyufeng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=shenjian15@huawei.com \
--cc=tanhuazhong@huawei.com \
--cc=wangjie125@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).