netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Chiu <andy.chiu@sifive.com>
To: radhey.shyam.pandey@xilinx.com, robert.hancock@calian.com,
	michal.simek@xilinx.com
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
	robh+dt@kernel.org, linux@armlinux.org.uk, andrew@lunn.ch,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	robh@kernel.org, Andy Chiu <andy.chiu@sifive.com>
Subject: [PATCH v5 net 0/4] Fix broken link on Xilinx's AXI Ethernet in SGMII mode
Date: Thu, 24 Mar 2022 02:00:18 +0800	[thread overview]
Message-ID: <20220323180022.864567-1-andy.chiu@sifive.com> (raw)

The Ethernet driver use phy-handle to reference the PCS/PMA PHY. This
could be a problem if one wants to configure an external PHY via phylink,
since it use the same phandle to get the PHY. To fix this, introduce a
dedicated pcs-handle to point to the PCS/PMA PHY and deprecate the use
of pointing it with phy-handle. A similar use case of pcs-handle can be
seen on dpaa2 as well.

The v4 patch was wrongly based on net-next tree. 1,2,4 parts of v5 patch
was generated after re-applying the v4 patch then resolving conflicts on
the net tree. 3/5 also describes the pcs-handle more globally at the
ethernet-controller device tree binding document.

Andy Chiu (4):
  net: axienet: setup mdio unconditionally
  net: axienet: factor out phy_node in struct axienet_local
  dt-bindings: net: add pcs-handle attribute
  net: axiemac: use a phandle to reference pcs_phy

 .../bindings/net/ethernet-controller.yaml     |  6 ++++
 .../bindings/net/xilinx_axienet.txt           |  8 ++++-
 drivers/net/ethernet/xilinx/xilinx_axienet.h  |  2 --
 .../net/ethernet/xilinx/xilinx_axienet_main.c | 33 ++++++++++---------
 4 files changed, 31 insertions(+), 18 deletions(-)

-- 
2.34.1


             reply	other threads:[~2022-03-23 18:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-23 18:00 Andy Chiu [this message]
2022-03-23 18:00 ` [PATCH v5 net 1/4] net: axienet: setup mdio unconditionally Andy Chiu
2022-03-23 18:00 ` [PATCH v5 net 2/4] net: axienet: factor out phy_node in struct axienet_local Andy Chiu
2022-03-23 18:00 ` [PATCH v5 net 3/4] dt-bindings: net: add pcs-handle attribute Andy Chiu
2022-03-25 19:23   ` Andrew Lunn
2022-03-28 12:54     ` Andy Chiu
2022-03-23 18:00 ` [PATCH v5 net 4/4] net: axiemac: use a phandle to reference pcs_phy Andy Chiu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220323180022.864567-1-andy.chiu@sifive.com \
    --to=andy.chiu@sifive.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=michal.simek@xilinx.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=radhey.shyam.pandey@xilinx.com \
    --cc=robert.hancock@calian.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).