From: Michael Walle <michael@walle.cc>
To: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Xu Liang <lxu@maxlinear.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Michael Walle <michael@walle.cc>
Subject: [PATCH RFC net-next v2 0/8] net: phy: C45-over-C22 access
Date: Fri, 25 Mar 2022 22:35:10 +0100 [thread overview]
Message-ID: <20220325213518.2668832-1-michael@walle.cc> (raw)
Hi,
This is the result of this discussion:
https://lore.kernel.org/netdev/240354b0a54b37e8b5764773711b8aa3@walle.cc/
The goal here is to get the GYP215 and LAN8814 running on the Microchip
LAN9668 SoC. The LAN9668 suppports one external bus and unfortunately, the
LAN8814 has a bug which makes it impossible to use C45 on that bus.
Fortunately, it was the intention of the GPY215 driver to be used on a C22
bus. But I think this could have never really worked, because the
phy_get_c45_ids() will always do c45 accesses and thus on MDIO bus drivers
which will correctly check for the MII_ADDR_C45 flag and return -EOPNOTSUPP
the function call will fail and thus gpy_probe() will fail. This series
tries to fix that and will lay the foundation to add a workaround for the
LAN8814 bug by forcing an MDIO bus to be c22-only.
At the moment, the probe_capabilities is taken into account to decide if
we have to use C45-over-C22. What is still missing from this series is the
handling of a device tree property to restrict the probe_capabilities to
c22-only.
Since net-next is closed, this is marked as RFC to get some early feedback.
Changes since RFC v1:
- use __phy_mmd_indirect() in mdiobus_probe_mmd_read()
- add new properties has_c45 c45_over_c22 (and remove is_c45)
- drop MDIOBUS_NO_CAP handling, Andrew is preparing a series to
add probe_capabilities to mark all C45 capable MDIO bus drivers
Michael Walle (8):
net: phy: mscc-miim: reject clause 45 register accesses
net: phy: mscc-miim: add probe_capabilities
net: phy: add error checks in __phy_mmd_indirect() and export it
net: phy: add error handling for __phy_{read,write}_mmd
net: phy: support indirect c45 access in get_phy_c45_ids()
net: phy: add support for C45-over-C22 transfers
phy: net: introduce phy_promote_to_c45()
net: phy: mxl-gpy: remove unneeded ops
.../net/ethernet/hisilicon/hns/hns_ethtool.c | 4 +-
drivers/net/mdio/mdio-mscc-miim.c | 7 ++
drivers/net/phy/bcm84881.c | 2 +-
drivers/net/phy/marvell10g.c | 2 +-
drivers/net/phy/mxl-gpy.c | 31 +------
drivers/net/phy/phy-core.c | 47 +++++++---
drivers/net/phy/phy.c | 6 +-
drivers/net/phy/phy_device.c | 87 ++++++++++++++++---
drivers/net/phy/phylink.c | 8 +-
include/linux/phy.h | 12 ++-
10 files changed, 136 insertions(+), 70 deletions(-)
--
2.30.2
next reply other threads:[~2022-03-25 21:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 21:35 Michael Walle [this message]
2022-03-25 21:35 ` [PATCH RFC net-next v2 1/8] net: phy: mscc-miim: reject clause 45 register accesses Michael Walle
2022-03-25 21:35 ` [PATCH RFC net-next v2 2/8] net: phy: mscc-miim: add probe_capabilities Michael Walle
2022-03-25 21:35 ` [PATCH RFC net-next v2 3/8] net: phy: add error checks in __phy_mmd_indirect() and export it Michael Walle
2022-03-25 21:35 ` [PATCH RFC net-next v2 4/8] net: phy: add error handling for __phy_{read,write}_mmd Michael Walle
2022-03-25 21:35 ` [PATCH RFC net-next v2 5/8] net: phy: support indirect c45 access in get_phy_c45_ids() Michael Walle
2022-03-25 21:35 ` [PATCH RFC net-next v2 6/8] net: phy: add support for C45-over-C22 transfers Michael Walle
2022-03-25 21:35 ` [PATCH RFC net-next v2 7/8] phy: net: introduce phy_promote_to_c45() Michael Walle
2022-03-25 21:35 ` [PATCH RFC net-next v2 8/8] net: phy: mxl-gpy: remove unneeded ops Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220325213518.2668832-1-michael@walle.cc \
--to=michael@walle.cc \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lxu@maxlinear.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).