netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Oltean <olteanv@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Matej Zachar <zachar.matej@gmail.com>,
	netdev@vger.kernel.org
Subject: Re: [DSA] fallback PTP to master port when switch does not support it
Date: Thu, 7 Apr 2022 12:44:39 +0300	[thread overview]
Message-ID: <20220407094439.ubf66iei3wgimx7d@skbuf> (raw)
In-Reply-To: <20220405124851.38fb977d@kernel.org>

On Tue, Apr 05, 2022 at 12:48:51PM -0700, Jakub Kicinski wrote:
> On Tue, 5 Apr 2022 00:04:30 +0200 Andrew Lunn wrote:
> > What i don't like about your proposed fallback is that it gives the
> > impression the slave ports actually support PTP, when they do not.
>
> +1, running PTP on the master means there is a non-PTP-aware switch
> in the path, which should not be taken lightly.

+2, the change could probably be technically done, and there are aspects
worth discussing, but the goal presented here is questionable and it's
best to not fool ourselves into thinking that the variable queuing delays
of the switch are taken into account when reporting the timestamps,
which they aren't.

I think that by the time you realize that you need PTP hardware
timestamping on switch ports but you have a PTP-unaware switch
integrated *into* your system, you need to go back to the drawing board.

  reply	other threads:[~2022-04-07  9:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-04 19:28 [DSA] fallback PTP to master port when switch does not support it Matej Zachar
2022-04-04 22:04 ` Andrew Lunn
2022-04-05 14:21   ` Matej Zachar
2022-04-05 19:48   ` Jakub Kicinski
2022-04-07  9:44     ` Vladimir Oltean [this message]
2022-05-25 15:00       ` Rodolfo Giometti
2022-05-25 15:55         ` Vladimir Oltean
2022-05-26  7:45           ` Rodolfo Giometti
2022-05-26 12:31             ` Vladimir Oltean
2022-05-25 18:18         ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220407094439.ubf66iei3wgimx7d@skbuf \
    --to=olteanv@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=zachar.matej@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).