netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Boris Sukholitko <boris.sukholitko@broadcom.com>
To: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Jiri Pirko <jiri@resnulli.us>,
	"Gustavo A . R . Silva" <gustavoars@kernel.org>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Eric Dumazet <edumazet@google.com>,
	zhang kai <zhangkaiheb@126.com>,
	Yoshiki Komachi <komachi.yoshiki@gmail.com>
Cc: Ilya Lifshits <ilya.lifshits@broadcom.com>,
	Boris Sukholitko <boris.sukholitko@broadcom.com>
Subject: [PATCH net-next 0/5] flower: match on the number of vlan tags
Date: Mon, 11 Apr 2022 16:30:55 +0300	[thread overview]
Message-ID: <20220411133100.18126-1-boris.sukholitko@broadcom.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1786 bytes --]

Hi,

Our customers in the fiber telecom world have network configurations
where they would like to control their traffic according to the number
of tags appearing in the packet.

For example, TR247 GPON conformance test suite specification mostly
talks about untagged, single, double tagged packets and gives lax
guidelines on the vlan protocol vs. number of vlan tags.

This is different from the common IT networks where 802.1Q and 802.1ad
protocols are usually describe single and double tagged packet. GPON
configurations that we work with have arbitrary mix the above protocols
and number of vlan tags in the packet.

The following patch series implement number of vlans flower filter. They
add num_of_vlans flower filter as an alternative to vlan ethtype protocol
matching. The end result is that the following command becomes possible:

tc filter add dev eth1 ingress flower \
  num_of_vlans 1 vlan_prio 5 action drop

More about the patch series:
  - patches 1-2 remove duplicate code by introducing is_key_vlan
    helper.
  - patch 3, 4 implement num_of_vlans in the dissector and in the
    flower.
  - patch 5 uses the num_of_vlans filter to allow further matching on
    vlan attributes.

Complementary iproute2 patches are being sent separately.

Thanks,
Boris.

Boris Sukholitko (5):
  Helper function for vlan ethtype checks
  Reduce identation after is_key_vlan refactoring
  Add number of vlan tags dissector
  Add number of vlan tags filter to the flower
  Consider the number of vlan tags for vlan filters

 include/net/flow_dissector.h |  9 ++++
 include/uapi/linux/pkt_cls.h |  2 +
 net/core/flow_dissector.c    | 20 +++++++++
 net/sched/cls_flower.c       | 86 +++++++++++++++++++++++-------------
 4 files changed, 86 insertions(+), 31 deletions(-)

-- 
2.29.2


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]

             reply	other threads:[~2022-04-11 13:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11 13:30 Boris Sukholitko [this message]
2022-04-11 13:30 ` [PATCH net-next 1/5] Helper function for vlan ethtype checks Boris Sukholitko
2022-04-11 13:30 ` [PATCH net-next 2/5] Reduce identation after is_key_vlan refactoring Boris Sukholitko
2022-04-11 13:30 ` [PATCH net-next 3/5] Add number of vlan tags dissector Boris Sukholitko
2022-04-11 13:30 ` [PATCH net-next 4/5] Add number of vlan tags filter to the flower Boris Sukholitko
2022-04-11 13:31 ` [PATCH net-next 5/5] Consider the number of vlan tags for vlan filters Boris Sukholitko
2022-04-11 15:34   ` Jiri Pirko
2022-04-12 10:06     ` Boris Sukholitko
2022-04-11 14:07 ` [PATCH net-next 0/5] flower: match on the number of vlan tags Jamal Hadi Salim
2022-04-11 14:56   ` Boris Sukholitko
2022-04-12 10:54     ` Jamal Hadi Salim
2022-04-14 12:59       ` Boris Sukholitko
  -- strict thread matches above, loose matches on Subject: below --
2022-03-23 10:55 Boris Sukholitko
2022-03-23 17:44 ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220411133100.18126-1-boris.sukholitko@broadcom.com \
    --to=boris.sukholitko@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gustavoars@kernel.org \
    --cc=ilya.lifshits@broadcom.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=komachi.yoshiki@gmail.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vladimir.oltean@nxp.com \
    --cc=xiyou.wangcong@gmail.com \
    --cc=zhangkaiheb@126.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).