From: Jakub Kicinski <kuba@kernel.org>
To: Eyal Birger <eyal.birger@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
asml.silence@gmail.com, aahringo@redhat.com, weiwan@google.com,
fw@strlen.de, yangbo.lu@nxp.com, tglx@linutronix.de,
dsahern@kernel.org, lnx.erin@gmail.com, mkl@pengutronix.de,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: align SO_RCVMARK required privileges with SO_MARK
Date: Thu, 5 May 2022 15:51:48 -0700 [thread overview]
Message-ID: <20220505155148.77dd4ca3@kernel.org> (raw)
In-Reply-To: <20220504095459.2663513-1-eyal.birger@gmail.com>
On Wed, 4 May 2022 12:54:59 +0300 Eyal Birger wrote:
> The commit referenced in the "Fixes" tag added the SO_RCVMARK socket
> option for receiving the skb mark in the ancillary data.
>
> Since this is a new capability, and exposes admin configured details
> regarding the underlying network setup to sockets, let's align the
> needed capabilities with those of SO_MARK.
>
> Fixes: 6fd1d51cfa25 ("net: SO_RCVMARK socket option for SO_MARK with recvmsg()")
> Signed-off-by: Eyal Birger <eyal.birger@gmail.com>
It's not really as bad as the ability to set the mark, but since
Erin is not complaining I assume it's fine with their use case.
next prev parent reply other threads:[~2022-05-05 22:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 9:54 [PATCH net-next] net: align SO_RCVMARK required privileges with SO_MARK Eyal Birger
2022-05-05 22:51 ` Jakub Kicinski [this message]
2022-05-06 1:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220505155148.77dd4ca3@kernel.org \
--to=kuba@kernel.org \
--cc=aahringo@redhat.com \
--cc=asml.silence@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=eyal.birger@gmail.com \
--cc=fw@strlen.de \
--cc=lnx.erin@gmail.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tglx@linutronix.de \
--cc=weiwan@google.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).