From: Jakub Kicinski <kuba@kernel.org>
To: Min Li <min.li.xe@renesas.com>
Cc: richardcochran@gmail.com, lee.jones@linaro.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net v4 1/2] ptp: ptp_clockmatrix: Add PTP_CLK_REQ_EXTTS support
Date: Thu, 5 May 2022 18:57:42 -0700 [thread overview]
Message-ID: <20220505185742.1246d738@kernel.org> (raw)
In-Reply-To: <1651697455-1588-1-git-send-email-min.li.xe@renesas.com>
On Wed, 4 May 2022 16:50:54 -0400 Min Li wrote:
> Use TOD_READ_SECONDARY for extts to keep TOD_READ_PRIMARY
> for gettime and settime exclusively
Can you fill in more details about what the user visible problem is?
Judging by the fact that you haven't tagged the patch as
[PATCH net-next] after my previous explanation you do think this
is a fix. But "Add xyz support" sounds like a feature, not a fix.
> Signed-off-by: Min Li <min.li.xe@renesas.com>
> Acked-by: Richard Cochran <richardcochran@gmail.com>
> - err = char_array_to_timespec(buf, sizeof(buf), ts);
> -
> - return err;
> + return char_array_to_timespec(buf, sizeof(buf), ts);
I don't think you were modifying this code, so no need to clean it up
in this commit. It's unrelated to the change you're making now.
> }
> - /* Re-enable extts */
> - if (extts_mask)
> - idtcm_enable_extts_mask(channel, extts_mask, true);
> + err = _idtcm_gettime(channel, ts, 10);
>
> return err;
> }
Here, tho, you are changing the code, and yet you haven't done what
I asked.
prev parent reply other threads:[~2022-05-06 1:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 20:50 [PATCH net v4 1/2] ptp: ptp_clockmatrix: Add PTP_CLK_REQ_EXTTS support Min Li
2022-05-04 20:50 ` [PATCH net v4 2/2] ptp: ptp_clockmatrix: return -EBUSY if phase pull-in is in progress Min Li
2022-05-06 1:53 ` Jakub Kicinski
2022-05-06 1:57 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220505185742.1246d738@kernel.org \
--to=kuba@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=min.li.xe@renesas.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).