From: "Alvin Šipraga" <ALSI@bang-olufsen.dk>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Hauke Mehrtens <hauke@hauke-m.de>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"vivien.didelot@gmail.com" <vivien.didelot@gmail.com>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 4/4] net: dsa: realtek: rtl8365mb: Add SGMII and HSGMII support
Date: Tue, 10 May 2022 19:23:01 +0000 [thread overview]
Message-ID: <20220510192301.5djdt3ghoavxulhl@bang-olufsen.dk> (raw)
In-Reply-To: <20220510172910.kthpd7kokb2qk27l@skbuf>
On Tue, May 10, 2022 at 08:29:10PM +0300, Vladimir Oltean wrote:
> On Mon, May 09, 2022 at 12:48:48AM +0200, Hauke Mehrtens wrote:
> > @@ -983,14 +1295,25 @@ static bool rtl8365mb_phy_mode_supported(struct dsa_switch *ds, int port,
> > static void rtl8365mb_phylink_get_caps(struct dsa_switch *ds, int port,
> > struct phylink_config *config)
> > {
> > - if (dsa_is_user_port(ds, port))
> > + int ext_int = rtl8365mb_extint_port_map[port];
> > +
> > + config->mac_capabilities = MAC_SYM_PAUSE | MAC_ASYM_PAUSE |
> > + MAC_10 | MAC_100 | MAC_1000FD;
> > +
> > + if (dsa_is_user_port(ds, port)) {
> > __set_bit(PHY_INTERFACE_MODE_INTERNAL,
> > config->supported_interfaces);
> > - else if (dsa_is_cpu_port(ds, port))
> > + } else if (dsa_is_cpu_port(ds, port)) {
>
> What does the quality of being a user port or a CPU port have to do with
> which interfaces are supported?
Right, I think this function was actually broken already in a few ways. The
switch will have ports with integrated PHYs, and ports with extension interfaces
like RGMII or SGMII etc. But which of those ports one uses as a CPU port, user
port, or (one day) DSA port, is of no concern to the switch. The supported
interface of a given port is a static property and simply a function of the port
number and switch model. All switch models in the family have between 1 and 2
ports with an extension interface.
Luiz introduced this map:
/* valid for all 6-port or less variants */
static const int rtl8365mb_extint_port_map[] = { -1, -1, -1, -1, -1, -1, 1, 2, -1, -1};
... which I think is actually what we ought to test on. It can be improved, but
currently it is correct for all supported models.
So something like this would be correct:
static void rtl8365mb_phylink_get_caps(struct dsa_switch *ds, int port,
struct phylink_config *config)
{
int ext_int = rtl8365mb_extint_port_map[port];
if (ext_int == -1) {
/* integrated PHY, set PHY_INTERFACE_MODE_INTERNAL etc. */
} else {
/* extension interface available, but here one should really
* check the model based on the chip ID/version, because it
* varies a lot
*/
if (model == RTL8365MB && ext_int == 1)
/* RGMII */
else if (model == RTL8367S && ext_int == 1)
/* SGMII / HSGMII */
else if (model == RTL8367S && ext_int == 2)
/* RGMII */
/* etc */
}
/* ... */
}
There are of course various ways to do this.
Hauke, do you follow what I mean? Would you like me to prepare a patch for the
current supported models/interfaces and then you can rebase your changes on top
of that to indicate support for (H)SGMII? Or do you want to give it a try
yourself?
Kind regards,
Alvin
>
> > + if (ext_int == 1) {
> > + __set_bit(PHY_INTERFACE_MODE_SGMII,
> > + config->supported_interfaces);
> > + __set_bit(PHY_INTERFACE_MODE_2500BASEX,
> > + config->supported_interfaces);
> > + config->mac_capabilities |= MAC_2500FD;
> > + }
> > phy_interface_set_rgmii(config->supported_interfaces);
> > + }
> >
> > - config->mac_capabilities = MAC_SYM_PAUSE | MAC_ASYM_PAUSE |
> > - MAC_10 | MAC_100 | MAC_1000FD;
> > }
> >
> > static void rtl8365mb_phylink_mac_config(struct dsa_switch *ds, int port,
next prev parent reply other threads:[~2022-05-10 19:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-08 22:48 [PATCH 0/4] net: dsa: realtek: rtl8365mb: Add SGMII and HSGMII support Hauke Mehrtens
2022-05-08 22:48 ` [PATCH 1/4] net: dsa: realtek: rtl8365mb: Fix interface type mask Hauke Mehrtens
2022-05-10 16:33 ` Alvin Šipraga
2022-05-08 22:48 ` [PATCH 2/4] net: dsa: realtek: rtl8365mb: Get chip option Hauke Mehrtens
2022-05-09 8:03 ` Luiz Angelo Daros de Luca
2022-05-10 16:32 ` Alvin Šipraga
2022-05-08 22:48 ` [PATCH 3/4] net: dsa: realtek: rtl8365mb: Add setting MTU Hauke Mehrtens
2022-05-09 6:45 ` Luiz Angelo Daros de Luca
2022-05-09 11:55 ` Andrew Lunn
2022-05-10 16:49 ` Alvin Šipraga
2022-05-10 17:31 ` Vladimir Oltean
2022-05-08 22:48 ` [PATCH 4/4] net: dsa: realtek: rtl8365mb: Add SGMII and HSGMII support Hauke Mehrtens
2022-05-10 17:29 ` Vladimir Oltean
2022-05-10 19:23 ` Alvin Šipraga [this message]
2022-05-11 23:44 ` Luiz Angelo Daros de Luca
2022-05-10 18:57 ` Alvin Šipraga
2022-05-09 6:28 ` [PATCH 0/4] " Luiz Angelo Daros de Luca
2022-05-09 7:38 ` Luiz Angelo Daros de Luca
2022-05-09 15:36 ` Florian Fainelli
2022-05-09 15:40 ` Vladimir Oltean
2022-05-09 15:41 ` Florian Fainelli
2022-05-09 15:49 ` Vladimir Oltean
2022-05-10 22:55 ` Hauke Mehrtens
2022-05-10 17:08 ` Alvin Šipraga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220510192301.5djdt3ghoavxulhl@bang-olufsen.dk \
--to=alsi@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).