Re: [PATCH net-next v4 00/12] add support for Renesas RZ/N1 ethernet subsystem devices

From: "Clément Léger" <clement.leger@bootlin.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
	"Vivien Didelot" <vivien.didelot@gmail.com>,
	"Vladimir Oltean" <olteanv@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Herve Codina" <herve.codina@bootlin.com>,
	"Miquèl Raynal" <miquel.raynal@bootlin.com>,
	"Milan Stevanovic" <milan.stevanovic@se.com>,
	"Jimmy Lalande" <jimmy.lalande@se.com>,
	"Pascal Eberhard" <pascal.eberhard@se.com>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v4 00/12] add support for Renesas RZ/N1 ethernet subsystem devices
Date: Wed, 11 May 2022 09:08:15 +0200	[thread overview]
Message-ID: <20220511090815.42deebac@xps-bootlin> (raw)
In-Reply-To: <1b097089-d6e6-5622-15aa-7038b66b1367@gmail.com>

Le Tue, 10 May 2022 09:30:17 -0700,
Florian Fainelli <f.fainelli@gmail.com> a écrit :

> On 5/9/22 06:18, Clément Léger wrote:
> > The Renesas RZ/N1 SoCs features an ethernet subsystem which contains
> > (most notably) a switch, two GMACs, and a MII converter [1]. This
> > series adds support for the switch and the MII converter.
> > 
> > The MII converter present on this SoC has been represented as a PCS
> > which sit between the MACs and the PHY. This PCS driver is probed
> > from the device-tree since it requires to be configured. Indeed the
> > MII converter also contains the registers that are handling the
> > muxing of ports (Switch, MAC, HSR, RTOS, etc) internally to the SoC.
> > 
> > The switch driver is based on DSA and exposes 4 ports + 1 CPU
> > management port. It include basic bridging support as well as FDB
> > and statistics support.
> > 
> > This series needs commits 14f11da778ff6421 ("soc: renesas: rzn1:
> > Select PM and PM_GENERIC_DOMAINS configs") and ed66b37f916ee23b
> > ("ARM: dts: r9a06g032: Add missing '#power-domain-cells'") which
> > are available on the renesas-devel tree in order to enable generic
> > power domain on RZ/N1.
> > 
> > Link: [1]
> > https://www.renesas.com/us/en/document/mah/rzn1d-group-rzn1s-group-rzn1l-group-users-manual-r-engine-and-ethernet-peripherals
> >  
> Build testing this patch set gave me the following Kconfig warnings:
> 
> WARNING: unmet direct dependencies detected for PCS_RZN1_MIIC
>    Depends on [n]: NETDEVICES [=y] && (ARCH_RZN1 [=n] || COMPILE_TEST
> [=n]) Selected by [m]:
>    - NET_DSA_RZN1_A5PSW [=m] && NETDEVICES [=y] && NET_DSA [=m]
> 
> WARNING: unmet direct dependencies detected for PCS_RZN1_MIIC
>    Depends on [n]: NETDEVICES [=y] && (ARCH_RZN1 [=n] || COMPILE_TEST
> [=n]) Selected by [m]:
>    - NET_DSA_RZN1_A5PSW [=m] && NETDEVICES [=y] && NET_DSA [=m]
> 
> WARNING: unmet direct dependencies detected for PCS_RZN1_MIIC
>    Depends on [n]: NETDEVICES [=y] && (ARCH_RZN1 [=n] || COMPILE_TEST
> [=n]) Selected by [m]:
>    - NET_DSA_RZN1_A5PSW [=m] && NETDEVICES [=y] && NET_DSA [=m]
> 
> I started off with arm64's defconfig and then enabled all of the DSA 
> drivers.

Ok, I'll fix that.

Clément