From: Kees Cook <keescook@chromium.org>
To: Maninder Singh <maninder1.s@samsung.com>
Cc: mcgrof@kernel.org, avimalin@gmail.com, ast@kernel.org,
daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com,
songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com,
kpsingh@kernel.org, pmladek@suse.com, rostedt@goodmis.org,
senozhatsky@chromium.org, andriy.shevchenko@linux.intel.com,
naveen.n.rao@linux.ibm.com, davem@davemloft.net,
mhiramat@kernel.org, anil.s.keshavamurthy@intel.com,
linux@rasmusvillemoes.dk, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
v.narang@samsung.com, Onkarnath <onkarnath.1@samsung.com>
Subject: Re: [PATCH 1/2] kallsyms: add kallsyms_show_value definition in all cases
Date: Wed, 11 May 2022 15:32:29 -0700 [thread overview]
Message-ID: <202205111525.92B1C597@keescook> (raw)
In-Reply-To: <20220511080657.3996053-1-maninder1.s@samsung.com>
On Wed, May 11, 2022 at 01:36:56PM +0530, Maninder Singh wrote:
> kallsyms_show_value return false if KALLSYMS is disabled,
> but its usage is done by module.c also.
> Thus when KALLSYMS is disabled, system will not print module
> load address:
Eek, I hadn't see the other changes this depends on. I think those
changes need to be reworked first. Notably in the other patch, this is
no good:
/* address belongs to module */
if (add_offset)
len = sprintf(buf, "0x%p+0x%lx", base, offset);
else
len = sprintf(buf, "0x%lx", value);
This is printing raw kernel addresses with no hashing, as far as I can
tell. That's not okay at all.
Once that other patch gets fixed, this one then can be revisited.
And just on naming: "kallsyms_tiny" is a weird name: it's just "ksyms"
-- there's no "all". :)
--
Kees Cook
next prev parent reply other threads:[~2022-05-11 22:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220511080722epcas5p459493d02ff662a7c75590e44a11e34a6@epcas5p4.samsung.com>
2022-05-11 8:06 ` [PATCH 1/2] kallsyms: add kallsyms_show_value definition in all cases Maninder Singh
[not found] ` <CGME20220511080728epcas5p2e377c38aba2e93dccc7fe8958e4724c2@epcas5p2.samsung.com>
2022-05-11 8:06 ` [PATCH 2/2] kallsyms: move sprint_module_info to kallsyms_tiny.c Maninder Singh
2022-05-11 22:32 ` Kees Cook [this message]
[not found] ` <CGME20220511080722epcas5p459493d02ff662a7c75590e44a11e34a6@epcms5p3>
2022-05-12 3:46 ` [PATCH 1/2] kallsyms: add kallsyms_show_value definition in all cases Maninder Singh
2022-05-12 9:53 ` andriy.shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202205111525.92B1C597@keescook \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=ast@kernel.org \
--cc=avimalin@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=maninder1.s@samsung.com \
--cc=mcgrof@kernel.org \
--cc=mhiramat@kernel.org \
--cc=naveen.n.rao@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=onkarnath.1@samsung.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=songliubraving@fb.com \
--cc=v.narang@samsung.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).