From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FFB8C433EF for ; Thu, 19 May 2022 04:57:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233857AbiESE5a (ORCPT ); Thu, 19 May 2022 00:57:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233855AbiESE53 (ORCPT ); Thu, 19 May 2022 00:57:29 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 452F684A2C for ; Wed, 18 May 2022 21:57:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9BED1B8218E for ; Thu, 19 May 2022 04:57:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10E7EC385B8; Thu, 19 May 2022 04:57:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652936245; bh=Gz8poSexFTfxj+21bXVMQaBVdKSv2LqL8rs7znBbVaM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pYY5LQDL12mN4a5ISPZGdjEKEyCBzXjedgrhB3lyPZ2uPdUF7A1T4qEWoyA3KgCkO e5C9ihJRoowD9PL3KbRq8zWgB9nA7FQqimfehPgBNIbQIpoTYIIq3DtVuI6amP318w ikQMBn92PyHsTP4YqxJa3Upgmnq8M+Q7WfTxrA70irnORpByxs6KiVZay7Z0XqMHHw f98jYiHwJozScaZAIA49FpfSp/ZiIptPQu/vuFZCZ69kgxJtOdDXBQVjpUaqixeur8 eSIoNPMlFu8l0GVrY8g5z3SqzNfi5yhprsJV5S5/pplVl5pecLN1BD3PRsOT5ASiq2 qEyxpYwuJIq4w== Date: Wed, 18 May 2022 21:57:23 -0700 From: Jakub Kicinski To: Tony Nguyen Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, Karol Kolacinski , netdev@vger.kernel.org, richardcochran@gmail.com, Gurucharan Subject: Re: [PATCH net-next 3/3] ice: add write functionality for GNSS TTY Message-ID: <20220518215723.28383e8e@kernel.org> In-Reply-To: <20220517211935.1949447-4-anthony.l.nguyen@intel.com> References: <20220517211935.1949447-1-anthony.l.nguyen@intel.com> <20220517211935.1949447-4-anthony.l.nguyen@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 17 May 2022 14:19:35 -0700 Tony Nguyen wrote: > From: Karol Kolacinski > > Add the possibility to write raw bytes to the GNSS module through the > first TTY device. This allows user to configure the module using the > publicly available u-blox UBX protocol (version 29) commands. > > Create a second read-only TTY device. Can you say more about how the TTY devices are discovered, and why there are two of them? Would be great if that info was present under Documentation/