From: Chengguang Xu <cgxu519@mykernel.net>
To: netdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-scsi@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-media@vger.kernel.org
Cc: Chengguang Xu <cgxu519@mykernel.net>
Subject: [PATCH 6/6] media: platform: fix missing/incorrect resource cleanup in error case
Date: Sun, 29 May 2022 23:34:56 +0800 [thread overview]
Message-ID: <20220529153456.4183738-7-cgxu519@mykernel.net> (raw)
In-Reply-To: <20220529153456.4183738-1-cgxu519@mykernel.net>
In error case of s5p_mfc_power_on() we should call
clk_disable_unprepare() for the
clocks(from pm->clocks[0] to pm->clocks[i-1]).
Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
drivers/media/platform/samsung/s5p-mfc/s5p_mfc_pm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_pm.c b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_pm.c
index 72a901e99450..187849841a28 100644
--- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_pm.c
+++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_pm.c
@@ -88,7 +88,6 @@ int s5p_mfc_power_on(void)
if (ret < 0) {
mfc_err("clock prepare failed for clock: %s\n",
pm->clk_names[i]);
- i++;
goto err;
}
}
@@ -98,7 +97,7 @@ int s5p_mfc_power_on(void)
return 0;
err:
- while (--i > 0)
+ while (--i >= 0)
clk_disable_unprepare(pm->clocks[i]);
pm_runtime_put(pm->device);
return ret;
--
2.27.0
next prev parent reply other threads:[~2022-05-29 15:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-29 15:34 [PATCH 0/6] fix a common error of while loop condition in error path Chengguang Xu
2022-05-29 15:34 ` [PATCH 1/6] netlink: fix missing destruction of rhash table in error case Chengguang Xu
2022-05-31 8:43 ` Paolo Abeni
2022-05-31 11:25 ` Dan Carpenter
2022-06-01 7:47 ` Chengguang Xu
2022-05-29 15:34 ` [PATCH 2/6] staging: vt6655: fix missing resource cleanup in error cases Chengguang Xu
2022-05-29 15:34 ` [PATCH 3/6] scsi: ipr: fix missing/incorrect resource cleanup in error case Chengguang Xu
2022-06-01 12:59 ` Brian King
2022-05-29 15:34 ` [PATCH 4/6] drm/exynos: fix missing " Chengguang Xu
2022-05-29 15:34 ` [PATCH 5/6] scsi: pmcraid: " Chengguang Xu
2022-05-29 15:34 ` Chengguang Xu [this message]
2022-05-30 8:20 ` [PATCH 0/6] fix a common error of while loop condition in error path Dan Carpenter
2022-06-08 2:27 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220529153456.4183738-7-cgxu519@mykernel.net \
--to=cgxu519@mykernel.net \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).