From: menglong8.dong@gmail.com
To: kuba@kernel.org
Cc: rostedt@goodmis.org, mingo@redhat.com, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, nhorman@tuxdriver.com,
ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
kafai@fb.com, songliubraving@fb.com, yhs@fb.com,
john.fastabend@gmail.com, kpsingh@kernel.org,
imagedong@tencent.com, dsahern@kernel.org, talalahmad@google.com,
keescook@chromium.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: [PATCH net-next v2 0/3] reorganize the code of the enum skb_drop_reason
Date: Mon, 30 May 2022 16:11:58 +0800 [thread overview]
Message-ID: <20220530081201.10151-1-imagedong@tencent.com> (raw)
From: Menglong Dong <imagedong@tencent.com>
The code of skb_drop_reason is a little wild, let's reorganize them.
Three things and three patches:
1) Move the enum 'skb_drop_reason' and related function to the standalone
header 'dropreason.h', as Jakub Kicinski suggested, as the skb drop
reasons are getting more and more.
2) use auto-generation to generate the source file that convert enum
skb_drop_reason to string.
3) make the comment of skb drop reasons kernel-doc style.
Changes since v1:
1/3: move dropreason.h from include/linux/ to include/net/ (Jakub Kicinski)
2/3: generate source file instead of header file for drop reasons string
array (Jakub Kicinski)
3/3: use inline comment (Jakub Kicinski)
Menglong Dong (3):
net: skb: move enum skb_drop_reason to standalone header file
net: skb: use auto-generation to convert skb drop reason to string
net: dropreason: reformat the comment fo skb drop reasons
include/linux/skbuff.h | 179 +------------------------
include/net/dropreason.h | 259 +++++++++++++++++++++++++++++++++++++
include/trace/events/skb.h | 89 +------------
net/core/.gitignore | 1 +
net/core/Makefile | 23 +++-
net/core/drop_monitor.c | 13 --
6 files changed, 284 insertions(+), 280 deletions(-)
create mode 100644 include/net/dropreason.h
create mode 100644 net/core/.gitignore
--
2.36.1
next reply other threads:[~2022-05-30 8:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-30 8:11 menglong8.dong [this message]
2022-05-30 8:11 ` [PATCH net-next v2 1/3] net: skb: move enum skb_drop_reason to standalone header file menglong8.dong
2022-05-30 8:12 ` [PATCH net-next v2 2/3] net: skb: use auto-generation to convert skb drop reason to string menglong8.dong
2022-05-30 10:01 ` kernel test robot
2022-05-30 14:23 ` Philip Li
2022-05-30 15:25 ` kernel test robot
2022-05-30 20:13 ` Jakub Kicinski
2022-06-01 3:27 ` Menglong Dong
2022-06-01 3:43 ` Jakub Kicinski
2022-05-30 8:12 ` [PATCH net-next v2 3/3] net: dropreason: reformat the comment fo skb drop reasons menglong8.dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220530081201.10151-1-imagedong@tencent.com \
--to=menglong8.dong@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=imagedong@tencent.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=keescook@chromium.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=pabeni@redhat.com \
--cc=rostedt@goodmis.org \
--cc=songliubraving@fb.com \
--cc=talalahmad@google.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).