From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 679C5C433F5 for ; Mon, 30 May 2022 13:48:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238035AbiE3Nr6 (ORCPT ); Mon, 30 May 2022 09:47:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238273AbiE3NpP (ORCPT ); Mon, 30 May 2022 09:45:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60EED9CC9A; Mon, 30 May 2022 06:32:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2C81B60F3E; Mon, 30 May 2022 13:32:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D3A4C36AE5; Mon, 30 May 2022 13:32:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653917556; bh=ejuhZEKzsLw6h/Md1QV3clFX/3mpYTU9ecrvIYpDi1U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q8Xa/IKz+vW+S/3NAb3lwYlF7DxZuDNsS/59zsXdj6COaDK3luJ1H+Giy7F+/Dj65 +H7LigjV9hjxMtTO1mTdLYwYHh+jDqjK3fAoxj4Ty7+3amWdLn70yqzBce0yarpgqP VBMqUEzDbY6p5M1OqiNwhO56D34/LCRdXEAKouwkKqGFUUQFM+25KcMEcImt8+Ft/d ZcU1EQuZ3EdKyI0kVNKfmIxYBAC7samJ+LnMD16xVB4ifhYO6PmO7SYxV/3msR3Re4 RKEGxt0Vr3J6ZU1PxajfLSlRsovNtzPByWwpwudw//ZvspTfe1Rw5qvLdf+qMKEQh/ 2Dauwgx9+BJpg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Haowen Bai , Edward Cree , Jakub Kicinski , Sasha Levin , habetsm.xilinx@gmail.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.17 023/135] sfc: ef10: Fix assigning negative value to unsigned variable Date: Mon, 30 May 2022 09:29:41 -0400 Message-Id: <20220530133133.1931716-23-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220530133133.1931716-1-sashal@kernel.org> References: <20220530133133.1931716-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Haowen Bai [ Upstream commit b8ff3395fbdf3b79a99d0ef410fc34c51044121e ] fix warning reported by smatch: 251 drivers/net/ethernet/sfc/ef10.c:2259 efx_ef10_tx_tso_desc() warn: assigning (-208) to unsigned variable 'ip_tot_len' Signed-off-by: Haowen Bai Acked-by: Edward Cree Link: https://lore.kernel.org/r/1649640757-30041-1-git-send-email-baihaowen@meizu.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/sfc/ef10.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c index 1ab725d554a5..e50dea0e3859 100644 --- a/drivers/net/ethernet/sfc/ef10.c +++ b/drivers/net/ethernet/sfc/ef10.c @@ -2256,7 +2256,7 @@ int efx_ef10_tx_tso_desc(struct efx_tx_queue *tx_queue, struct sk_buff *skb, * guaranteed to satisfy the second as we only attempt TSO if * inner_network_header <= 208. */ - ip_tot_len = -EFX_TSO2_MAX_HDRLEN; + ip_tot_len = 0x10000 - EFX_TSO2_MAX_HDRLEN; EFX_WARN_ON_ONCE_PARANOID(mss + EFX_TSO2_MAX_HDRLEN + (tcp->doff << 2u) > ip_tot_len); -- 2.35.1