From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2782C43334 for ; Thu, 2 Jun 2022 01:01:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232925AbiFBBBx (ORCPT ); Wed, 1 Jun 2022 21:01:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232915AbiFBBBw (ORCPT ); Wed, 1 Jun 2022 21:01:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F63AEB1; Wed, 1 Jun 2022 18:01:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BCE4A615B6; Thu, 2 Jun 2022 01:01:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03CE8C385A5; Thu, 2 Jun 2022 01:01:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654131709; bh=aC9ykK5hOX32xqGww6ZHmNtED1DXIZriCxTeqEarar4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qhkHOANd/4demtkSkrYacaFAmct1Faxrw1rc3/HSbUYfmbPYEcw2WAk4Bfj7UD44n Y75jIBiyjd1oZveBG/zyMpBA29Ykz1Gp/+/FolcWFYfFKEnAaJlY+vRUM8Yto7NK3k IFlIfelB+Kw/RG2FOw+VMG7uhXoxOFxobj7VsCyf/wNq3wtbffblY20nCK901QRdWB U3Tc3a2rEtQ/L2abxcw3UhwQa3RnKyUAdxcKMgFlwD/CF7MNI++C0ipfRtiOe1L00t qCzH2LQBeozcyetLatGMwrBY89VMJM46IPYUcCyvkIERH/+OJ+hoRIq1gyxWaaA/4p dhrOfYRUEYtJA== Date: Wed, 1 Jun 2022 18:01:47 -0700 From: Jakub Kicinski To: Joakim Tjernlund Cc: , Subject: Re: [PATCH] net-sysfs: allow changing sysfs carrier when interface is down Message-ID: <20220601180147.40a6e8ea@kernel.org> In-Reply-To: <20220602003523.19530-1-joakim.tjernlund@infinera.com> References: <20220602003523.19530-1-joakim.tjernlund@infinera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 2 Jun 2022 02:35:23 +0200 Joakim Tjernlund wrote: > UP/DOWN and carrier are async events and it makes sense one can > adjust carrier in sysfs before bringing the interface up. Can you explain your use case? > Signed-off-by: Joakim Tjernlund > Cc: stable@vger.kernel.org Seems a little too risky of a change to push into stable. > diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c > index a4ae65263384..3418ef7ef2d8 100644 > --- a/net/core/net-sysfs.c > +++ b/net/core/net-sysfs.c > @@ -167,8 +167,6 @@ static DEVICE_ATTR_RO(broadcast); > > static int change_carrier(struct net_device *dev, unsigned long new_carrier) > { > - if (!netif_running(dev)) > - return -EINVAL; > return dev_change_carrier(dev, (bool)new_carrier); > }