From: Martin Faltesek <mfaltesek@google.com>
To: kuba@kernel.org, krzysztof.kozlowski@linaro.org
Cc: christophe.ricard@gmail.com, gregkh@linuxfoundation.org,
groeck@google.com, jordy@pwning.systems, krzk@kernel.org,
mfaltesek@google.com, martin.faltesek@gmail.com,
netdev@vger.kernel.org, linux-nfc@lists.01.org,
sameo@linux.intel.com, wklin@google.com,
theflamefire89@gmail.com
Subject: [PATCH net v3 0/3] Split "nfc: st21nfca: Refactor EVT_TRANSACTION" into 3
Date: Mon, 6 Jun 2022 21:57:26 -0500 [thread overview]
Message-ID: <20220607025729.1673212-1-mfaltesek@google.com> (raw)
Change log:
v2 -> v3:
1. v2 review comment: modified sender email to match SoB line.
2. v2 review comment: threading emails by using git send-email as
recommended.
3. v2 review comment: added linux-nfc@lists.01.org. Tried to join
list but no reply so not sure if this messages makes it through.
4. v1 review comment: use net style multi-line comments.
This affected two multi-line comments in:
1/3
nfc: st21nfca: fix incorrect sizing calculations in EVT_TRANSACTION
5. added Cc: stable@vger.kernel.org in signoff area of each patch.
v1 -> v2:
Split the original patch into 3 patches, so that each one solves
a single issue. The original patch indicated 4 bugs, but two are
so closely related that I feel it makes sense to keep them
together.
1/3
nfc: st21nfca: fix incorrect validating logic in EVT_TRANSACTION
This is mentioned in v1 as #1. It just changes logical AND to
logical OR. The AND was rendering the check useless.
2/3
nfc: st21nfca: fix memory leaks in EVT_TRANSACTION handling
This is from v1 #3.
3/3
nfc: st21nfca: fix incorrect sizing calculations in EVT_TRANSACTION
This is from v1 #2 and #4
Both are derived from the same bug, which is the incorrect calculation
that buffer allocation size is skb->len - 2, so both should be combined.
After these 3 patches are applied, the end result is the same as v1
except:
1. minor comment rewording.
2. removed comments which felt superfluous explanations of obvious code.
v2: https://lore.kernel.org/netdev/20220401180939.2025819-1-mfaltesek@google.com/
v1: https://lore.kernel.org/netdev/20220329175431.3175472-1-mfaltesek@google.com/
Martin Faltesek (3):
nfc: st21nfca: fix incorrect validating logic in EVT_TRANSACTION
nfc: st21nfca: fix memory leaks in EVT_TRANSACTION handling
nfc: st21nfca: fix incorrect sizing calculations in EVT_TRANSACTION
drivers/nfc/st21nfca/se.c | 53 ++++++++++++++++++++++-----------------
1 file changed, 30 insertions(+), 23 deletions(-)
base-commit: b8d91399775c55162073bb2aca061ec42e3d4bc1
--
2.36.1.255.ge46751e96f-goog
next reply other threads:[~2022-06-07 2:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 2:57 Martin Faltesek [this message]
2022-06-07 2:57 ` [PATCH net v3 1/3] nfc: st21nfca: fix incorrect validating logic in EVT_TRANSACTION Martin Faltesek
2022-06-07 15:06 ` Guenter Roeck
2022-06-07 17:13 ` Krzysztof Kozlowski
2022-06-07 2:57 ` [PATCH net v3 2/3] nfc: st21nfca: fix memory leaks in EVT_TRANSACTION handling Martin Faltesek
2022-06-07 15:07 ` Guenter Roeck
2022-06-07 17:15 ` Krzysztof Kozlowski
2022-06-07 2:57 ` [PATCH net v3 3/3] nfc: st21nfca: fix incorrect sizing calculations in EVT_TRANSACTION Martin Faltesek
2022-06-07 15:09 ` Guenter Roeck
2022-06-08 7:09 ` Krzysztof Kozlowski
2022-06-08 18:00 ` [PATCH net v3 0/3] Split "nfc: st21nfca: Refactor EVT_TRANSACTION" into 3 patchwork-bot+netdevbpf
2022-07-20 7:24 ` Denis Efremov
2022-07-20 14:53 ` Martin Faltesek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220607025729.1673212-1-mfaltesek@google.com \
--to=mfaltesek@google.com \
--cc=christophe.ricard@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@google.com \
--cc=jordy@pwning.systems \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-nfc@lists.01.org \
--cc=martin.faltesek@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=theflamefire89@gmail.com \
--cc=wklin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).