From: Martin KaFai Lau <kafai@fb.com>
To: Stanislav Fomichev <sdf@google.com>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, ast@kernel.org,
daniel@iogearbox.net, andrii@kernel.org,
Jakub Sitnicki <jakub@cloudflare.com>
Subject: Re: [PATCH bpf-next v9 02/10] bpf: convert cgroup_bpf.progs to hlist
Date: Thu, 16 Jun 2022 12:59:44 -0700 [thread overview]
Message-ID: <20220616195944.dev72axh7prwnfh7@kafai-mbp> (raw)
In-Reply-To: <20220610165803.2860154-3-sdf@google.com>
On Fri, Jun 10, 2022 at 09:57:55AM -0700, Stanislav Fomichev wrote:
> This lets us reclaim some space to be used by new cgroup lsm slots.
>
> Before:
> struct cgroup_bpf {
> struct bpf_prog_array * effective[23]; /* 0 184 */
> /* --- cacheline 2 boundary (128 bytes) was 56 bytes ago --- */
> struct list_head progs[23]; /* 184 368 */
> /* --- cacheline 8 boundary (512 bytes) was 40 bytes ago --- */
> u32 flags[23]; /* 552 92 */
>
> /* XXX 4 bytes hole, try to pack */
>
> /* --- cacheline 10 boundary (640 bytes) was 8 bytes ago --- */
> struct list_head storages; /* 648 16 */
> struct bpf_prog_array * inactive; /* 664 8 */
> struct percpu_ref refcnt; /* 672 16 */
> struct work_struct release_work; /* 688 32 */
>
> /* size: 720, cachelines: 12, members: 7 */
> /* sum members: 716, holes: 1, sum holes: 4 */
> /* last cacheline: 16 bytes */
> };
>
> After:
> struct cgroup_bpf {
> struct bpf_prog_array * effective[23]; /* 0 184 */
> /* --- cacheline 2 boundary (128 bytes) was 56 bytes ago --- */
> struct hlist_head progs[23]; /* 184 184 */
> /* --- cacheline 5 boundary (320 bytes) was 48 bytes ago --- */
> u8 flags[23]; /* 368 23 */
>
> /* XXX 1 byte hole, try to pack */
>
> /* --- cacheline 6 boundary (384 bytes) was 8 bytes ago --- */
> struct list_head storages; /* 392 16 */
> struct bpf_prog_array * inactive; /* 408 8 */
> struct percpu_ref refcnt; /* 416 16 */
> struct work_struct release_work; /* 432 72 */
>
> /* size: 504, cachelines: 8, members: 7 */
> /* sum members: 503, holes: 1, sum holes: 1 */
> /* last cacheline: 56 bytes */
> };
>
> Suggested-by: Jakub Sitnicki <jakub@cloudflare.com>
> Reviewed-by: Jakub Sitnicki <jakub@cloudflare.com>
> Signed-off-by: Stanislav Fomichev <sdf@google.com>
Reviewed-by: Martin KaFai Lau <kafai@fb.com>
next prev parent reply other threads:[~2022-06-16 20:00 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 16:57 [PATCH bpf-next v9 00/10] bpf: cgroup_sock lsm flavor Stanislav Fomichev
2022-06-10 16:57 ` [PATCH bpf-next v9 01/10] bpf: add bpf_func_t and trampoline helpers Stanislav Fomichev
2022-06-16 19:53 ` Martin KaFai Lau
2022-06-10 16:57 ` [PATCH bpf-next v9 02/10] bpf: convert cgroup_bpf.progs to hlist Stanislav Fomichev
2022-06-16 19:59 ` Martin KaFai Lau [this message]
2022-06-10 16:57 ` [PATCH bpf-next v9 03/10] bpf: per-cgroup lsm flavor Stanislav Fomichev
2022-06-16 22:25 ` Martin KaFai Lau
2022-06-17 18:28 ` Stanislav Fomichev
2022-06-17 22:25 ` Martin KaFai Lau
2022-06-10 16:57 ` [PATCH bpf-next v9 04/10] bpf: minimize number of allocated lsm slots per program Stanislav Fomichev
2022-06-11 16:53 ` kernel test robot
2022-06-17 0:43 ` Martin KaFai Lau
2022-06-17 18:28 ` Stanislav Fomichev
2022-06-17 22:27 ` Martin KaFai Lau
2022-06-10 16:57 ` [PATCH bpf-next v9 05/10] bpf: implement BPF_PROG_QUERY for BPF_LSM_CGROUP Stanislav Fomichev
2022-06-17 0:58 ` Martin KaFai Lau
2022-06-17 18:28 ` Stanislav Fomichev
2022-06-17 22:29 ` Martin KaFai Lau
2022-06-10 16:57 ` [PATCH bpf-next v9 06/10] bpf: expose bpf_{g,s}etsockopt to lsm cgroup Stanislav Fomichev
2022-06-17 5:42 ` Martin KaFai Lau
2022-06-17 18:28 ` Stanislav Fomichev
2022-06-17 23:07 ` Martin KaFai Lau
2022-06-21 17:51 ` Stanislav Fomichev
2022-06-10 16:58 ` [PATCH bpf-next v9 07/10] libbpf: add lsm_cgoup_sock type Stanislav Fomichev
2022-06-10 16:58 ` [PATCH bpf-next v9 08/10] libbpf: implement bpf_prog_query_opts Stanislav Fomichev
2022-06-10 16:58 ` [PATCH bpf-next v9 09/10] bpftool: implement cgroup tree for BPF_LSM_CGROUP Stanislav Fomichev
2022-06-13 12:07 ` Quentin Monnet
2022-06-13 15:53 ` Stanislav Fomichev
2022-06-17 5:58 ` Martin KaFai Lau
2022-06-17 18:28 ` Stanislav Fomichev
2022-06-10 16:58 ` [PATCH bpf-next v9 10/10] selftests/bpf: lsm_cgroup functional test Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220616195944.dev72axh7prwnfh7@kafai-mbp \
--to=kafai@fb.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jakub@cloudflare.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).