From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5B25C433EF for ; Wed, 20 Jul 2022 08:23:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231947AbiGTIXS (ORCPT ); Wed, 20 Jul 2022 04:23:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230087AbiGTIXR (ORCPT ); Wed, 20 Jul 2022 04:23:17 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 198F46BC15 for ; Wed, 20 Jul 2022 01:23:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658305395; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WqWXkpMYDjGMkR6N048q9/Kkfh0q8LEuKcrhvdxBx9U=; b=Pc6LMPEyoz2HtuKBXbsluaQEs7uFaCR3iNU1AAK4zJvRQB6lMUKw/Sq3+yUVECyPMBHdZu XTn5FW1R64ucmf5NgTP4yDz2g3yhNmdO96FxjeDqfb9cR85gKvPM8Umv1uq8fs6Hx6894Y ay57I/mFkWs+yfXgBXQOEZf13d2QyGg= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-586-zBer2eaSOBuT2u7QDKwumA-1; Wed, 20 Jul 2022 04:23:13 -0400 X-MC-Unique: zBer2eaSOBuT2u7QDKwumA-1 Received: by mail-wr1-f70.google.com with SMTP id h6-20020adfaa86000000b0021e47bcbc6dso259362wrc.16 for ; Wed, 20 Jul 2022 01:23:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=WqWXkpMYDjGMkR6N048q9/Kkfh0q8LEuKcrhvdxBx9U=; b=0J1eujKuF/Ao+IKNXBQtFkT0C1dXtREbHWSatWEI7bLGmV0bip22ZB5LdmuWV6t19C zBkMpnGQF5ovotCLrQClGHi6FbkD/ICelSh41idekXjlY59TGINJ4MqBC4dEiC5Dim+2 Eyc7cI6H4mwZrnUbT9EWSnFXX6wsPt9jNCYrIeO8G0LMWkygR8xWHx7O3YLXPuXy2XWQ FaR8YBGY3dC5uaNG6dVgamzF9r1uTjQNZy9ZAw+SCNndAljp9L+teMn46YtFrTXIV4pV HmvKMtd/XVlsmu0rL4GKZ2IduVP6qr1LDpVzsHlFSdgzvsnzhgi3Y8+fliAdqDYUvo6f D+fg== X-Gm-Message-State: AJIora8XwOilnAn1Oi/MriZ0e+sygpjvmJ3j9U7iB21aBIUYC4yVygEE W05NJlmXKcjIAOxxDLoJU0DrWNyb3ukrS+FAf7l9XGks3vPe1aN7iM0K4Uy01LX+Q1DG8UV2K2T HJ/VkupvDGPwfOQ/S X-Received: by 2002:a05:600c:3227:b0:3a3:be7:2917 with SMTP id r39-20020a05600c322700b003a30be72917mr2760523wmp.83.1658305392296; Wed, 20 Jul 2022 01:23:12 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sk2lxdgaBkVc5Kem0cnAq2mfCBRvNA74098gzKOVACYFwhUlWyh6yfDCAwDcJmLBObthn+bA== X-Received: by 2002:a05:600c:3227:b0:3a3:be7:2917 with SMTP id r39-20020a05600c322700b003a30be72917mr2760502wmp.83.1658305392025; Wed, 20 Jul 2022 01:23:12 -0700 (PDT) Received: from sgarzare-redhat (host-79-46-200-178.retail.telecomitalia.it. [79.46.200.178]) by smtp.gmail.com with ESMTPSA id g8-20020a05600c4ec800b003a317ee3036sm1887541wmq.2.2022.07.20.01.23.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Jul 2022 01:23:11 -0700 (PDT) Date: Wed, 20 Jul 2022 10:23:07 +0200 From: Stefano Garzarella To: Arseniy Krasnov , Dexuan Cui Cc: "David S. Miller" , "edumazet@google.com" , Jakub Kicinski , Paolo Abeni , Stefan Hajnoczi , "Michael S. Tsirkin" , Krasnov Arseniy , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "netdev@vger.kernel.org" , "kvm@vger.kernel.org" , kernel Subject: Re: [RFC PATCH v1 2/3] virtio/vsock: use 'target' in notify_poll_in, callback. Message-ID: <20220720082307.djbf7qgnlsjmrxcf@sgarzare-redhat> References: <358f8d52-fd88-ad2e-87e2-c64bfa516a58@sberdevices.ru> <20220719124857.akv25sgp6np3pdaw@sgarzare-redhat> <15f38fcf-f1ff-3aad-4c30-4436bb8c4c44@sberdevices.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <15f38fcf-f1ff-3aad-4c30-4436bb8c4c44@sberdevices.ru> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jul 20, 2022 at 05:38:03AM +0000, Arseniy Krasnov wrote: >On 19.07.2022 15:48, Stefano Garzarella wrote: >> On Mon, Jul 18, 2022 at 08:17:31AM +0000, Arseniy Krasnov wrote: >>> This callback controls setting of POLLIN,POLLRDNORM output bits >>> of poll() syscall,but in some cases,it is incorrectly to set it, >>> when socket has at least 1 bytes of available data. Use 'target' >>> which is already exists and equal to sk_rcvlowat in this case. >>> >>> Signed-off-by: Arseniy Krasnov >>> --- >>> net/vmw_vsock/virtio_transport_common.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c >>> index ec2c2afbf0d0..591908740992 100644 >>> --- a/net/vmw_vsock/virtio_transport_common.c >>> +++ b/net/vmw_vsock/virtio_transport_common.c >>> @@ -634,7 +634,7 @@ virtio_transport_notify_poll_in(struct vsock_sock *vsk, >>>                 size_t target, >>>                 bool *data_ready_now) >>> { >>> -    if (vsock_stream_has_data(vsk)) >>> +    if (vsock_stream_has_data(vsk) >= target) >>>         *data_ready_now = true; >>>     else >>>         *data_ready_now = false; >> >> Perhaps we can take the opportunity to clean up the code in this way: >> >>     *data_ready_now = vsock_stream_has_data(vsk) >= target; >Ack >> >> Anyway, I think we also need to fix the other transports (vmci and hyperv), what do you think? >For vmci it is look clear to fix it. For hyperv i need to check it more, because it already >uses some internal target value. Yep, I see. Maybe you can pass `target` to hvs_channel_readable() and use it as parameter of HVS_PKT_LEN(). @Dexuan what do you think? Thanks, Stefano