From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD510C3F6B0 for ; Thu, 28 Jul 2022 19:16:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232042AbiG1TQi (ORCPT ); Thu, 28 Jul 2022 15:16:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229975AbiG1TQh (ORCPT ); Thu, 28 Jul 2022 15:16:37 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E9EBFD1B; Thu, 28 Jul 2022 12:16:36 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id tk8so4742829ejc.7; Thu, 28 Jul 2022 12:16:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ONx1ehxLnyTHA9EEGrHgivf8zt6D9uVlNbHw8cqH7Sk=; b=KK9jYcf06DPw+7mBE+NSCi7mIdNf0VdhFuxJN3OVwAoC9vZ3h7Fzv1vGpzQqibX/E6 QdePBfbEky1h1dDfMpY9OV7kVZ9DOzZyexZZ1gCl4Zu6IxGTSxQA3HlCgPWF5eAtgTBw XTQL4+pprLMLE3bR4khWfg+zX8FV+Q+GMVYsMV7ELlAIqtGbtfdS4JeSe0G173QMN+19 oCl6oxERPFsnlkwoJ9PV6GlJMhBIfVlUcP4R40NqRQ63j8giGu6ZiBygBsDdp/E0wQ5m QWF+vgiEA09hMAsIT+/wzQCP7By8QhzFPZJhWwvmtw7x3Wsx8VFtxWfUlbAOx43FlBPq p2cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ONx1ehxLnyTHA9EEGrHgivf8zt6D9uVlNbHw8cqH7Sk=; b=q2ru8zLOlgWLF+LzzQip5CenRn9DTuoUvt6m62/f/uxOkgC25wvRjwT61+SuoKikIH ZTEQAWWESFHtlkCOu8F2FlSIFiigBjqPfX1L4zp2Wh3FWs+ss8j+m/SZrvMMpjJOY4sC OpuhjwXzSvadYu7/kjUUs9McI7TzQvQ8hZfDtuXaoEhdEH9l96PzJ9pNmc5WduYDXwBk h96BYPWkP9hj8cNZ7NEcy10IE+eE38GIz5eGWO5t0V3hrXUYT+FSQfO9n25MusEtOl43 nqCHL5QUHXDTtAVNjmupMM7jxKYnoXEIipn0vb3VyOInFFygPnrPMzgPIzT74P2cm/nT 5pyg== X-Gm-Message-State: AJIora+tILHM2h6ruLt0YQAx1tXGpGFZnoYpwwzY1LsScTm4pfV5o58b y0UBd79VJOzQenu+OdpAQO4= X-Google-Smtp-Source: AGRyM1ssXfbw9msFBGK474SB5QXexyS2qmqCE9sNJQNzZlgkPSJvj2VLHWMtJLgmp9JqJnF0aGCjLQ== X-Received: by 2002:a17:907:8a0e:b0:72b:9ca3:507 with SMTP id sc14-20020a1709078a0e00b0072b9ca30507mr269063ejc.477.1659035794827; Thu, 28 Jul 2022 12:16:34 -0700 (PDT) Received: from skbuf ([188.25.231.115]) by smtp.gmail.com with ESMTPSA id ay15-20020a170906d28f00b00726dbb16b8dsm720901ejb.65.2022.07.28.12.16.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jul 2022 12:16:33 -0700 (PDT) Date: Thu, 28 Jul 2022 22:16:30 +0300 From: Vladimir Oltean To: Marcin Wojtas Cc: Andy Shevchenko , Linux Kernel Mailing List , ACPI Devel Maling List , netdev , "Rafael J. Wysocki" , Andy Shevchenko , Sean Wang , Landen Chao , Linus Walleij , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King - ARM Linux , Heiner Kallweit , Grzegorz Bernacki , Grzegorz Jaszczyk , Tomasz Nowicki , Samer El-Haj-Mahmoud , "upstream@semihalf.com" Subject: Re: [net-next: PATCH v3 6/8] net: core: switch to fwnode_find_net_device_by_node() Message-ID: <20220728191630.wjmm4mfbhrvbolqq@skbuf> References: <20220727064321.2953971-1-mw@semihalf.com> <20220727064321.2953971-7-mw@semihalf.com> <20220727143147.u6yd6wqslilspyhw@skbuf> <20220727163848.f4e2b263zz3vl2hc@skbuf> <20220728091643.m6c5d36pseenrw6l@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jul 28, 2022 at 06:56:48PM +0200, Marcin Wojtas wrote: > There was a regression even for OF in v1, but after switching to > device_match_fwnode() it works indeed. Anyway patch v4 is imo useful, > I'll only reword the commit message. Do you mean patch 4 or patch v4? If patch 4, of course it's useful, but not for avoiding a regression with OF (case in which I drop all my claims made earlier about fw_find_net_device_by_node), but rather to actually get something working with actual ACPI (although perhaps not in this series, you'll need to add ACPI IDs in the mv88e6xxx driver some time later as well, maybe you could focus this series just on converting DSA to play nice with fwnodes). If you're already thinking about the v4 of this patch set, I'll respond to that in a separate email shortly.