From: Tom Parkin <tparkin@katalix.com>
To: Jakub Sitnicki <jakub@cloudflare.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, kernel-team@cloudflare.com,
van fantasy <g1042620637@gmail.com>
Subject: Re: [PATCH net] l2tp: Serialize access to sk_user_data with sock lock
Date: Mon, 15 Aug 2022 09:43:14 +0100 [thread overview]
Message-ID: <20220815084313.GA5059@katalix.com> (raw)
In-Reply-To: <87edxlu6kd.fsf@cloudflare.com>
[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]
On Fri, Aug 12, 2022 at 11:54:43 +0200, Jakub Sitnicki wrote:
> On Thu, Aug 11, 2022 at 10:23 AM -07, Jakub Kicinski wrote:
> > On Wed, 10 Aug 2022 12:28:48 +0200 Jakub Sitnicki wrote:
> >> Fixes: fd558d186df2 ("l2tp: Split pppol2tp patch into separate l2tp and ppp parts")
> >
> > That tag immediately sets off red flags. Please find the commit where
> > to code originates, not where it was last moved.
>
> The code move happened in v2.6.35. There's no point in digging further, IMHO.
At the time of fd558d186df2, sk_user_data was checked/set by the newly
added function l2tp_tunnel_create. The only callpath for
l2tp_tunnel_create was via. pppol2tp_connect which called
l2tp_tunnel_create with lock_sock held (and indeed still does).
I think the addition of the netlink API (which added a new callpath
for l2tp_tunnel_create via. l2tp_nl_cmd_tunnel_create which was *not*
lock_sock-protected) is perhaps the right commit to point to?
309795f4bec2 ("l2tp: Add netlink control API for L2TP")
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-08-15 8:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 10:28 [PATCH net] l2tp: Serialize access to sk_user_data with sock lock Jakub Sitnicki
2022-08-11 17:23 ` Jakub Kicinski
2022-08-12 9:54 ` Jakub Sitnicki
2022-08-12 19:40 ` Jakub Kicinski
2022-08-15 8:43 ` Tom Parkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220815084313.GA5059@katalix.com \
--to=tparkin@katalix.com \
--cc=g1042620637@gmail.com \
--cc=jakub@cloudflare.com \
--cc=kernel-team@cloudflare.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).