From: Siddharth Vadapalli <s-vadapalli@ti.com>
To: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <robh+dt@kernel.org>,
<krzysztof.kozlowski@linaro.org>,
<krzysztof.kozlowski+dt@linaro.org>, <linux@armlinux.org.uk>,
<vladimir.oltean@nxp.com>, <grygorii.strashko@ti.com>,
<vigneshr@ti.com>, <nsekhar@ti.com>
Cc: <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <kishon@ti.com>,
<s-vadapalli@ti.com>
Subject: [PATCH 4/8] net: ethernet: ti: am65-cpsw: Add mac enable link function
Date: Wed, 14 Sep 2022 15:20:49 +0530 [thread overview]
Message-ID: <20220914095053.189851-5-s-vadapalli@ti.com> (raw)
In-Reply-To: <20220914095053.189851-1-s-vadapalli@ti.com>
Add function am65_cpsw_nuss_mac_enable_link() to invoke
am65_cpsw_enable_phy(), cpsw_ale_control_set(), am65_cpsw_qos_link_up()
and netif_tx_wake_all_queues() to prevent duplicate code. The above
set of function calls are currently invoked by the
am65_cpsw_nuss_mac_link_up() function. In a later patch in this series
meant for adding fixed-link support, even the am65_cpsw_nuss_mac_config()
function will invoke the same set of functions.
Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
---
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 25 ++++++++++++++----------
1 file changed, 15 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
index c7e6ad374e1a..72b1df12f320 100644
--- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
+++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
@@ -1473,6 +1473,20 @@ static void am65_cpsw_nuss_mac_control(struct am65_cpsw_port *port, phy_interfac
cpsw_sl_ctl_set(port->slave.mac_sl, mac_control);
}
+static void am65_cpsw_nuss_mac_enable_link(struct am65_cpsw_port *port, int speed, int duplex)
+{
+ struct am65_cpsw_common *common = port->common;
+ struct net_device *ndev = port->ndev;
+ /* enable phy */
+ am65_cpsw_enable_phy(port->slave.ifphy);
+
+ /* enable forwarding */
+ cpsw_ale_control_set(common->ale, port->port_id, ALE_PORT_STATE, ALE_PORT_STATE_FORWARD);
+
+ am65_cpsw_qos_link_up(ndev, speed);
+ netif_tx_wake_all_queues(ndev);
+}
+
static void am65_cpsw_nuss_mac_config(struct phylink_config *config, unsigned int mode,
const struct phylink_link_state *state)
{
@@ -1521,19 +1535,10 @@ static void am65_cpsw_nuss_mac_link_up(struct phylink_config *config, struct phy
struct am65_cpsw_slave_data *slave = container_of(config, struct am65_cpsw_slave_data,
phylink_config);
struct am65_cpsw_port *port = container_of(slave, struct am65_cpsw_port, slave);
- struct am65_cpsw_common *common = port->common;
- struct net_device *ndev = port->ndev;
am65_cpsw_nuss_mac_control(port, interface, speed, duplex, tx_pause, rx_pause);
- /* enable phy */
- am65_cpsw_enable_phy(port->slave.ifphy);
-
- /* enable forwarding */
- cpsw_ale_control_set(common->ale, port->port_id, ALE_PORT_STATE, ALE_PORT_STATE_FORWARD);
-
- am65_cpsw_qos_link_up(ndev, speed);
- netif_tx_wake_all_queues(ndev);
+ am65_cpsw_nuss_mac_enable_link(port, speed, duplex);
}
static const struct phylink_mac_ops am65_cpsw_phylink_mac_ops = {
--
2.25.1
next prev parent reply other threads:[~2022-09-14 9:51 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 9:50 [PATCH 0/8] Add support for J721e CPSW9G and SGMII mode Siddharth Vadapalli
2022-09-14 9:50 ` [PATCH 1/8] dt-bindings: net: ti: k3-am654-cpsw-nuss: Update bindings for J721e CPSW9G Siddharth Vadapalli
2022-09-14 16:20 ` Rob Herring
2022-09-15 7:28 ` Siddharth Vadapalli
2022-09-14 16:23 ` Rob Herring
2022-09-15 7:40 ` Siddharth Vadapalli
2022-09-14 9:50 ` [PATCH 2/8] net: ethernet: ti: am65-cpsw: Add support for SERDES configuration Siddharth Vadapalli
2022-09-14 15:37 ` Russell King (Oracle)
2022-09-15 8:36 ` Siddharth Vadapalli
2022-09-14 9:50 ` [PATCH 3/8] net: ethernet: ti: am65-cpsw: Add mac control function Siddharth Vadapalli
2022-09-14 15:53 ` Russell King (Oracle)
2022-09-14 9:50 ` Siddharth Vadapalli [this message]
2022-09-14 15:54 ` [PATCH 4/8] net: ethernet: ti: am65-cpsw: Add mac enable link function Russell King (Oracle)
2022-09-14 9:50 ` [PATCH 5/8] net: ethernet: ti: am65-cpsw: Add support for fixed-link configuration Siddharth Vadapalli
2022-09-14 15:41 ` Russell King (Oracle)
2022-09-15 8:59 ` Siddharth Vadapalli
2022-09-14 16:09 ` Russell King (Oracle)
2022-09-15 9:28 ` Siddharth Vadapalli
2022-09-15 10:07 ` Russell King (Oracle)
2022-09-16 4:54 ` Siddharth Vadapalli
2022-09-16 7:20 ` Russell King (Oracle)
2022-09-16 9:03 ` Siddharth Vadapalli
2022-09-16 9:14 ` Russell King (Oracle)
2022-09-16 9:55 ` Siddharth Vadapalli
2022-09-14 9:50 ` [PATCH 6/8] net: ethernet: ti: am65-cpsw: Add support for SGMII mode for J7200 CPSW5G Siddharth Vadapalli
2022-09-14 15:44 ` Russell King (Oracle)
2022-09-15 9:35 ` Siddharth Vadapalli
2022-09-14 16:04 ` Russell King (Oracle)
2022-09-15 9:40 ` Siddharth Vadapalli
2022-09-14 9:50 ` [PATCH 7/8] net: ethernet: ti: am65-cpsw: Add support for J721e CPSW9G Siddharth Vadapalli
2022-09-14 9:50 ` [PATCH 8/8] net: ethernet: ti: am65-cpsw: Enable SGMII mode " Siddharth Vadapalli
2022-09-16 9:57 ` [PATCH 0/8] Add support for J721e CPSW9G and SGMII mode Krzysztof Kozlowski
2022-09-16 10:07 ` Siddharth Vadapalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220914095053.189851-5-s-vadapalli@ti.com \
--to=s-vadapalli@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=grygorii.strashko@ti.com \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).