From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9303CECAAD3 for ; Wed, 14 Sep 2022 16:29:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229653AbiINQ3E (ORCPT ); Wed, 14 Sep 2022 12:29:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230112AbiINQ2X (ORCPT ); Wed, 14 Sep 2022 12:28:23 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F48983BEE for ; Wed, 14 Sep 2022 09:27:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9EF43B816DA for ; Wed, 14 Sep 2022 16:27:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EEC17C433D7; Wed, 14 Sep 2022 16:27:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663172859; bh=nosfAFh3LgJ6ZdIHu+YvxFaDr+3ibze7vvwYn09giEU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YkaUTiuxLMtkUhDWqDw78r41x962OUewAygj+Fdl2aX4L7JPHkHf5DO0eKCDW7mfe 7wIRA/r5x3rj1X2FeLO1b6bqAv0ggfmh5G5rBK9LhJKvEcHdiwYf9rbtJLQRkh56eJ P2GR3SjjyqRohybMzkxZZqqQ2IE9sLqRKAwEHVaOBGMtw1dKjUNAAK8V7G7wbZyD7t dFnEODgTAR/T7pOFcWtxCCz4c2/Lojyb81Pmr87aCuBZKgI9eyvvEwLMzXxg5kge/6 zBsGZzJrbqV313VUfZ1+fcvJIWxeaF4MHOpYkj2giv0IH2q0cKhZq8bjGFAf7eKoPG DRlix26lU6rPg== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Emeel Hakim Subject: [PATCH net-next V2 04/10] net/mlx5e: Fix MACsec initial packet number Date: Wed, 14 Sep 2022 17:27:07 +0100 Message-Id: <20220914162713.203571-5-saeed@kernel.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220914162713.203571-1-saeed@kernel.org> References: <20220914162713.203571-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Emeel Hakim Currently when creating MACsec object, next_pn which represents the initial packet number (PN) is considered only in TX flow. The above causes mismatch between TX and RX initial PN which is reflected in packet drops. Fix by considering next_pn in RX flow too. Fixes: aae3454e4d4c ("net/mlx5e: Add MACsec offload Rx command support") Signed-off-by: Emeel Hakim Reviewed-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c index 7cbccc76798c..006c3bad69a0 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c @@ -107,12 +107,11 @@ static int mlx5e_macsec_create_object(struct mlx5_core_dev *mdev, MLX5_SET64(macsec_offload_obj, obj, sci, (__force u64)(attrs->sci)); MLX5_SET(macsec_offload_obj, obj, aso_return_reg, MLX5_MACSEC_ASO_REG_C_4_5); MLX5_SET(macsec_offload_obj, obj, macsec_aso_access_pd, attrs->aso_pdn); + MLX5_SET(macsec_aso, aso_ctx, mode_parameter, attrs->next_pn); MLX5_SET(macsec_aso, aso_ctx, valid, 0x1); - if (is_tx) { + if (is_tx) MLX5_SET(macsec_aso, aso_ctx, mode, MLX5_MACSEC_ASO_INC_SN); - MLX5_SET(macsec_aso, aso_ctx, mode_parameter, attrs->next_pn); - } /* general object fields set */ MLX5_SET(general_obj_in_cmd_hdr, in, opcode, MLX5_CMD_OP_CREATE_GENERAL_OBJECT); -- 2.37.3