From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Kurt Kanzenbach <kurt@linutronix.de>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
Rui Sousa <rui.sousa@nxp.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Michael Walle <michael@walle.cc>,
Vinicius Costa Gomes <vinicius.gomes@intel.com>,
Maxim Kochetkov <fido_max@inbox.ru>,
Colin Foster <colin.foster@in-advantage.com>,
Richie Pearn <richard.pearn@nxp.com>,
Vladimir Oltean <olteanv@gmail.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
Gerhard Engleder <gerhard@engleder-embedded.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 08/13] net: dsa: hellcreek: deny tc-taprio changes to per-tc max SDU
Date: Wed, 14 Sep 2022 18:40:52 +0000 [thread overview]
Message-ID: <20220914184051.2awuutgr4vm4tfgf@skbuf> (raw)
In-Reply-To: <87a671bz8e.fsf@kurt>
On Wed, Sep 14, 2022 at 08:13:53PM +0200, Kurt Kanzenbach wrote:
> I'd rather like to see that feature implemented :-). Something like below.
>
> From 3d44683979bf50960125fa3005b1142af61525c7 Mon Sep 17 00:00:00 2001
> From: Kurt Kanzenbach <kurt@linutronix.de>
> Date: Wed, 14 Sep 2022 19:51:40 +0200
> Subject: [PATCH] net: dsa: hellcreek: Offload per-tc max SDU from tc-taprio
>
> Add support for configuring the max SDU per priority and per port. If not
> specified, keep the default.
>
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
> ---
Nice :) Do you also want the iproute2 patch, so you can test it?
> drivers/net/dsa/hirschmann/hellcreek.c | 61 +++++++++++++++++++++++---
> drivers/net/dsa/hirschmann/hellcreek.h | 7 +++
> 2 files changed, 61 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/dsa/hirschmann/hellcreek.c b/drivers/net/dsa/hirschmann/hellcreek.c
> index 5ceee71d9a25..1b22710e1641 100644
> --- a/drivers/net/dsa/hirschmann/hellcreek.c
> +++ b/drivers/net/dsa/hirschmann/hellcreek.c
> @@ -128,6 +128,16 @@ static void hellcreek_select_prio(struct hellcreek *hellcreek, int prio)
> hellcreek_write(hellcreek, val, HR_PSEL);
> }
>
> +static void hellcreek_select_port_prio(struct hellcreek *hellcreek, int port,
> + int prio)
> +{
> + u16 val = port << HR_PSEL_PTWSEL_SHIFT;
> +
> + val |= prio << HR_PSEL_PRTCWSEL_SHIFT;
> +
> + hellcreek_write(hellcreek, val, HR_PSEL);
> +}
> +
> static void hellcreek_select_counter(struct hellcreek *hellcreek, int counter)
> {
> u16 val = counter << HR_CSEL_SHIFT;
> @@ -1537,6 +1547,42 @@ hellcreek_port_prechangeupper(struct dsa_switch *ds, int port,
> return ret;
> }
>
> +static void hellcreek_setup_maxsdu(struct hellcreek *hellcreek, int port,
> + const struct tc_taprio_qopt_offload *schedule)
> +{
> + int tc;
> +
> + for (tc = 0; tc < 8; ++tc) {
> + u16 val;
> +
> + if (!schedule->max_sdu[tc])
> + continue;
> +
> + hellcreek_select_port_prio(hellcreek, port, tc);
> +
> + val = (schedule->max_sdu[tc] & HR_PTPRTCCFG_MAXSDU_MASK)
> + << HR_PTPRTCCFG_MAXSDU_SHIFT;
> +
> + hellcreek_write(hellcreek, val, HR_PTPRTCCFG);
So the maxSDU hardware register tracks exactly the L2 payload size, like
the software variable does, or does it include the Ethernet header size
and/or FCS?
> + }
> +}
next prev parent reply other threads:[~2022-09-14 18:40 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 15:32 [PATCH net-next 00/13] Add tc-taprio support for queueMaxSDU Vladimir Oltean
2022-09-14 15:32 ` [PATCH net-next 01/13] net/sched: taprio: remove redundant FULL_OFFLOAD_IS_ENABLED check in taprio_enqueue Vladimir Oltean
2022-09-14 15:32 ` [PATCH net-next 02/13] net/sched: taprio: stop going through private ops for dequeue and peek Vladimir Oltean
2022-09-14 15:32 ` [PATCH net-next 03/13] net/sched: taprio: add extack messages in taprio_init Vladimir Oltean
2022-09-14 15:32 ` [PATCH net-next 04/13] net/sched: taprio: allow user input of per-tc max SDU Vladimir Oltean
2022-09-14 21:43 ` Vinicius Costa Gomes
2022-09-14 22:10 ` Vladimir Oltean
2022-09-14 23:00 ` Vinicius Costa Gomes
2022-09-14 23:03 ` Vladimir Oltean
2022-09-14 23:17 ` Vinicius Costa Gomes
2022-09-14 23:03 ` Vinicius Costa Gomes
2022-09-14 23:11 ` Vladimir Oltean
2022-09-14 15:32 ` [PATCH net-next 05/13] net: dsa: felix: offload per-tc max SDU from tc-taprio Vladimir Oltean
2022-09-14 15:32 ` [PATCH net-next 06/13] net: enetc: cache accesses to &priv->si->hw Vladimir Oltean
2022-09-14 15:32 ` [PATCH net-next 07/13] net: enetc: offload per-tc max SDU from tc-taprio Vladimir Oltean
2022-09-14 15:32 ` [PATCH net-next 08/13] net: dsa: hellcreek: deny tc-taprio changes to per-tc max SDU Vladimir Oltean
2022-09-14 18:13 ` Kurt Kanzenbach
2022-09-14 18:40 ` Vladimir Oltean [this message]
2022-09-14 20:13 ` Vladimir Oltean
2022-09-15 6:15 ` Kurt Kanzenbach
2022-09-15 11:59 ` Vladimir Oltean
2022-09-19 13:36 ` Kurt Kanzenbach
2022-09-21 11:23 ` Kurt Kanzenbach
2022-09-21 11:29 ` Vladimir Oltean
2022-09-21 11:46 ` Kurt Kanzenbach
2022-09-21 14:12 ` Vladimir Oltean
2022-09-21 14:21 ` Vladimir Oltean
2022-09-22 8:10 ` Kurt Kanzenbach
2022-09-14 15:32 ` [PATCH net-next 09/13] net: dsa: sja1105: " Vladimir Oltean
2022-09-14 15:33 ` [PATCH net-next 10/13] tsnep: " Vladimir Oltean
2022-09-15 19:01 ` Gerhard Engleder
2022-09-16 13:57 ` Vladimir Oltean
2022-09-16 19:53 ` Gerhard Engleder
2022-09-16 22:16 ` Vladimir Oltean
2022-09-14 15:33 ` [PATCH net-next 11/13] igc: " Vladimir Oltean
2022-09-14 15:33 ` [PATCH net-next 12/13] net: stmmac: " Vladimir Oltean
2022-09-14 15:33 ` [PATCH net-next 13/13] net: am65-cpsw: " Vladimir Oltean
2022-09-14 21:47 ` [PATCH net-next 00/13] Add tc-taprio support for queueMaxSDU Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220914184051.2awuutgr4vm4tfgf@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=claudiu.manoil@nxp.com \
--cc=colin.foster@in-advantage.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=fido_max@inbox.ru \
--cc=gerhard@engleder-embedded.com \
--cc=grygorii.strashko@ti.com \
--cc=jesse.brandeburg@intel.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=richard.pearn@nxp.com \
--cc=rui.sousa@nxp.com \
--cc=vinicius.gomes@intel.com \
--cc=vivien.didelot@gmail.com \
--cc=xiaoliang.yang_1@nxp.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).