From: Jakub Kicinski <kuba@kernel.org>
To: Chunhao Lin <hau@realtek.com>
Cc: <hkallweit1@gmail.com>, <netdev@vger.kernel.org>,
<nic_swsd@realtek.com>, <grundler@chromium.org>
Subject: Re: [PATCH net-next v2] r8169: fix rtl8125b dmar pte write access not set error
Date: Mon, 3 Oct 2022 17:06:45 -0700 [thread overview]
Message-ID: <20221003170645.687f33a7@kernel.org> (raw)
In-Reply-To: <20221003070333.29556-1-hau@realtek.com>
On Mon, 3 Oct 2022 15:03:33 +0800 Chunhao Lin wrote:
> When close device, rx will be enabled if wol is enabeld. When open device
> it will cause rx to dma to wrong address after pci_set_master().
>
> In this patch, driver will disable tx/rx when close device. If wol is
> eanbled only enable rx filter and disable rxdv_gate to let hardware can
> receive packet to fifo but not to dma it.
>
> Signed-off-by: Chunhao Lin <hau@realtek.com>
> ---
> v1 -> v2: limit the call to rtl_disable_rxdvgate()
Ah, I didn't notice there was a v2, same comments as for v1:
looks like a fix..
prev parent reply other threads:[~2022-10-04 0:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 7:03 [PATCH net-next v2] r8169: fix rtl8125b dmar pte write access not set error Chunhao Lin
2022-10-04 0:06 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221003170645.687f33a7@kernel.org \
--to=kuba@kernel.org \
--cc=grundler@chromium.org \
--cc=hau@realtek.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).