From: Ido Schimmel <idosch@nvidia.com>
To: netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, roopa@nvidia.com, razor@blackwall.org,
mlxsw@nvidia.com, Ido Schimmel <idosch@nvidia.com>
Subject: [RFC PATCH net-next 04/19] bridge: mcast: Propagate MDB configuration structure further
Date: Tue, 18 Oct 2022 15:04:05 +0300 [thread overview]
Message-ID: <20221018120420.561846-5-idosch@nvidia.com> (raw)
In-Reply-To: <20221018120420.561846-1-idosch@nvidia.com>
As an intermediate step towards only using the new MDB configuration
structure, pass it further in the control path instead of passing
individual attributes.
No functional changes intended.
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
---
net/bridge/br_mdb.c | 24 +++++++++++-------------
1 file changed, 11 insertions(+), 13 deletions(-)
diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c
index cdc71516a51b..2f9b192500a3 100644
--- a/net/bridge/br_mdb.c
+++ b/net/bridge/br_mdb.c
@@ -959,17 +959,15 @@ static int br_mdb_add_group(struct net_bridge *br, struct net_bridge_port *port,
return 0;
}
-static int __br_mdb_add(struct net *net, struct net_bridge *br,
- struct net_bridge_port *p,
- struct br_mdb_entry *entry,
+static int __br_mdb_add(struct br_mdb_config *cfg,
struct nlattr **mdb_attrs,
struct netlink_ext_ack *extack)
{
int ret;
- spin_lock_bh(&br->multicast_lock);
- ret = br_mdb_add_group(br, p, entry, mdb_attrs, extack);
- spin_unlock_bh(&br->multicast_lock);
+ spin_lock_bh(&cfg->br->multicast_lock);
+ ret = br_mdb_add_group(cfg->br, cfg->p, cfg->entry, mdb_attrs, extack);
+ spin_unlock_bh(&cfg->br->multicast_lock);
return ret;
}
@@ -1120,22 +1118,22 @@ static int br_mdb_add(struct sk_buff *skb, struct nlmsghdr *nlh,
if (br_vlan_enabled(cfg.br->dev) && vg && cfg.entry->vid == 0) {
list_for_each_entry(v, &vg->vlan_list, vlist) {
cfg.entry->vid = v->vid;
- err = __br_mdb_add(net, cfg.br, cfg.p, cfg.entry,
- mdb_attrs, extack);
+ err = __br_mdb_add(&cfg, mdb_attrs, extack);
if (err)
break;
}
} else {
- err = __br_mdb_add(net, cfg.br, cfg.p, cfg.entry, mdb_attrs,
- extack);
+ err = __br_mdb_add(&cfg, mdb_attrs, extack);
}
return err;
}
-static int __br_mdb_del(struct net_bridge *br, struct br_mdb_entry *entry,
+static int __br_mdb_del(struct br_mdb_config *cfg,
struct nlattr **mdb_attrs)
{
+ struct br_mdb_entry *entry = cfg->entry;
+ struct net_bridge *br = cfg->br;
struct net_bridge_mdb_entry *mp;
struct net_bridge_port_group *p;
struct net_bridge_port_group __rcu **pp;
@@ -1206,10 +1204,10 @@ static int br_mdb_del(struct sk_buff *skb, struct nlmsghdr *nlh,
if (br_vlan_enabled(cfg.br->dev) && vg && cfg.entry->vid == 0) {
list_for_each_entry(v, &vg->vlan_list, vlist) {
cfg.entry->vid = v->vid;
- err = __br_mdb_del(cfg.br, cfg.entry, mdb_attrs);
+ err = __br_mdb_del(&cfg, mdb_attrs);
}
} else {
- err = __br_mdb_del(cfg.br, cfg.entry, mdb_attrs);
+ err = __br_mdb_del(&cfg, mdb_attrs);
}
return err;
--
2.37.3
next prev parent reply other threads:[~2022-10-18 12:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 12:04 [RFC PATCH net-next 00/19] bridge: mcast: Extensions for EVPN Ido Schimmel
2022-10-18 12:04 ` [RFC PATCH net-next 01/19] bridge: mcast: Centralize netlink attribute parsing Ido Schimmel
2022-10-18 12:04 ` [RFC PATCH net-next 02/19] bridge: mcast: Remove redundant checks Ido Schimmel
2022-10-18 12:04 ` [RFC PATCH net-next 03/19] bridge: mcast: Use MDB configuration structure where possible Ido Schimmel
2022-10-18 12:04 ` Ido Schimmel [this message]
2022-10-18 12:04 ` [RFC PATCH net-next 05/19] bridge: mcast: Use MDB group key from configuration structure Ido Schimmel
2022-10-18 12:04 ` [RFC PATCH net-next 06/19] bridge: mcast: Remove br_mdb_parse() Ido Schimmel
2022-10-18 12:04 ` [RFC PATCH net-next 07/19] bridge: mcast: Move checks out of critical section Ido Schimmel
2022-10-18 12:04 ` [RFC PATCH net-next 08/19] bridge: mcast: Remove redundant function arguments Ido Schimmel
2022-10-18 12:04 ` [RFC PATCH net-next 09/19] bridge: mcast: Do not derive entry type from its filter mode Ido Schimmel
2022-10-18 12:04 ` [RFC PATCH net-next 10/19] bridge: mcast: Split (*, G) and (S, G) addition into different functions Ido Schimmel
2022-10-18 12:04 ` [RFC PATCH net-next 11/19] bridge: mcast: Place netlink policy before validation functions Ido Schimmel
2022-10-18 12:04 ` [RFC PATCH net-next 12/19] bridge: mcast: Add a centralized error path Ido Schimmel
2022-10-18 12:04 ` [RFC PATCH net-next 13/19] bridge: mcast: Expose br_multicast_new_group_src() Ido Schimmel
2022-10-18 12:04 ` [RFC PATCH net-next 14/19] bridge: mcast: Add a flag for user installed source entries Ido Schimmel
2022-10-18 12:04 ` [RFC PATCH net-next 15/19] bridge: mcast: Avoid arming group timer when (S, G) corresponds to a source Ido Schimmel
2022-10-18 12:04 ` [RFC PATCH net-next 16/19] bridge: mcast: Add support for (*, G) with a source list and filter mode Ido Schimmel
2022-10-18 12:04 ` [RFC PATCH net-next 17/19] bridge: mcast: Allow user space to add " Ido Schimmel
2022-10-19 13:28 ` Nikolay Aleksandrov
2022-11-03 9:09 ` Ido Schimmel
2022-10-18 12:04 ` [RFC PATCH net-next 18/19] bridge: mcast: Allow user space to specify MDB entry routing protocol Ido Schimmel
2022-10-18 12:04 ` [RFC PATCH net-next 19/19] bridge: mcast: Support replacement of MDB port group entries Ido Schimmel
2022-10-18 19:21 ` [RFC PATCH net-next 00/19] bridge: mcast: Extensions for EVPN Jakub Kicinski
2022-10-25 10:53 ` Ido Schimmel
2022-10-19 13:15 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221018120420.561846-5-idosch@nvidia.com \
--to=idosch@nvidia.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).