From: Andy Chiu <andy.chiu@sifive.com>
To: davem@davemloft.net, andrew@lunn.ch, kuba@kernel.org,
michal.simek@xilinx.com, radhey.shyam.pandey@xilinx.com
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org,
pabeni@redhat.com, edumazet@google.com, andy.chiu@sifive.com,
greentime.hu@sifive.com
Subject: [PATCH v5 net-next 1/3] net: axienet: Unexport and remove unused mdio functions
Date: Thu, 17 Nov 2022 23:40:12 +0800 [thread overview]
Message-ID: <20221117154014.1418834-2-andy.chiu@sifive.com> (raw)
In-Reply-To: <20221117154014.1418834-1-andy.chiu@sifive.com>
Both axienet_mdio_{enable/disable} functions are no longer used in
xilinx_axienet_main.c due to 253761a0e61b7. And axienet_mdio_disable is
not even used in the mdio.c. So unexport and remove them.
Signed-off-by: Andy Chiu <andy.chiu@sifive.com>
Reviewed-by: Greentime Hu <greentime.hu@sifive.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/net/ethernet/xilinx/xilinx_axienet.h | 2 --
drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c | 13 +------------
2 files changed, 1 insertion(+), 14 deletions(-)
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet.h b/drivers/net/ethernet/xilinx/xilinx_axienet.h
index 6370c447ac5c..575ff9de8985 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet.h
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet.h
@@ -611,8 +611,6 @@ static inline void axienet_dma_out_addr(struct axienet_local *lp, off_t reg,
#endif /* CONFIG_64BIT */
/* Function prototypes visible in xilinx_axienet_mdio.c for other files */
-int axienet_mdio_enable(struct axienet_local *lp);
-void axienet_mdio_disable(struct axienet_local *lp);
int axienet_mdio_setup(struct axienet_local *lp);
void axienet_mdio_teardown(struct axienet_local *lp);
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c b/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c
index 0b3b6935c558..e1f51a071888 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c
@@ -153,7 +153,7 @@ static int axienet_mdio_write(struct mii_bus *bus, int phy_id, int reg,
* Sets up the MDIO interface by initializing the MDIO clock and enabling the
* MDIO interface in hardware.
**/
-int axienet_mdio_enable(struct axienet_local *lp)
+static int axienet_mdio_enable(struct axienet_local *lp)
{
u32 host_clock;
@@ -226,17 +226,6 @@ int axienet_mdio_enable(struct axienet_local *lp)
return axienet_mdio_wait_until_ready(lp);
}
-/**
- * axienet_mdio_disable - MDIO hardware disable function
- * @lp: Pointer to axienet local data structure.
- *
- * Disable the MDIO interface in hardware.
- **/
-void axienet_mdio_disable(struct axienet_local *lp)
-{
- axienet_iow(lp, XAE_MDIO_MC_OFFSET, 0);
-}
-
/**
* axienet_mdio_setup - MDIO setup function
* @lp: Pointer to axienet local data structure.
--
2.36.0
next prev parent reply other threads:[~2022-11-17 15:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 15:40 [PATCH v5 net-next 0/3] net: axienet: Use a DT property to configure frequency of the MDIO bus Andy Chiu
2022-11-17 15:40 ` Andy Chiu [this message]
2022-11-17 15:40 ` [PATCH v5 net-next 2/3] dt-bindings: describe the support of "clock-frequency" in mdio Andy Chiu
2022-11-17 15:40 ` [PATCH v5 net-next 3/3] net: axienet: set mdio clock according to bus-frequency Andy Chiu
2022-11-17 15:46 ` Pandey, Radhey Shyam
2022-11-18 0:07 ` Andrew Lunn
2022-11-21 10:40 ` [PATCH v5 net-next 0/3] net: axienet: Use a DT property to configure frequency of the MDIO bus patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221117154014.1418834-2-andy.chiu@sifive.com \
--to=andy.chiu@sifive.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=greentime.hu@sifive.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=radhey.shyam.pandey@xilinx.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).