From: Tim Harvey <tharvey@gateworks.com>
To: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Tim Harvey <tharvey@gateworks.com>
Subject: [PATCH 2/3] net: phy: dp83867: add LED mode configuration via dt
Date: Thu, 17 Nov 2022 16:15:47 -0800 [thread overview]
Message-ID: <20221118001548.635752-3-tharvey@gateworks.com> (raw)
In-Reply-To: <20221118001548.635752-1-tharvey@gateworks.com>
Add configuration of LED modes per device-tree property ti,led-modes.
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
drivers/net/phy/dp83867.c | 32 ++++++++++++++++++++++++++++++--
1 file changed, 30 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
index 6939563d3b7c..008941a8d6aa 100644
--- a/drivers/net/phy/dp83867.c
+++ b/drivers/net/phy/dp83867.c
@@ -26,6 +26,7 @@
#define MII_DP83867_MICR 0x12
#define MII_DP83867_ISR 0x13
#define DP83867_CFG2 0x14
+#define DP83867_LEDCR1 0x18
#define DP83867_CFG3 0x1e
#define DP83867_CTRL 0x1f
@@ -150,6 +151,10 @@
/* FLD_THR_CFG */
#define DP83867_FLD_THR_CFG_ENERGY_LOST_THR_MASK 0x7
+/* LED Configuration 1 bits */
+#define DP83867_LED_MODE_SHIFT 4
+#define DP83867_LED_MODE_MASK 0xf
+
enum {
DP83867_PORT_MIRROING_KEEP,
DP83867_PORT_MIRROING_EN,
@@ -167,6 +172,7 @@ struct dp83867_private {
bool set_clk_output;
u32 clk_output_sel;
bool sgmii_ref_clk_en;
+ int led_modes[4];
};
static int dp83867_ack_interrupt(struct phy_device *phydev)
@@ -573,7 +579,7 @@ static int dp83867_of_init(struct phy_device *phydev)
struct dp83867_private *dp83867 = phydev->priv;
struct device *dev = &phydev->mdio.dev;
struct device_node *of_node = dev->of_node;
- int ret;
+ int ret, led;
if (!of_node)
return -ENODEV;
@@ -658,6 +664,13 @@ static int dp83867_of_init(struct phy_device *phydev)
return -EINVAL;
}
+ if (of_property_read_u32_array(of_node, "ti,led-modes",
+ dp83867->led_modes,
+ ARRAY_SIZE(dp83867->led_modes))) {
+ for (led = 0; led < ARRAY_SIZE(dp83867->led_modes); led++)
+ dp83867->led_modes[led] = -EINVAL;
+ }
+
return 0;
}
#else
@@ -665,6 +678,7 @@ static int dp83867_of_init(struct phy_device *phydev)
{
struct dp83867_private *dp83867 = phydev->priv;
u16 delay;
+ int led;
/* For non-OF device, the RX and TX ID values are either strapped
* or take from default value. So, we init RX & TX ID values here
@@ -682,6 +696,10 @@ static int dp83867_of_init(struct phy_device *phydev)
*/
dp83867->io_impedance = DP83867_IO_MUX_CFG_IO_IMPEDANCE_MIN / 2;
+ /* LED mode unconfigured */
+ for (led = 0; led < ARRAY_SIZE(dp83867->led_modes); led++)
+ dp83867->led_modes[led] = -EINVAL;
+
return 0;
}
#endif /* CONFIG_OF_MDIO */
@@ -703,7 +721,7 @@ static int dp83867_probe(struct phy_device *phydev)
static int dp83867_config_init(struct phy_device *phydev)
{
struct dp83867_private *dp83867 = phydev->priv;
- int ret, val, bs;
+ int ret, val, bs, led;
u16 delay;
/* Force speed optimization for the PHY even if it strapped */
@@ -882,6 +900,16 @@ static int dp83867_config_init(struct phy_device *phydev)
mask, val);
}
+ /* LED Configuration */
+ val = phy_read(phydev, DP83867_LEDCR1);
+ for (led = 0; led < ARRAY_SIZE(dp83867->led_modes); led++) {
+ if (dp83867->led_modes[led] != -EINVAL) {
+ val &= ~(DP83867_LED_MODE_MASK << (DP83867_LED_MODE_SHIFT * led));
+ val |= (dp83867->led_modes[led] << (DP83867_LED_MODE_SHIFT * led));
+ }
+ }
+ phy_write(phydev, DP83867_LEDCR1, val);
+
return 0;
}
--
2.25.1
next prev parent reply other threads:[~2022-11-18 0:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 0:15 [PATCH 0/3] add dt configuration for dp83867 led modes Tim Harvey
2022-11-18 0:15 ` [PATCH 1/3] dt-bindings: net: phy: dp83867: add LED mode property Tim Harvey
2022-11-18 3:56 ` Rob Herring
2022-11-18 0:15 ` Tim Harvey [this message]
2022-11-18 0:15 ` [PATCH 3/3] arm64: dts: imx8m*-venice: add dp83867 PHY LED mode configuration Tim Harvey
2022-11-18 0:27 ` [PATCH 0/3] add dt configuration for dp83867 led modes Andrew Lunn
2022-11-18 0:54 ` Tim Harvey
2022-11-18 13:11 ` Andrew Lunn
2022-11-18 19:57 ` Tim Harvey
2022-11-20 23:35 ` Andrew Lunn
2022-12-01 18:26 ` Tim Harvey
2022-12-01 18:31 ` Christian Marangi
2022-12-01 18:35 ` Tim Harvey
2022-12-01 18:38 ` Christian Marangi
2022-12-01 19:40 ` Andrew Lunn
2022-12-07 10:40 ` Alexander Stein
2022-12-07 10:48 ` Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221118001548.635752-3-tharvey@gateworks.com \
--to=tharvey@gateworks.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).