From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: davem@davemloft.net, netdev@vger.kernel.org, kuba@kernel.org,
pabeni@redhat.com, edumazet@google.com
Subject: [PATCH net 0/2] Netfilter fixes for net
Date: Fri, 18 Nov 2022 15:29:16 +0100 [thread overview]
Message-ID: <20221118142918.196782-1-pablo@netfilter.org> (raw)
Hi,
The following patchset contains late Netfilter fixes for net:
1) Use READ_ONCE()/WRITE_ONCE() to update ct->mark, from Daniel Xu.
Not reported by syzbot, but I presume KASAN would trigger post
a splat on this. This is a rather old issue, predating git history.
2) Do not set up extensions for set element with end interval flag
set on. This leads to bogusly skipping this elements as expired
when listing the set/map to userspace as well as increasing
memory consumpton when stateful expressions are used. This issue
has been present since 4.18, when timeout support for rbtree set
was added.
Please, pull these changes from:
git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf.git
Thanks.
----------------------------------------------------------------
The following changes since commit 40b9d1ab63f5c4f3cb69450044d07b45e5af72e1:
ipvlan: hold lower dev to avoid possible use-after-free (2022-11-18 10:39:22 +0000)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf.git HEAD
for you to fetch changes up to 33c7aba0b4ffd6d7cdab862a034eb582a5120a38:
netfilter: nf_tables: do not set up extensions for end interval (2022-11-18 15:21:32 +0100)
----------------------------------------------------------------
Daniel Xu (1):
netfilter: conntrack: Fix data-races around ct mark
Pablo Neira Ayuso (1):
netfilter: nf_tables: do not set up extensions for end interval
net/core/flow_dissector.c | 2 +-
net/ipv4/netfilter/ipt_CLUSTERIP.c | 4 ++--
net/netfilter/nf_conntrack_core.c | 2 +-
net/netfilter/nf_conntrack_netlink.c | 24 ++++++++++++++----------
net/netfilter/nf_conntrack_standalone.c | 2 +-
net/netfilter/nf_tables_api.c | 6 ++++--
net/netfilter/nft_ct.c | 6 +++---
net/netfilter/xt_connmark.c | 18 ++++++++++--------
net/openvswitch/conntrack.c | 8 ++++----
net/sched/act_connmark.c | 4 ++--
net/sched/act_ct.c | 8 ++++----
net/sched/act_ctinfo.c | 6 +++---
12 files changed, 49 insertions(+), 41 deletions(-)
next reply other threads:[~2022-11-18 14:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 14:29 Pablo Neira Ayuso [this message]
2022-11-18 14:29 ` [PATCH net 1/2] netfilter: conntrack: Fix data-races around ct mark Pablo Neira Ayuso
2022-11-21 11:40 ` patchwork-bot+netdevbpf
2022-11-18 14:29 ` [PATCH net 2/2] netfilter: nf_tables: do not set up extensions for end interval Pablo Neira Ayuso
-- strict thread matches above, loose matches on Subject: below --
2024-01-03 11:29 [PATCH net 0/2] Netfilter fixes for net Pablo Neira Ayuso
2023-12-22 10:42 Pablo Neira Ayuso
2023-12-22 10:49 ` Pablo Neira Ayuso
2023-12-22 10:53 ` Pablo Neira Ayuso
2023-12-20 15:15 Pablo Neira Ayuso
2023-10-25 10:08 Pablo Neira Ayuso
2023-04-21 10:56 Pablo Neira Ayuso
2023-04-20 17:06 Pablo Neira Ayuso
2023-04-21 3:25 ` Jakub Kicinski
2023-01-31 13:31 Pablo Neira Ayuso
2023-01-23 21:15 Pablo Neira Ayuso
2022-10-19 6:52 Pablo Neira Ayuso
2022-07-02 19:10 Pablo Neira Ayuso
2022-05-26 20:54 Pablo Neira Ayuso
2022-04-12 9:42 Pablo Neira Ayuso
2022-04-05 10:09 Pablo Neira Ayuso
2021-06-02 12:44 Pablo Neira Ayuso
2021-02-09 21:35 Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221118142918.196782-1-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).