From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Marcin Wojtas <mw@semihalf.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
devicetree@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
Taras Chornyi <tchornyi@marvell.com>,
linux-kernel@vger.kernel.org,
Robert Marko <robert.marko@sartura.hr>,
Luka Perkov <luka.perkov@sartura.hr>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Michael Walle <michael@walle.cc>
Subject: Re: [PATCH net-next 6/6] net: mvpp2: Consider NVMEM cells as possible MAC address source
Date: Mon, 21 Nov 2022 10:29:28 +0100 [thread overview]
Message-ID: <20221121102928.7b190296@xps-13> (raw)
In-Reply-To: <CAPv3WKdZ+tsW-jRJt_n=KqT+oEe+5QAEFOWKrXsTjHCBBzEh0A@mail.gmail.com>
Hi Marcin,
mw@semihalf.com wrote on Sat, 19 Nov 2022 09:18:34 +0100:
> Hi Miquel,
>
>
> czw., 17 lis 2022 o 22:56 Miquel Raynal <miquel.raynal@bootlin.com> napisał(a):
> >
> > The ONIE standard describes the organization of tlv (type-length-value)
> > arrays commonly stored within NVMEM devices on common networking
> > hardware.
> >
> > Several drivers already make use of NVMEM cells for purposes like
> > retrieving a default MAC address provided by the manufacturer.
> >
> > What made ONIE tables unusable so far was the fact that the information
> > where "dynamically" located within the table depending on the
> > manufacturer wishes, while Linux NVMEM support only allowed statically
> > defined NVMEM cells. Fortunately, this limitation was eventually tackled
> > with the introduction of discoverable cells through the use of NVMEM
> > layouts, making it possible to extract and consistently use the content
> > of tables like ONIE's tlv arrays.
> >
> > Parsing this table at runtime in order to get various information is now
> > possible. So, because many Marvell networking switches already follow
> > this standard, let's consider using NVMEM cells as a new valid source of
> > information when looking for a base MAC address, which is one of the
> > primary uses of these new fields. Indeed, manufacturers following the
> > ONIE standard are encouraged to provide a default MAC address there, so
> > let's eventually use it if no other MAC address has been found using the
> > existing methods.
> >
> > Link: https://opencomputeproject.github.io/onie/design-spec/hw_requirements.html
>
> Thanks for the patch. Did you manage to test in on a real HW? I am curious about
Yes, I have a Replica switch on which the commercial ports use the
replica PCI IP while the config "OOB" port is running with mvpp2:
[ 16.737759] mvpp2 f2000000.ethernet eth52: Using nvmem cell mac address 18:be:92:13:9a:00
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> > drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> > index eb0fb8128096..7c8c323f4411 100644
> > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> > @@ -6104,6 +6104,12 @@ static void mvpp2_port_copy_mac_addr(struct net_device *dev, struct mvpp2 *priv,
> > }
> > }
> >
> > + if (!of_get_mac_address(to_of_node(fwnode), hw_mac_addr)) {
>
> Unfortunately, nvmem cells seem to be not supported with ACPI yet, so
> we cannot extend fwnode_get_mac_address - I think it should be,
> however, an end solution.
Agreed.
> As of now, I'd prefer to use of_get_mac_addr_nvmem directly, to avoid
> parsing the DT again (after fwnode_get_mac_address) and relying
> implicitly on falling back to nvmem stuff (currently, without any
> comment it is not obvious).
I did not do that in the first place because of_get_mac_addr_nvmem()
was not exported, but I agree it would be the cleanest (and quickest)
approach, so I'll attempt to export the function first, and then use it
directly from the driver.
> Best regards,
> Marcin
>
> > + *mac_from = "nvmem cell";
> > + eth_hw_addr_set(dev, hw_mac_addr);
> > + return;
> > + }
> > +
> > *mac_from = "random";
> > eth_hw_addr_random(dev);
> > }
> > --
> > 2.34.1
> >
Thanks a lot,
Miquèl
next prev parent reply other threads:[~2022-11-21 9:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 21:55 [PATCH 0/6] Marvell nvmem mac addresses support Miquel Raynal
2022-11-17 21:55 ` [PATCH 1/6] Revert "dt-bindings: marvell,prestera: Add description for device-tree bindings" Miquel Raynal
2022-11-23 22:02 ` Rob Herring
2022-11-17 21:55 ` [PATCH 2/6] dt-bindings: net: marvell,dfx-server: Convert to yaml Miquel Raynal
2022-11-23 22:10 ` Rob Herring
2022-11-23 23:34 ` Miquel Raynal
2022-11-17 21:55 ` [PATCH 3/6] dt-bindings: net: marvell,prestera: " Miquel Raynal
2022-11-23 22:11 ` Rob Herring
2022-11-17 21:55 ` [PATCH 4/6] dt-bindings: net: marvell,prestera: Describe PCI devices of the prestera family Miquel Raynal
2022-11-23 22:13 ` Rob Herring
2022-11-17 21:55 ` [PATCH net-next 5/6] net: marvell: prestera: Avoid unnecessary DT lookups Miquel Raynal
2022-11-17 21:55 ` [PATCH net-next 6/6] net: mvpp2: Consider NVMEM cells as possible MAC address source Miquel Raynal
2022-11-19 8:18 ` Marcin Wojtas
2022-11-21 9:29 ` Miquel Raynal [this message]
2022-11-21 14:46 ` Marcin Wojtas
2022-11-22 17:52 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221121102928.7b190296@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luka.perkov@sartura.hr \
--cc=michael@walle.cc \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
--cc=tchornyi@marvell.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).