Re: [PATCH 16/18] net: hns3: fix mixed module-builtin object

From: Alexander Lobakin <alobakin@mailbox.org>
To: Salil Mehta <salil.mehta@huawei.com>
Cc: Alexander Lobakin <alobakin@mailbox.org>,
	Alexander Lobakin <alobakin@pm.me>,
	"linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Nicolas Schier <nicolas@fjasle.eu>, Jens Axboe <axboe@kernel.dk>,
	Boris Brezillon <bbrezillon@kernel.org>,
	Borislav Petkov <bp@alien8.de>, Tony Luck <tony.luck@intel.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	"Vladimir Oltean" <vladimir.oltean@nxp.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Derek Chickles <dchickles@marvell.com>,
	Ioana Ciornei <ioana.ciornei@nxp.com>,
	Sunil Goutham <sgoutham@marvell.com>,
	Daniel Scally <djrscally@gmail.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Mark Brown <broonie@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 16/18] net: hns3: fix mixed module-builtin object
Date: Wed, 23 Nov 2022 23:07:53 +0100	[thread overview]
Message-ID: <20221123220753.65752-1-alobakin@mailbox.org> (raw)
In-Reply-To: <1d2341cc5a1843538d55fb34bd8137d8@huawei.com>

From: Salil Mehta <salil.mehta@huawei.com>
Date: Tue, 22 Nov 2022 12:39:04 +0000

> Hi Alexander,
> 
> > From: Alexander Lobakin <alobakin@pm.me>
> > Sent: Saturday, November 19, 2022 11:10 PM
> > To: linux-kbuild@vger.kernel.org

[...]

> > diff --git a/drivers/net/ethernet/hisilicon/Kconfig
> > b/drivers/net/ethernet/hisilicon/Kconfig
> > index 3312e1d93c3b..9d2be93d0378 100644
> > --- a/drivers/net/ethernet/hisilicon/Kconfig
> > +++ b/drivers/net/ethernet/hisilicon/Kconfig
> > @@ -100,11 +100,15 @@ config HNS3
> > 
> >  if HNS3
> > 
> > +config HNS3_HCLGE_COMMON
> > +	tristate
> > +
> 
> 
> This change does not looks right to me. We do not intend to expose these

...does not looks right to me -- because? The "wrong" line?

> common files via kconfig and as a separate module. I would need time to
> address this in a different way. 

I'm curious how 40 Kb of shared code can be addressed differently :D
This Kconfig opt is hidden, it can only be selected by some other
symbol -- in this case, by the PF and VF HCLGE options. Nothing gets
exposed in a way it shouldn't be.

Lemme guess, some cross-OS "shared code" in the OOT nobody in the
upstream cares about (for good), how familiar :D IIRC ZSTD folks
also weren't happy at first.

> 
> Please do not merge this change into the mainline!
> 
> 
> Thanks
> Salil
> 
> 
> 
> >  config HNS3_HCLGE
> >  	tristate "Hisilicon HNS3 HCLGE Acceleration Engine & Compatibility
> > Layer Support"
> >  	default m
> >  	depends on PCI_MSI
> >  	depends on PTP_1588_CLOCK_OPTIONAL
> > +	select HNS3_HCLGE_COMMON

[...]

> > diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
> > b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
> > index 987271da6e9b..39a7ab51be31 100644
> > --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
> > +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
> > @@ -13133,6 +13133,8 @@ static void __exit hclge_exit(void)
> >  module_init(hclge_init);
> >  module_exit(hclge_exit);
> > 
> > +MODULE_IMPORT_NS(HNS3_HCLGE_COMMON);
> 
> 
> No, we don't want this.

I can export the common functions globally, without a namespace
if you prefer ._.

> 
> 
> 
> > +
> >  MODULE_LICENSE("GPL");
> >  MODULE_AUTHOR("Huawei Tech. Co., Ltd.");
> >  MODULE_DESCRIPTION("HCLGE Driver");

Thanks,
Olek