From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 655E8C4332F for ; Wed, 23 Nov 2022 22:11:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229483AbiKWWLw (ORCPT ); Wed, 23 Nov 2022 17:11:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229499AbiKWWLd (ORCPT ); Wed, 23 Nov 2022 17:11:33 -0500 Received: from mail-il1-f176.google.com (mail-il1-f176.google.com [209.85.166.176]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF41B1001C5; Wed, 23 Nov 2022 14:10:23 -0800 (PST) Received: by mail-il1-f176.google.com with SMTP id q13so60326ild.3; Wed, 23 Nov 2022 14:10:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nCaLtE08habEVniuFmPFJHMdD+Pf/zJZeM63tCW6jHM=; b=5fI2iL6mc2nATc6lgr9V2NFiyXYwVujdZpyqjKrgFDeqbTCquV+0mgz7J7rnVhYqyc 8c6oL5XZbjpnHxHLiPePFicK2vQHw4UfRSwj5MSDitzrgybgDKZ3oIqrAhL5eZyhRUOW JAkU3a4y2A7hsuMUtHK2OxpQ7uoFkzvmsJdtTj1O8W4o/N8lDQf+d9JERI0vfsKz7ZR9 3DaoC21TR8ZMhXrOb68Yvuhbbn/OKi5LtYy5JAN7lxegBUrx+HXHvL5ebI19UqNvVt0x 8XpSIf1MYW+6E+6ZHPxIsyOw0oPhSqPwGQY7AbdBaC8LGyeFZtBIcs2ivjZ2B7yW+RMv ZBpA== X-Gm-Message-State: ANoB5pnCYbAwP6aaZTCRLfNx4CDxZA5eFVBDoovK6WqMLDqVZDxH24Iv FFE0oOuulU2DxeM5iqLs3rlZvB/QeQ== X-Google-Smtp-Source: AA0mqf55gvn9mSnbj2YpBRikSZvZRRF+3G0E2+9mjPlS85JPCMjYBesXvKVZkN2rR6sPv5vzWUHxhw== X-Received: by 2002:a05:6e02:1d8c:b0:300:da4a:f8f6 with SMTP id h12-20020a056e021d8c00b00300da4af8f6mr5113975ila.99.1669241422955; Wed, 23 Nov 2022 14:10:22 -0800 (PST) Received: from robh_at_kernel.org ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id y18-20020a92d212000000b002ffbf49a0d2sm6094613ily.84.2022.11.23.14.10.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Nov 2022 14:10:22 -0800 (PST) Received: (nullmailer pid 2594310 invoked by uid 1000); Wed, 23 Nov 2022 22:10:23 -0000 Date: Wed, 23 Nov 2022 16:10:23 -0600 From: Rob Herring To: Miquel Raynal Cc: Krzysztof Kozlowski , devicetree@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , netdev@vger.kernel.org, Marcin Wojtas , Russell King , Taras Chornyi , linux-kernel@vger.kernel.org, Robert Marko , Luka Perkov , Thomas Petazzoni , Michael Walle Subject: Re: [PATCH 2/6] dt-bindings: net: marvell,dfx-server: Convert to yaml Message-ID: <20221123221023.GA2582938-robh@kernel.org> References: <20221117215557.1277033-1-miquel.raynal@bootlin.com> <20221117215557.1277033-3-miquel.raynal@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221117215557.1277033-3-miquel.raynal@bootlin.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Nov 17, 2022 at 10:55:53PM +0100, Miquel Raynal wrote: > Even though this description is not used anywhere upstream (no matching > driver), while on this file I decided I would try a conversion to yaml > in order to clarify the prestera family description. > > I cannot keep the nodename dfx-server@xxxx so I switched to dfx-bus@xxxx > which matches simple-bus.yaml. Otherwise I took the example context from > the only user of this compatible: armada-xp-98dx3236.dtsi, which is a > rather old and not perfect DT. > > Signed-off-by: Miquel Raynal > --- > I am fine dropping this file entirely as well, if judged useless. > --- > .../bindings/net/marvell,dfx-server.yaml | 60 +++++++++++++++++++ > .../bindings/net/marvell,prestera.txt | 18 ------ > 2 files changed, 60 insertions(+), 18 deletions(-) > create mode 100644 Documentation/devicetree/bindings/net/marvell,dfx-server.yaml > > diff --git a/Documentation/devicetree/bindings/net/marvell,dfx-server.yaml b/Documentation/devicetree/bindings/net/marvell,dfx-server.yaml > new file mode 100644 > index 000000000000..72151a78396f > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/marvell,dfx-server.yaml > @@ -0,0 +1,60 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/marvell,dfx-server.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Marvell Prestera DFX server > + > +maintainers: > + - Miquel Raynal > + > +select: > + properties: > + compatible: > + contains: > + const: marvell,dfx-server > + required: > + - compatible > + > +properties: > + compatible: > + items: > + - const: marvell,dfx-server > + - const: simple-bus > + > + reg: true How many entries? > + > + ranges: true > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 1 > + > +required: > + - compatible > + - reg > + - ranges > + > +# The DFX server may expose clocks described as subnodes > +additionalProperties: true addtionalProperties: type: object So that only nodes can be added. > + > +examples: > + - | > + > + #define MBUS_ID(target,attributes) (((target) << 24) | ((attributes) << 16)) > + bus@0 { > + reg = <0 0>; > + #address-cells = <2>; > + #size-cells = <1>; > + > + dfx-bus@ac000000 { > + compatible = "marvell,dfx-server", "simple-bus"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0 MBUS_ID(0x08, 0x00) 0 0x100000>; > + reg = ; > + }; > + };