From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E283DC47089 for ; Mon, 28 Nov 2022 22:27:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233027AbiK1W11 (ORCPT ); Mon, 28 Nov 2022 17:27:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232208AbiK1W10 (ORCPT ); Mon, 28 Nov 2022 17:27:26 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3D2E15A0C; Mon, 28 Nov 2022 14:27:25 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6EE38614B7; Mon, 28 Nov 2022 22:27:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F48AC433D6; Mon, 28 Nov 2022 22:27:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669674444; bh=o0QWT6JRyZz+eRLb3by8TcPDUkxT+t34KBC3YTAhv7s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CxitdZe/7wyGvPDGF88gk2ZSafJBtM/u6GU7D3zXGHglZjJIA3Cyr+dic3mes7HhE yUq0Do01KEjd0Z0yYnT+nnjzUJhpX3/xvUAvuyhUoBGjy5fsyRu2QiiARXUD77gQog nkK46rpy5U/ATqFvOXuiI2lAV+JL5G90kxLFuCC7putollLw9OhUUyo3Ex2hSORroL ZEBS6B78ued1TZE51/ldk14Nyf0dpQt8hvA4MPThsbnbxKLQSmXF8phLmMZeXclYAv SgoKSegm/3soTV56khvUmZGsUHDJSjJ41InvC4PVVzPtgCHzRUy/YwVVKc3N5O0Xnr mScgrBWmKBCnw== Date: Mon, 28 Nov 2022 14:27:23 -0800 From: Jakub Kicinski To: Vincent MAILHOL Cc: Andrew Lunn , linux-can@vger.kernel.org, Marc Kleine-Budde , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , netdev@vger.kernel.org, linux-usb@vger.kernel.org, Saeed Mahameed , Jiri Pirko , Lukas Magel Subject: Re: [PATCH v4 3/6] can: etas_es58x: export product information through devlink_ops::info_get() Message-ID: <20221128142723.2f826d20@kernel.org> In-Reply-To: References: <20221104073659.414147-1-mailhol.vincent@wanadoo.fr> <20221126162211.93322-1-mailhol.vincent@wanadoo.fr> <20221126162211.93322-4-mailhol.vincent@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 28 Nov 2022 23:43:19 +0900 Vincent MAILHOL wrote: > On Mon. 28 Nov. 2022 at 22:49, Andrew Lunn wrote: > > > devlink does not yet have a name suited for the bootloader and so this > > > last piece of information is exposed to the userland for through a > > > custom name: "bl". > > > > Jiri, what do you think about 'bl'? Is it too short, not well known > > enough? It could easily be 'bootloader'. > > For the record, I name it "bl" by analogy with the firmware which is > named "fw". My personal preference would have been to name the fields > without any abbreviations: "firmware", "bootloader" and > "hardware.revision" (for reference ethtool -i uses > "firmware-version"). But I tried to put my personal taste aside and > try to fit with the devlink trends to abbreviate things. Thus the name > "bl". Agreed, I thought "fw" is sufficiently universally understood to be used but "bl" is most definitely not :S I'd suggest "fw.bootloader". Also don't hesitate to add that to the "well known" list in devlink.h, I reckon it will be used by others sooner or later.