From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Jiri Slaby <jirislaby@kernel.org>,
Joanne Koong <joannelkoong@gmail.com>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Kuniyuki Iwashima <kuni1840@gmail.com>, <netdev@vger.kernel.org>
Subject: [PATCH RFC net 0/2] tcp: Fix bhash2 and TIME_WAIT regression.
Date: Thu, 22 Dec 2022 00:12:56 +0900 [thread overview]
Message-ID: <20221221151258.25748-1-kuniyu@amazon.com> (raw)
We forgot to add TIME_WAIT sockets to bhash2. Therefore twsk cannot
prevent bind() to the same local address and port.
The first patch fixes the issue, but the layout change in struct
sock could have a negative impact. So, this series is RFC.
Kuniyuki Iwashima (2):
tcp: Add TIME_WAIT sockets in bhash2.
tcp: Add selftest for bind() and TIME_WAIT.
include/net/inet_timewait_sock.h | 2 +
include/net/sock.h | 5 +-
net/ipv4/inet_hashtables.c | 5 +-
net/ipv4/inet_timewait_sock.c | 31 ++++++-
tools/testing/selftests/net/.gitignore | 1 +
tools/testing/selftests/net/bind_timewait.c | 93 +++++++++++++++++++++
6 files changed, 131 insertions(+), 6 deletions(-)
create mode 100644 tools/testing/selftests/net/bind_timewait.c
--
2.30.2
next reply other threads:[~2022-12-21 15:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 15:12 Kuniyuki Iwashima [this message]
2022-12-21 15:12 ` [PATCH RFC net 1/2] tcp: Add TIME_WAIT sockets in bhash2 Kuniyuki Iwashima
2022-12-21 16:37 ` Jiri Slaby
2022-12-22 15:05 ` Paolo Abeni
2022-12-22 21:46 ` Joanne Koong
2022-12-22 23:26 ` Kuniyuki Iwashima
2022-12-23 0:25 ` Joanne Koong
2022-12-23 1:55 ` Kuniyuki Iwashima
2022-12-23 19:34 ` Joanne Koong
2022-12-26 13:21 ` Kuniyuki Iwashima
2022-12-23 10:15 ` Paolo Abeni
2022-12-23 17:08 ` Kuniyuki Iwashima
2022-12-21 15:12 ` [PATCH RFC net 2/2] tcp: Add selftest for bind() and TIME_WAIT Kuniyuki Iwashima
2022-12-22 21:41 ` Joanne Koong
2022-12-22 23:54 ` Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221221151258.25748-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jirislaby@kernel.org \
--cc=joannelkoong@gmail.com \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).