From: Michael Walle <michael@walle.cc>
To: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jose Abreu <Jose.Abreu@synopsys.com>,
Sergey Shtylyov <s.shtylyov@omp.ru>, Wei Fang <wei.fang@nxp.com>,
Shenwei Wang <shenwei.wang@nxp.com>,
Clark Wang <xiaoning.wang@nxp.com>,
NXP Linux Team <linux-imx@nxp.com>,
Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>,
DENG Qingfang <dqfext@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, Andrew Lunn <andrew@lunn.ch>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Michael Walle <michael@walle.cc>,
Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: [PATCH net-next v3 04/11] net: mdio: C22 is now optional, EOPNOTSUPP if not provided
Date: Mon, 09 Jan 2023 16:30:44 +0100 [thread overview]
Message-ID: <20221227-v6-2-rc1-c45-seperation-v3-4-ade1deb438da@walle.cc> (raw)
In-Reply-To: <20221227-v6-2-rc1-c45-seperation-v3-0-ade1deb438da@walle.cc>
From: Andrew Lunn <andrew@lunn.ch>
When performing a C22 operation, check that the bus driver actually
provides the methods, and return -EOPNOTSUPP if not. C45 only busses
do exist, and in future their C22 methods will be NULL.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Michael Walle <michael@walle.cc>
---
drivers/net/phy/mdio_bus.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index c992a9fd8b01..f71ba6ab85a7 100644
--- a/drivers/net/phy/mdio_bus.c
+++ b/drivers/net/phy/mdio_bus.c
@@ -766,7 +766,10 @@ int __mdiobus_read(struct mii_bus *bus, int addr, u32 regnum)
lockdep_assert_held_once(&bus->mdio_lock);
- retval = bus->read(bus, addr, regnum);
+ if (bus->read)
+ retval = bus->read(bus, addr, regnum);
+ else
+ retval = -EOPNOTSUPP;
trace_mdio_access(bus, 1, addr, regnum, retval, retval);
mdiobus_stats_acct(&bus->stats[addr], true, retval);
@@ -792,7 +795,10 @@ int __mdiobus_write(struct mii_bus *bus, int addr, u32 regnum, u16 val)
lockdep_assert_held_once(&bus->mdio_lock);
- err = bus->write(bus, addr, regnum, val);
+ if (bus->write)
+ err = bus->write(bus, addr, regnum, val);
+ else
+ err = -EOPNOTSUPP;
trace_mdio_access(bus, 0, addr, regnum, val, err);
mdiobus_stats_acct(&bus->stats[addr], false, err);
--
2.30.2
next prev parent reply other threads:[~2023-01-09 15:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 15:30 [PATCH net-next v3 00/11] net: mdio: Start separating C22 and C45 Michael Walle
2023-01-09 15:30 ` [PATCH net-next v3 01/11] net: mdio: Add dedicated C45 API to MDIO bus drivers Michael Walle
2023-01-10 11:16 ` Paolo Abeni
2023-01-10 12:49 ` Paolo Abeni
2023-01-10 23:59 ` Jakub Kicinski
2023-01-09 15:30 ` [PATCH net-next v3 02/11] net: pcs: pcs-xpcs: Use C45 MDIO API Michael Walle
2023-01-09 23:48 ` Florian Fainelli
2023-01-09 15:30 ` [PATCH net-next v3 03/11] net: mdio: mdiobus_register: update validation test Michael Walle
2023-01-09 15:30 ` Michael Walle [this message]
2023-01-09 15:30 ` [PATCH net-next v3 05/11] net: mdio: Move mdiobus_c45_addr() next to users Michael Walle
2023-01-09 15:30 ` [PATCH net-next v3 06/11] net: mdio: mdio-bitbang: Separate C22 and C45 transactions Michael Walle
2023-01-09 15:30 ` [PATCH net-next v3 07/11] net: mdio: mvmdio: Convert XSMI bus to new API Michael Walle
2023-01-09 15:30 ` [PATCH net-next v3 08/11] net: mdio: xgmac_mdio: Separate C22 and C45 transactions Michael Walle
2023-01-09 15:30 ` [PATCH net-next v3 09/11] net: fec: " Michael Walle
2023-01-09 15:30 ` [PATCH net-next v3 10/11] net: mdio: add mdiobus_c45_read/write_nested helpers Michael Walle
2023-01-09 15:30 ` [PATCH net-next v3 11/11] net: dsa: mv88e6xxx: Separate C22 and C45 transactions Michael Walle
2023-01-11 0:10 ` [PATCH net-next v3 00/11] net: mdio: Start separating C22 and C45 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221227-v6-2-rc1-c45-seperation-v3-4-ade1deb438da@walle.cc \
--to=michael@walle.cc \
--cc=Jose.Abreu@synopsys.com \
--cc=Landen.Chao@mediatek.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=geert+renesas@glider.be \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=s.shtylyov@omp.ru \
--cc=sean.wang@mediatek.com \
--cc=shenwei.wang@nxp.com \
--cc=vladimir.oltean@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).