From: Jakub Kicinski <kuba@kernel.org>
To: Mateusz Palczewski <mateusz.palczewski@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
leon@kernel.org
Subject: Re: [PATCH net v2] ice: Fix deadlock on the rtnl_mutex
Date: Thu, 5 Jan 2023 10:45:17 -0800 [thread overview]
Message-ID: <20230105104517.79cd83ed@kernel.org> (raw)
In-Reply-To: <20230105120518.29776-1-mateusz.palczewski@intel.com>
On Thu, 5 Jan 2023 07:05:18 -0500 Mateusz Palczewski wrote:
> ret = ice_vsi_alloc_q_vectors(vsi);
> - if (ret)
> - goto err_rings;
> + if (ret){
> + ice_vsi_clear_rings(vsi);
> + goto err_reset;
> + }
>
> ret = ice_vsi_setup_vector_base(vsi);
> if (ret)
Why do cases which jump to err_vectors no need any changes?
next prev parent reply other threads:[~2023-01-05 18:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 12:05 [PATCH net v2] ice: Fix deadlock on the rtnl_mutex Mateusz Palczewski
2023-01-05 13:18 ` Leon Romanovsky
2023-01-05 18:45 ` Jakub Kicinski [this message]
2023-01-12 13:31 ` Palczewski, Mateusz
2023-01-12 19:14 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230105104517.79cd83ed@kernel.org \
--to=kuba@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=leon@kernel.org \
--cc=mateusz.palczewski@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).