From: Vladimir Oltean <olteanv@gmail.com>
To: Sean Anderson <sean.anderson@seco.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
netdev@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Tim Harvey <tharvey@gateworks.com>
Subject: Re: [PATCH net-next v5 4/4] phy: aquantia: Determine rate adaptation support from registers
Date: Thu, 5 Jan 2023 19:55:42 +0200 [thread overview]
Message-ID: <20230105175542.ozqn67o3qmadnaph@skbuf> (raw)
In-Reply-To: <20230105175206.h3nmvccnzml2xa5d@skbuf>
On Thu, Jan 05, 2023 at 07:52:06PM +0200, Vladimir Oltean wrote:
> On Thu, Jan 05, 2023 at 12:43:47PM -0500, Sean Anderson wrote:
> > Again, this is to comply with the existing API assumptions. The current
> > code is buggy. Of course, another way around this is to modify the API.
> > I have chosen this route because I don't have a situation like you
> > described. But if support for that is important to you, I encourage you
> > to refactor things.
>
> I don't think I'm aware of a practical situation like that either.
> I remember seeing some S32G boards with Aquantia PHYs which use 2500BASE-X
> for 2.5G and SGMII for <=1G, but that's about it in terms of protocol switching.
> As for Layerscape boards, SERDES protocol switching is a very new concept there,
> so they're all going to be provisioned for PAUSE all the way down
> (or USXGMII, where that is available).
>
> I just pointed this out because it jumped out to me. I don't have
> something against this patch getting accepted as it is.
A real-life (albeit niche) scenario where someone might have an Aquantia
firmware provisioned like this would be a 10G capable port that also
wants to support half duplex at 10/100 speeds. Although I'm not quite
sure who cares about half duplex all that much these days.
next prev parent reply other threads:[~2023-01-05 17:55 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 22:05 [PATCH net-next v5 0/4] phy: aquantia: Determine rate adaptation support from registers Sean Anderson
2023-01-03 22:05 ` [PATCH net-next v5 1/4] net: phy: Move/rename phylink_interface_max_speed Sean Anderson
2023-01-03 22:05 ` [PATCH net-next v5 2/4] phy: mdio: Reorganize defines Sean Anderson
2023-01-03 22:05 ` [PATCH net-next v5 3/4] net: mdio: Update speed register bits Sean Anderson
2023-01-03 22:05 ` [PATCH net-next v5 4/4] phy: aquantia: Determine rate adaptation support from registers Sean Anderson
2023-01-05 14:04 ` Vladimir Oltean
2023-01-05 14:40 ` Russell King (Oracle)
2023-01-05 17:43 ` Vladimir Oltean
2023-01-05 18:51 ` Russell King (Oracle)
2023-01-06 14:18 ` Vladimir Oltean
2023-01-05 16:21 ` Sean Anderson
2023-01-05 17:34 ` Vladimir Oltean
2023-01-05 17:43 ` Sean Anderson
2023-01-05 17:52 ` Vladimir Oltean
2023-01-05 17:55 ` Vladimir Oltean [this message]
2023-01-05 18:03 ` Sean Anderson
2023-01-05 18:11 ` Vladimir Oltean
2023-01-05 18:17 ` Sean Anderson
2023-01-05 18:58 ` Russell King (Oracle)
2023-01-05 19:00 ` Sean Anderson
2023-01-05 18:55 ` Russell King (Oracle)
2023-01-05 18:59 ` Sean Anderson
2023-01-05 19:06 ` Russell King (Oracle)
2023-01-05 19:10 ` Sean Anderson
2023-01-05 17:46 ` Russell King (Oracle)
2023-01-06 23:03 ` Vladimir Oltean
2023-01-06 23:21 ` Sean Anderson
2023-01-06 23:29 ` Vladimir Oltean
2023-01-19 18:32 ` Sean Anderson
2023-01-09 18:56 ` Tim Harvey
2023-01-05 13:39 ` [PATCH net-next v5 0/4] " Vladimir Oltean
2023-01-05 16:25 ` Sean Anderson
2023-01-19 18:17 ` Sean Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230105175542.ozqn67o3qmadnaph@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sean.anderson@seco.com \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).