From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA482C3DA7A for ; Fri, 6 Jan 2023 17:59:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232086AbjAFR7Q (ORCPT ); Fri, 6 Jan 2023 12:59:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231450AbjAFR6u (ORCPT ); Fri, 6 Jan 2023 12:58:50 -0500 Received: from smtp-fw-6002.amazon.com (smtp-fw-6002.amazon.com [52.95.49.90]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEA277D9FE; Fri, 6 Jan 2023 09:58:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1673027929; x=1704563929; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=v0c5rS0g/FP0JyphM1OQziPGtUPHcAvofBABcEmtwE4=; b=AdE1c8QjeXq8igaxbbsmupelOOVfZn1yKZRkgXp3HwYHJ+UPMwYpF3dv wMl1IDZi2hIfv9UlhNxjvJa650tPMhaM0O4HBA1qBVqz4UKjpiA9F1p+x 7HJIFJicvC/FqsiAjORuOqxjU2kZeVP9w0omjDoh3J4bCs5kFwLtuxYY4 4=; X-IronPort-AV: E=Sophos;i="5.96,306,1665446400"; d="scan'208";a="284118343" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-pdx-2b-m6i4x-0ec33b60.us-west-2.amazon.com) ([10.43.8.6]) by smtp-border-fw-6002.iad6.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2023 17:58:45 +0000 Received: from EX13MTAUWB001.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-pdx-2b-m6i4x-0ec33b60.us-west-2.amazon.com (Postfix) with ESMTPS id 1109AA2DC8; Fri, 6 Jan 2023 17:58:41 +0000 (UTC) Received: from EX19D004ANA001.ant.amazon.com (10.37.240.138) by EX13MTAUWB001.ant.amazon.com (10.43.161.249) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 6 Jan 2023 17:58:41 +0000 Received: from 88665a182662.ant.amazon.com (10.43.160.83) by EX19D004ANA001.ant.amazon.com (10.37.240.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1118.7; Fri, 6 Jan 2023 17:58:36 +0000 From: Kuniyuki Iwashima To: CC: , , , , , , , , , , Subject: [PATCH selftest/net/af_unix 1/1] Fix size of parameter to connect() Date: Sat, 7 Jan 2023 02:58:28 +0900 Message-ID: <20230106175828.13333-1-kuniyu@amazon.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.43.160.83] X-ClientProxiedBy: EX13D41UWB004.ant.amazon.com (10.43.161.135) To EX19D004ANA001.ant.amazon.com (10.37.240.138) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, Thanks for the patch. From: Mirsad Goran Todorovac Date: Fri, 6 Jan 2023 18:18:58 +0100 > From: Mirsad Goran Todorovac > > Adjust size parameter in connect() to match the type of the parameter, to fix "No such file or directory" > error in selftests/net/af_unix/test_oob_unix.c:127. Could you wrap the changelog to 75 chars except for log (strace below) ? checkpatch.pl will help. $ git show HEAD --format=email | ./scripts/checkpatch.pl > > The existing code happens to work provided that the autogenerated pathname is shorter than > sizeof (struct sockaddr), which is why it hasn't been noticed earlier. > > Visible from the trace excerpt: > > bind(3, {sa_family=AF_UNIX, sun_path="unix_oob_453059"}, 110) = 0 > clone(child_stack=NULL, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0x7fa6a6577a10) = 453060 > [pid ] connect(6, {sa_family=AF_UNIX, sun_path="unix_oob_45305"}, 16) = -1 ENOENT (No such file or directory) > > BUG: The filename is trimmed to sizeof (struct sockaddr). > > The patch is generated against the "vanilla" torvalds mainline tree 6.2-rc2. Every patch that fixes networking code has to be applied cleanly on net.git. https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/ But the patch can not be applied to net.git. Could you check this ? https://patchwork.kernel.org/project/netdevbpf/patch/bd7ff00a-6892-fd56-b3ca-4b3feb6121d8@alu.unizg.hr/ Also, the mail title should be [PATCH Tree Version Nth/Total] subsystem: Description. Next time, Tree is net and Version is v2, and we need not write 1/1, so the subject should be [PATCH net v2] af_unix: selftest: Fix size of parameter to connect() Please see here for details. https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/Documentation/process/maintainer-netdev.rst > > Thanks and regards, > Mirsad Todorovac You can remove these lines. > > Reported-by: Mirsad Goran Todorovac In this case, you are the reporter and the author of the patch, so the Reported-by tag is not needed. Instead, you have to add your SOB tag. Signed-off-by: Mirsad Goran Todorovac > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Jakub Kicinski > Cc: Paolo Abeni > Cc: Shuah Khan > Cc: Kuniyuki Iwashima > Cc: Florian Westphal > Reviewed-by: Florian Westphal Please add Fixes tag as I said here. https://lore.kernel.org/netdev/20230103111335.81600-1-kuniyu@amazon.com/#r Thank you, Kuniyuki > > --- > tools/testing/selftests/net/af_unix/test_unix_oob.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/net/af_unix/test_unix_oob.c b/tools/testing/selftests/net/af_unix/test_unix_oob.c > index b57e91e1c3f2..532459a15067 100644 > --- a/tools/testing/selftests/net/af_unix/test_unix_oob.c > +++ b/tools/testing/selftests/net/af_unix/test_unix_oob.c > @@ -124,7 +124,7 @@ void producer(struct sockaddr_un *consumer_addr) > > wait_for_signal(pipefd[0]); > if (connect(cfd, (struct sockaddr *)consumer_addr, > - sizeof(struct sockaddr)) != 0) { > + sizeof(*consumer_addr)) != 0) { > perror("Connect failed"); > kill(0, SIGTERM); > exit(1); > > -- > Mirsad Goran Todorovac > Sistem inženjer > Grafički fakultet | Akademija likovnih umjetnosti > Sveučilište u Zagrebu > -- > System engineer > Faculty of Graphic Arts | Academy of Fine Arts > University of Zagreb, Republic of Croatia > The European Union