From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90C6DC54EBE for ; Tue, 10 Jan 2023 16:27:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238486AbjAJQ1D (ORCPT ); Tue, 10 Jan 2023 11:27:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232398AbjAJQ1A (ORCPT ); Tue, 10 Jan 2023 11:27:00 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 355D25C905; Tue, 10 Jan 2023 08:26:59 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B5744617C4; Tue, 10 Jan 2023 16:26:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13CABC433D2; Tue, 10 Jan 2023 16:26:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673368018; bh=CLkIfKCBJGzrLhUvCCv53iT5Az+fHj0DGXpmxcqAwJg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mjXm4ZGhG5bqzO5BpNQEbC5zF0VgMDUVM3qtqslcZlHrUukJKkQSLyUBmmRpu/q7w nWFuhf3BSlhCgCj1pqf2B2TbIqt51spOJdcLOzl27ly5zv5ho+FgYw2t5np5kzG14x fQ7MEe0u/aMXkzxmT3MZAnyWi9SOXUHZTBNN/zz8rEP73pqAcrm+eye7W660Uppr1Q Va5j5VYQ7VQEHxIeA1auLj7vw13bqtWcEhWPNwAxkXyzBuHY6Gl0OcYi1yd9ycNDoG 6QgK9U/KEYIT+ALwqVN3u1QgJCBjI7N3/kLii68jFWII//0OQx38T0ZuJi3R8fUGDs 1DjyWhZBcpG2Q== Date: Tue, 10 Jan 2023 10:26:54 -0600 From: Bjorn Andersson To: Bartosz Golaszewski Cc: Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Georgi Djakov , Will Deacon , Robin Murphy , Joerg Roedel , Manivannan Sadhasivam , Jassi Brar , Linus Walleij , Catalin Marinas , Richard Cochran , Srinivas Kandagatla , Vinod Koul , Alex Elder , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, Yadu MG , Prasad Sodagudi , Bartosz Golaszewski Subject: Re: [PATCH 10/18] pinctrl: qcom: sa8775p: add the pinctrl driver for the sa8775p platform Message-ID: <20230110162654.sm7yzyzfucbmuyhx@builder.lan> References: <20230109174511.1740856-1-brgl@bgdev.pl> <20230109174511.1740856-11-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230109174511.1740856-11-brgl@bgdev.pl> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jan 09, 2023 at 06:45:03PM +0100, Bartosz Golaszewski wrote: [..] > +enum sa8775p_functions { > + msm_mux_gpio, > + msm_mux_atest_char, > + msm_mux_atest_char0, > + msm_mux_atest_char1, > + msm_mux_atest_char2, > + msm_mux_atest_char3, > + msm_mux_atest_usb2, > + msm_mux_atest_usb20, > + msm_mux_atest_usb21, > + msm_mux_atest_usb22, > + msm_mux_atest_usb23, Please squash these to a single msm_mux_atest. > + msm_mux_audio_ref, > + msm_mux_cam_mclk, > + msm_mux_cci_async, > + msm_mux_cci_i2c, > + msm_mux_cci_timer0, > + msm_mux_cci_timer1, > + msm_mux_cci_timer2, > + msm_mux_cci_timer3, > + msm_mux_cci_timer4, > + msm_mux_cci_timer5, > + msm_mux_cci_timer6, > + msm_mux_cci_timer7, > + msm_mux_cci_timer8, > + msm_mux_cci_timer9, > + msm_mux_cri_trng, > + msm_mux_cri_trng0, > + msm_mux_cri_trng1, > + msm_mux_dbg_out, > + msm_mux_ddr_bist, > + msm_mux_ddr_pxi0, > + msm_mux_ddr_pxi1, > + msm_mux_ddr_pxi2, > + msm_mux_ddr_pxi3, > + msm_mux_ddr_pxi4, > + msm_mux_ddr_pxi5, > + msm_mux_edp0_hot, > + msm_mux_edp0_lcd, > + msm_mux_edp1_hot, > + msm_mux_edp1_lcd, > + msm_mux_edp2_hot, > + msm_mux_edp2_lcd, > + msm_mux_edp3_hot, > + msm_mux_edp3_lcd, > + msm_mux_emac0_mcg0, > + msm_mux_emac0_mcg1, > + msm_mux_emac0_mcg2, > + msm_mux_emac0_mcg3, > + msm_mux_emac0_mdc, > + msm_mux_emac0_mdio, > + msm_mux_emac0_ptp, msm_mux_emac0 > + msm_mux_emac1_mcg0, > + msm_mux_emac1_mcg1, > + msm_mux_emac1_mcg2, > + msm_mux_emac1_mcg3, > + msm_mux_emac1_mdc, > + msm_mux_emac1_mdio, > + msm_mux_emac1_ptp, msm_mux_emac1 > + msm_mux_gcc_gp1, > + msm_mux_gcc_gp2, > + msm_mux_gcc_gp3, > + msm_mux_gcc_gp4, > + msm_mux_gcc_gp5, > + msm_mux_hs0_mi2s, > + msm_mux_hs1_mi2s, > + msm_mux_hs2_mi2s, > + msm_mux_ibi_i3c, > + msm_mux_jitter_bist, > + msm_mux_mdp0_vsync0, > + msm_mux_mdp0_vsync1, > + msm_mux_mdp0_vsync2, > + msm_mux_mdp0_vsync3, > + msm_mux_mdp0_vsync4, > + msm_mux_mdp0_vsync5, > + msm_mux_mdp0_vsync6, > + msm_mux_mdp0_vsync7, > + msm_mux_mdp0_vsync8, > + msm_mux_mdp1_vsync0, > + msm_mux_mdp1_vsync1, > + msm_mux_mdp1_vsync2, > + msm_mux_mdp1_vsync3, > + msm_mux_mdp1_vsync4, > + msm_mux_mdp1_vsync5, > + msm_mux_mdp1_vsync6, > + msm_mux_mdp1_vsync7, > + msm_mux_mdp1_vsync8, > + msm_mux_mdp_vsync, > + msm_mux_mi2s1_data0, > + msm_mux_mi2s1_data1, > + msm_mux_mi2s1_sck, > + msm_mux_mi2s1_ws, > + msm_mux_mi2s2_data0, > + msm_mux_mi2s2_data1, > + msm_mux_mi2s2_sck, > + msm_mux_mi2s2_ws, > + msm_mux_mi2s_mclk0, > + msm_mux_mi2s_mclk1, > + msm_mux_pcie0_clkreq, > + msm_mux_pcie1_clkreq, > + msm_mux_phase_flag0, > + msm_mux_phase_flag1, > + msm_mux_phase_flag10, > + msm_mux_phase_flag11, > + msm_mux_phase_flag12, > + msm_mux_phase_flag13, > + msm_mux_phase_flag14, > + msm_mux_phase_flag15, > + msm_mux_phase_flag16, > + msm_mux_phase_flag17, > + msm_mux_phase_flag18, > + msm_mux_phase_flag19, > + msm_mux_phase_flag2, > + msm_mux_phase_flag20, > + msm_mux_phase_flag21, > + msm_mux_phase_flag22, > + msm_mux_phase_flag23, > + msm_mux_phase_flag24, > + msm_mux_phase_flag25, > + msm_mux_phase_flag26, > + msm_mux_phase_flag27, > + msm_mux_phase_flag28, > + msm_mux_phase_flag29, > + msm_mux_phase_flag3, > + msm_mux_phase_flag30, > + msm_mux_phase_flag31, > + msm_mux_phase_flag4, > + msm_mux_phase_flag5, > + msm_mux_phase_flag6, > + msm_mux_phase_flag7, > + msm_mux_phase_flag8, > + msm_mux_phase_flag9, msm_mux_phase_flag > + msm_mux_pll_bist, > + msm_mux_pll_clk, > + msm_mux_prng_rosc0, > + msm_mux_prng_rosc1, > + msm_mux_prng_rosc2, > + msm_mux_prng_rosc3, > + msm_mux_qdss_cti, > + msm_mux_qdss_gpio, > + msm_mux_qdss_gpio0, > + msm_mux_qdss_gpio1, > + msm_mux_qdss_gpio10, > + msm_mux_qdss_gpio11, > + msm_mux_qdss_gpio12, > + msm_mux_qdss_gpio13, > + msm_mux_qdss_gpio14, > + msm_mux_qdss_gpio15, > + msm_mux_qdss_gpio2, > + msm_mux_qdss_gpio3, > + msm_mux_qdss_gpio4, > + msm_mux_qdss_gpio5, > + msm_mux_qdss_gpio6, > + msm_mux_qdss_gpio7, > + msm_mux_qdss_gpio8, > + msm_mux_qdss_gpio9, msm_mux_qdss > + msm_mux_qup0_se0, > + msm_mux_qup0_se1, > + msm_mux_qup0_se2, > + msm_mux_qup0_se3, > + msm_mux_qup0_se4, > + msm_mux_qup0_se5, > + msm_mux_qup1_se0, > + msm_mux_qup1_se1, > + msm_mux_qup1_se2, > + msm_mux_qup1_se3, > + msm_mux_qup1_se4, > + msm_mux_qup1_se5, > + msm_mux_qup1_se6, > + msm_mux_qup2_se0, > + msm_mux_qup2_se1, > + msm_mux_qup2_se2, > + msm_mux_qup2_se3, > + msm_mux_qup2_se4, > + msm_mux_qup2_se5, > + msm_mux_qup2_se6, > + msm_mux_qup3_se0, > + msm_mux_sail_top, > + msm_mux_sailss_emac0, > + msm_mux_sailss_ospi, > + msm_mux_sgmii_phy, > + msm_mux_tb_trig, > + msm_mux_tgu_ch0, > + msm_mux_tgu_ch1, > + msm_mux_tgu_ch2, > + msm_mux_tgu_ch3, > + msm_mux_tgu_ch4, > + msm_mux_tgu_ch5, > + msm_mux_tsense_pwm1, > + msm_mux_tsense_pwm2, > + msm_mux_tsense_pwm3, > + msm_mux_tsense_pwm4, > + msm_mux_usb2phy_ac, > + msm_mux_vsense_trigger, > + msm_mux__, > +}; > + [..] > +static const struct msm_pingroup sa8775p_groups[] = { > + [0] = PINGROUP(0, _, _, _, _, _, _, _, _, _), > + [1] = PINGROUP(1, pcie0_clkreq, _, _, _, _, _, _, _, _), > + [2] = PINGROUP(2, _, _, _, _, _, _, _, _, _), > + [3] = PINGROUP(3, pcie1_clkreq, _, _, _, _, _, _, _, _), > + [4] = PINGROUP(4, _, _, _, _, _, _, _, _, _), > + [5] = PINGROUP(5, _, _, _, _, _, _, _, _, _), > + [6] = PINGROUP(6, emac0_ptp, emac0_ptp, emac1_ptp, emac1_ptp, _, _, _, _, _), How is it possible to select the first or the second one of these functions when they are named the same? > + [7] = PINGROUP(7, sgmii_phy, _, _, _, _, _, _, _, _), > + [8] = PINGROUP(8, emac0_mdc, _, _, _, _, _, _, _, _), > + [9] = PINGROUP(9, emac0_mdio, _, _, _, _, _, _, _, _), > + [10] = PINGROUP(10, usb2phy_ac, emac0_ptp, emac0_ptp, emac1_ptp, emac1_ptp, _, _, _, _), > + [11] = PINGROUP(11, usb2phy_ac, emac0_ptp, emac0_ptp, emac1_ptp, emac1_ptp, _, _, _, _), > + [12] = PINGROUP(12, usb2phy_ac, emac0_ptp, emac0_ptp, emac1_ptp, emac1_ptp, > + emac0_mcg0, _, _, _), > + [13] = PINGROUP(13, qup3_se0, emac0_mcg1, _, _, sail_top, _, _, _, _), > + [14] = PINGROUP(14, qup3_se0, emac0_mcg2, _, _, sail_top, _, _, _, _), > + [15] = PINGROUP(15, qup3_se0, emac0_mcg3, _, _, sail_top, _, _, _, _), > + [16] = PINGROUP(16, qup3_se0, emac1_mcg0, _, _, sail_top, _, _, _, _), > + [17] = PINGROUP(17, qup3_se0, tb_trig, tb_trig, emac1_mcg1, _, _, _, _, _), > + [18] = PINGROUP(18, qup3_se0, emac1_mcg2, _, _, sailss_ospi, sailss_emac0, _, _, _), > + [19] = PINGROUP(19, qup3_se0, emac1_mcg3, _, _, sailss_ospi, sailss_emac0, _, _, _), > + [20] = PINGROUP(20, qup0_se0, emac1_mdc, qdss_gpio, _, _, _, _, _, _), > + [21] = PINGROUP(21, qup0_se0, emac1_mdio, qdss_gpio, _, _, _, _, _, _), > + [22] = PINGROUP(22, qup0_se0, qdss_gpio15, _, _, _, _, _, _, _), > + [23] = PINGROUP(23, qup0_se0, qdss_gpio14, _, _, _, _, _, _, _), > + [24] = PINGROUP(24, qup0_se1, qdss_gpio13, _, _, _, _, _, _, _), > + [25] = PINGROUP(25, qup0_se1, phase_flag31, _, qdss_gpio12, _, _, _, _, _), > + [26] = PINGROUP(26, sgmii_phy, qup0_se1, qdss_cti, phase_flag30, _, _, _, _, _), > + [27] = PINGROUP(27, qup0_se1, qdss_cti, phase_flag29, _, atest_char, _, _, _, _), > + [28] = PINGROUP(28, qup0_se3, phase_flag28, _, qdss_gpio11, _, _, _, _, _), > + [29] = PINGROUP(29, qup0_se3, phase_flag27, _, qdss_gpio10, _, _, _, _, _), > + [30] = PINGROUP(30, qup0_se3, phase_flag26, _, qdss_gpio9, _, _, _, _, _), > + [31] = PINGROUP(31, qup0_se3, phase_flag25, _, qdss_gpio8, _, _, _, _, _), > + [32] = PINGROUP(32, qup0_se4, phase_flag24, _, _, _, _, _, _, _), > + [33] = PINGROUP(33, qup0_se4, gcc_gp4, _, ddr_pxi0, _, _, _, _, _), > + [34] = PINGROUP(34, qup0_se4, gcc_gp5, _, ddr_pxi0, _, _, _, _, _), > + [35] = PINGROUP(35, qup0_se4, phase_flag23, _, _, _, _, _, _, _), > + [36] = PINGROUP(36, qup0_se2, qup0_se5, phase_flag22, tgu_ch2, _, _, _, _, _), > + [37] = PINGROUP(37, qup0_se2, qup0_se5, phase_flag21, tgu_ch3, _, _, _, _, _), > + [38] = PINGROUP(38, qup0_se5, qup0_se2, qdss_cti, phase_flag20, tgu_ch4, _, _, _, _), > + [39] = PINGROUP(39, qup0_se5, qup0_se2, qdss_cti, phase_flag19, tgu_ch5, _, _, _, _), > + [40] = PINGROUP(40, qup1_se0, qup1_se1, ibi_i3c, mdp1_vsync0, _, _, _, _, _), > + [41] = PINGROUP(41, qup1_se0, qup1_se1, ibi_i3c, mdp1_vsync1, _, _, _, _, _), > + [42] = PINGROUP(42, qup1_se1, qup1_se0, ibi_i3c, mdp1_vsync2, gcc_gp5, _, _, _, _), > + [43] = PINGROUP(43, qup1_se1, qup1_se0, ibi_i3c, mdp1_vsync3, _, _, _, _, _), > + [44] = PINGROUP(44, qup1_se2, qup1_se3, edp0_lcd, _, _, _, _, _, _), > + [45] = PINGROUP(45, qup1_se2, qup1_se3, edp1_lcd, _, _, _, _, _, _), > + [46] = PINGROUP(46, qup1_se3, qup1_se2, mdp1_vsync4, tgu_ch0, _, _, _, _, _), > + [47] = PINGROUP(47, qup1_se3, qup1_se2, mdp1_vsync5, tgu_ch1, _, _, _, _, _), > + [48] = PINGROUP(48, qup1_se4, qdss_cti, edp2_lcd, _, _, _, _, _, _), > + [49] = PINGROUP(49, qup1_se4, qdss_cti, edp3_lcd, _, _, _, _, _, _), > + [50] = PINGROUP(50, qup1_se4, cci_async, qdss_cti, mdp1_vsync8, _, _, _, _, _), > + [51] = PINGROUP(51, qup1_se4, qdss_cti, mdp1_vsync6, gcc_gp1, _, _, _, _, _), > + [52] = PINGROUP(52, qup1_se5, cci_timer4, cci_i2c, mdp1_vsync7, gcc_gp2, _, ddr_pxi1, _, _), > + [53] = PINGROUP(53, qup1_se5, cci_timer5, cci_i2c, gcc_gp3, _, ddr_pxi1, _, _, _), > + [54] = PINGROUP(54, qup1_se5, cci_timer6, cci_i2c, _, _, _, _, _, _), > + [55] = PINGROUP(55, qup1_se5, cci_timer7, cci_i2c, gcc_gp4, _, ddr_pxi2, _, _, _), > + [56] = PINGROUP(56, qup1_se6, qup1_se6, cci_timer8, cci_i2c, phase_flag18, > + ddr_bist, _, _, _), > + [57] = PINGROUP(57, qup1_se6, qup1_se6, cci_timer9, cci_i2c, mdp0_vsync0, > + phase_flag17, ddr_bist, _, _), > + [58] = PINGROUP(58, cci_i2c, mdp0_vsync1, ddr_bist, _, atest_usb2, atest_char1, _, _, _), > + [59] = PINGROUP(59, cci_i2c, mdp0_vsync2, ddr_bist, _, atest_usb2, atest_char0, _, _, _), > + [60] = PINGROUP(60, cci_i2c, qdss_gpio0, _, _, _, _, _, _, _), > + [61] = PINGROUP(61, cci_i2c, qdss_gpio1, _, _, _, _, _, _, _), > + [62] = PINGROUP(62, cci_i2c, qdss_gpio2, _, _, _, _, _, _, _), > + [63] = PINGROUP(63, cci_i2c, qdss_gpio3, _, _, _, _, _, _, _), > + [64] = PINGROUP(64, cci_i2c, qdss_gpio4, _, _, _, _, _, _, _), > + [65] = PINGROUP(65, cci_i2c, qdss_gpio5, _, _, _, _, _, _, _), > + [66] = PINGROUP(66, cci_i2c, cci_async, qdss_gpio6, _, _, _, _, _, _), > + [67] = PINGROUP(67, cci_i2c, qdss_gpio7, _, _, _, _, _, _, _), > + [68] = PINGROUP(68, cci_timer0, cci_async, _, _, _, _, _, _, _), > + [69] = PINGROUP(69, cci_timer1, cci_async, _, _, _, _, _, _, _), > + [70] = PINGROUP(70, cci_timer2, cci_async, _, _, _, _, _, _, _), > + [71] = PINGROUP(71, cci_timer3, cci_async, _, _, _, _, _, _, _), > + [72] = PINGROUP(72, cam_mclk, _, _, _, _, _, _, _, _), > + [73] = PINGROUP(73, cam_mclk, _, _, _, _, _, _, _, _), > + [74] = PINGROUP(74, cam_mclk, _, _, _, _, _, _, _, _), > + [75] = PINGROUP(75, cam_mclk, _, _, _, _, _, _, _, _), > + [76] = PINGROUP(76, _, _, _, _, _, _, _, _, _), > + [77] = PINGROUP(77, _, _, _, _, _, _, _, _, _), > + [78] = PINGROUP(78, _, _, _, _, _, _, _, _, _), > + [79] = PINGROUP(79, _, _, _, _, _, _, _, _, _), > + [80] = PINGROUP(80, qup2_se0, ibi_i3c, mdp0_vsync3, _, _, _, _, _, _), > + [81] = PINGROUP(81, qup2_se0, ibi_i3c, mdp0_vsync4, _, _, _, _, _, _), > + [82] = PINGROUP(82, qup2_se0, mdp_vsync, gcc_gp1, _, _, _, _, _, _), > + [83] = PINGROUP(83, qup2_se0, mdp_vsync, gcc_gp2, _, _, _, _, _, _), > + [84] = PINGROUP(84, qup2_se1, qup2_se5, ibi_i3c, mdp_vsync, gcc_gp3, _, _, _, _), > + [85] = PINGROUP(85, qup2_se1, qup2_se5, ibi_i3c, _, _, _, _, _, _), > + [86] = PINGROUP(86, qup2_se2, jitter_bist, atest_usb2, ddr_pxi2, _, _, _, _, _), > + [87] = PINGROUP(87, qup2_se2, pll_clk, atest_usb20, ddr_pxi3, _, _, _, _, _), > + [88] = PINGROUP(88, qup2_se2, _, atest_usb21, ddr_pxi3, _, _, _, _, _), > + [89] = PINGROUP(89, qup2_se2, _, atest_usb22, ddr_pxi4, atest_char3, _, _, _, _), > + [90] = PINGROUP(90, qup2_se2, _, atest_usb23, ddr_pxi4, atest_char2, _, _, _, _), > + [91] = PINGROUP(91, qup2_se3, mdp0_vsync5, _, atest_usb20, _, _, _, _, _), > + [92] = PINGROUP(92, qup2_se3, mdp0_vsync6, _, atest_usb21, _, _, _, _, _), > + [93] = PINGROUP(93, qup2_se3, mdp0_vsync7, _, atest_usb22, _, _, _, _, _), > + [94] = PINGROUP(94, qup2_se3, mdp0_vsync8, _, atest_usb23, _, _, _, _, _), > + [95] = PINGROUP(95, qup2_se4, qup2_se6, _, atest_usb20, _, _, _, _, _), > + [96] = PINGROUP(96, qup2_se4, qup2_se6, _, atest_usb21, _, _, _, _, _), > + [97] = PINGROUP(97, qup2_se6, qup2_se4, cri_trng0, _, atest_usb22, _, _, _, _), > + [98] = PINGROUP(98, qup2_se6, qup2_se4, phase_flag16, cri_trng1, _, _, _, _, _), > + [99] = PINGROUP(99, qup2_se5, qup2_se1, phase_flag15, cri_trng, _, _, _, _, _), > + [100] = PINGROUP(100, qup2_se5, qup2_se1, _, _, _, _, _, _, _), > + [101] = PINGROUP(101, edp0_hot, prng_rosc0, tsense_pwm4, _, _, _, _, _, _), > + [102] = PINGROUP(102, edp1_hot, prng_rosc1, tsense_pwm3, _, _, _, _, _, _), > + [103] = PINGROUP(103, edp3_hot, prng_rosc2, tsense_pwm2, _, _, _, _, _, _), > + [104] = PINGROUP(104, edp2_hot, prng_rosc3, tsense_pwm1, _, _, _, _, _, _), > + [105] = PINGROUP(105, mi2s_mclk0, _, qdss_gpio, atest_usb23, _, _, _, _, _), > + [106] = PINGROUP(106, mi2s1_sck, phase_flag14, _, qdss_gpio8, _, _, _, _, _), > + [107] = PINGROUP(107, mi2s1_ws, phase_flag13, _, qdss_gpio9, _, _, _, _, _), > + [108] = PINGROUP(108, mi2s1_data0, phase_flag12, _, qdss_gpio10, _, _, _, _, _), > + [109] = PINGROUP(109, mi2s1_data1, phase_flag11, _, qdss_gpio11, _, _, _, _, _), > + [110] = PINGROUP(110, mi2s2_sck, phase_flag10, _, qdss_gpio12, _, _, _, _, _), > + [111] = PINGROUP(111, mi2s2_ws, phase_flag9, _, qdss_gpio13, vsense_trigger, _, _, _, _), > + [112] = PINGROUP(112, mi2s2_data0, phase_flag8, _, qdss_gpio14, _, _, _, _, _), > + [113] = PINGROUP(113, mi2s2_data1, audio_ref, phase_flag7, _, qdss_gpio15, _, _, _, _), > + [114] = PINGROUP(114, hs0_mi2s, pll_bist, phase_flag6, _, qdss_gpio, _, _, _, _), > + [115] = PINGROUP(115, hs0_mi2s, _, qdss_gpio0, _, _, _, _, _, _), > + [116] = PINGROUP(116, hs0_mi2s, _, qdss_gpio1, _, _, _, _, _, _), > + [117] = PINGROUP(117, hs0_mi2s, mi2s_mclk1, _, qdss_gpio2, _, _, _, _, _), > + [118] = PINGROUP(118, hs1_mi2s, _, qdss_gpio3, ddr_pxi5, _, _, _, _, _), > + [119] = PINGROUP(119, hs1_mi2s, _, qdss_gpio4, ddr_pxi5, _, _, _, _, _), > + [120] = PINGROUP(120, hs1_mi2s, phase_flag5, _, qdss_gpio5, _, _, _, _, _), > + [121] = PINGROUP(121, hs1_mi2s, phase_flag4, _, qdss_gpio6, _, _, _, _, _), > + [122] = PINGROUP(122, hs2_mi2s, phase_flag3, _, qdss_gpio7, _, _, _, _, _), > + [123] = PINGROUP(123, hs2_mi2s, phase_flag2, _, _, _, _, _, _, _), > + [124] = PINGROUP(124, hs2_mi2s, phase_flag1, _, _, _, _, _, _, _), > + [125] = PINGROUP(125, hs2_mi2s, phase_flag0, _, _, _, _, _, _, _), > + [126] = PINGROUP(126, _, _, _, _, _, _, _, _, _), > + [127] = PINGROUP(127, _, _, _, _, _, _, _, _, _), > + [128] = PINGROUP(128, _, _, _, _, _, _, _, _, _), > + [129] = PINGROUP(129, _, _, _, _, _, _, _, _, _), > + [130] = PINGROUP(130, _, _, _, _, _, _, _, _, _), > + [131] = PINGROUP(131, _, _, _, _, _, _, _, _, _), > + [132] = PINGROUP(132, _, _, _, _, _, _, _, _, _), > + [133] = PINGROUP(133, _, _, _, _, _, _, _, _, _), > + [134] = PINGROUP(134, _, _, _, _, _, _, _, _, _), > + [135] = PINGROUP(135, _, _, _, _, _, _, _, _, _), > + [136] = PINGROUP(136, _, _, _, _, _, _, _, _, _), > + [137] = PINGROUP(137, _, _, _, _, _, _, _, _, _), > + [138] = PINGROUP(138, _, _, _, _, _, _, _, _, _), > + [139] = PINGROUP(139, _, _, _, _, _, _, _, _, _), > + [140] = PINGROUP(140, _, _, _, _, _, _, _, _, _), > + [141] = PINGROUP(141, _, _, _, _, _, _, _, _, _), > + [142] = PINGROUP(142, _, _, _, _, _, _, _, _, _), > + [143] = PINGROUP(143, _, _, _, _, _, _, _, _, _), > + [144] = PINGROUP(144, dbg_out, _, _, _, _, _, _, _, _), > + [145] = PINGROUP(145, _, _, _, _, _, _, _, _, _), > + [146] = PINGROUP(146, _, _, _, _, _, _, _, _, _), > + [147] = PINGROUP(147, _, _, _, _, _, _, _, _, _), > + [148] = PINGROUP(148, _, _, _, _, _, _, _, _, _), > + [149] = UFS_RESET(ufs_reset, 0x1a2000), > + [150] = SDC_QDSD_PINGROUP(sdc1_rclk, 0x199000, 15, 0), > + [151] = SDC_QDSD_PINGROUP(sdc1_clk, 0x199000, 13, 6), > + [152] = SDC_QDSD_PINGROUP(sdc1_cmd, 0x199000, 11, 3), > + [153] = SDC_QDSD_PINGROUP(sdc1_data, 0x199000, 9, 0), > +}; > + > +static const struct msm_pinctrl_soc_data sa8775p_pinctrl = { > + .pins = sa8775p_pins, > + .npins = ARRAY_SIZE(sa8775p_pins), > + .functions = sa8775p_functions, > + .nfunctions = ARRAY_SIZE(sa8775p_functions), > + .groups = sa8775p_groups, > + .ngroups = ARRAY_SIZE(sa8775p_groups), > + .ngpios = 150, > +}; > + > +static int sa8775p_pinctrl_probe(struct platform_device *pdev) > +{ > + return msm_pinctrl_probe(pdev, &sa8775p_pinctrl); > +} > + > +static const struct of_device_id sa8775p_pinctrl_of_match[] = { > + { .compatible = "qcom,sa8775p-pinctrl", }, qcom,sa8775p-tlmm > + { }, > +}; > + > +static struct platform_driver sa8775p_pinctrl_driver = { > + .driver = { > + .name = "sa8775p-pinctrl", > + .of_match_table = sa8775p_pinctrl_of_match, > + }, > + .probe = sa8775p_pinctrl_probe, > + .remove = msm_pinctrl_remove, > +}; > + > +static int __init sa8775p_pinctrl_init(void) > +{ > + return platform_driver_register(&sa8775p_pinctrl_driver); > +} > +arch_initcall(sa8775p_pinctrl_init); > + > +static void __exit sa8775p_pinctrl_exit(void) > +{ > + platform_driver_unregister(&sa8775p_pinctrl_driver); > +} > +module_exit(sa8775p_pinctrl_exit); > + > +MODULE_DESCRIPTION("QTI SA8775P pinctrl driver"); > +MODULE_LICENSE("GPL"); > +MODULE_DEVICE_TABLE(of, sa8775p_pinctrl_of_match); Please move this next to the of_match table. Regards, Bjorn > -- > 2.37.2 >