From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com
Cc: Daniil Tatianin <d-tatianin@yandex-team.ru>,
netdev@vger.kernel.org, anthony.l.nguyen@intel.com,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Subject: [PATCH net 3/3] iavf/iavf_main: actually log ->src mask when talking about it
Date: Tue, 10 Jan 2023 14:38:25 -0800 [thread overview]
Message-ID: <20230110223825.648544-4-anthony.l.nguyen@intel.com> (raw)
In-Reply-To: <20230110223825.648544-1-anthony.l.nguyen@intel.com>
From: Daniil Tatianin <d-tatianin@yandex-team.ru>
This fixes a copy-paste issue where dev_err would log the dst mask even
though it is clearly talking about src.
Found by Linux Verification Center (linuxtesting.org) with the SVACE
static analysis tool.
Fixes: 0075fa0fadd0 ("i40evf: Add support to apply cloud filters")
Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru>
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
---
drivers/net/ethernet/intel/iavf/iavf_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
index c4e451ef7942..adc02adef83a 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_main.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
@@ -3850,7 +3850,7 @@ static int iavf_parse_cls_flower(struct iavf_adapter *adapter,
field_flags |= IAVF_CLOUD_FIELD_IIP;
} else {
dev_err(&adapter->pdev->dev, "Bad ip src mask 0x%08x\n",
- be32_to_cpu(match.mask->dst));
+ be32_to_cpu(match.mask->src));
return -EINVAL;
}
}
--
2.38.1
next prev parent reply other threads:[~2023-01-10 22:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 22:38 [PATCH net 0/3][pull request] Intel Wired LAN Driver Updates 2023-01-10 (ixgbe, igc, iavf) Tony Nguyen
2023-01-10 22:38 ` [PATCH net 1/3] ixgbe: fix pci device refcount leak Tony Nguyen
2023-01-10 22:38 ` [PATCH net 2/3] igc: Fix PPS delta between two synchronized end-points Tony Nguyen
2023-01-10 22:38 ` Tony Nguyen [this message]
2023-01-11 16:41 ` [PATCH net 0/3][pull request] Intel Wired LAN Driver Updates 2023-01-10 (ixgbe, igc, iavf) Alexander H Duyck
2023-01-12 5:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230110223825.648544-4-anthony.l.nguyen@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=d-tatianin@yandex-team.ru \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).