From: Oz Shlomo <ozsh@nvidia.com>
To: <netdev@vger.kernel.org>
Cc: Saeed Mahameed <saeedm@nvidia.com>, Roi Dayan <roid@nvidia.com>,
"Jiri Pirko" <jiri@nvidia.com>,
Marcelo Ricardo Leitner <mleitner@redhat.com>,
"Simon Horman" <simon.horman@corigine.com>,
Baowen Zheng <baowen.zheng@corigine.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Edward Cree <ecree.xilinx@gmail.com>,
"Oz Shlomo" <ozsh@nvidia.com>
Subject: [PATCH net-next 0/9] net: flow_offload: add support for per action hw stats
Date: Wed, 1 Feb 2023 18:10:29 +0200 [thread overview]
Message-ID: <20230201161039.20714-1-ozsh@nvidia.com> (raw)
There are currently two mechanisms for populating hardware stats:
1. Using flow_offload api to query the flow's statistics.
The api assumes that the same stats values apply to all
the flow's actions.
This assumption breaks when action drops or jumps over following
actions.
2. Using hw_action api to query specific action stats via a driver
callback method. This api assures the correct action stats for
the offloaded action, however, it does not apply to the rest of the
actions in the flow's actions array, as elaborated below.
The current hw_action api does not apply to the following use cases:
1. Actions that are implicitly created by filters (aka bind actions).
In the following example only one counter will apply to the rule:
tc filter add dev $DEV prio 2 protocol ip parent ffff: \
flower ip_proto tcp dst_ip $IP2 \
action police rate 1mbit burst 100k conform-exceed drop/pipe \
action mirred egress redirect dev $DEV2
2. Action preceding a hw action.
In the following example the same flow stats will apply to the sample and
mirred actions:
tc action add police rate 1mbit burst 100k conform-exceed drop / pipe
tc filter add dev $DEV prio 2 protocol ip parent ffff: \
flower ip_proto tcp dst_ip $IP2 \
action sample rate 1 group 10 trunc 60 pipe \
action police index 1 \
action mirred egress redirect dev $DEV2
3. Meter action using jump control.
In the following example the same flow stats will apply to both
mirred actions:
tc action add police rate 1mbit burst 100k conform-exceed jump 2 / pipe
tc filter add dev $DEV prio 2 protocol ip parent ffff: \
flower ip_proto tcp dst_ip $IP2 \
action police index 1 \
action mirred egress redirect dev $DEV2
action mirred egress redirect dev $DEV3
This series provides the platform to query per action stats for in_hw flows.
The first four patches are preparation patches with no functionality change.
The fifth patch re-uses the existing flow action stats api to query action
stats for both classifier and action dumps.
The rest of the patches add per action stats support to the Mellanox driver.
Oz Shlomo (9):
net/sched: optimize action stats api calls
net/sched: act_pedit, setup offload action for action stats query
net/sched: pass flow_stats instead of multiple stats args
net/sched: introduce flow_offload action cookie
net/sched: support per action hw stats
net/mlx5e: TC, add hw counter to branching actions
net/mlx5e: TC, store tc action cookies per attr
net/sched: TC, map tc action cookie to a hw counter
net/sched: TC, support per action stats
drivers/net/ethernet/mellanox/mlx5/core/Makefile | 2 +-
.../net/ethernet/mellanox/mlx5/core/en/rep/tc.c | 2 +-
.../ethernet/mellanox/mlx5/core/en/tc/act_stats.c | 197 +++++++++++++++++++++
.../ethernet/mellanox/mlx5/core/en/tc/act_stats.h | 27 +++
.../net/ethernet/mellanox/mlx5/core/en/tc_priv.h | 1 +
drivers/net/ethernet/mellanox/mlx5/core/en_rep.h | 3 +
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 91 ++++++++--
drivers/net/ethernet/mellanox/mlx5/core/en_tc.h | 4 +
.../net/ethernet/mellanox/mlx5/core/fs_counters.c | 10 ++
include/linux/mlx5/fs.h | 2 +
include/net/flow_offload.h | 3 +
include/net/pkt_cls.h | 30 ++--
net/sched/act_api.c | 14 +-
net/sched/act_pedit.c | 24 ++-
net/sched/cls_api.c | 1 +
net/sched/cls_flower.c | 7 +-
net/sched/cls_matchall.c | 6 +-
17 files changed, 376 insertions(+), 48 deletions(-)
create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en/tc/act_stats.c
create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en/tc/act_stats.h
--
1.8.3.1
next reply other threads:[~2023-02-01 16:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 16:10 Oz Shlomo [this message]
2023-02-01 16:10 ` [PATCH net-next 1/9] net/sched: optimize action stats api calls Oz Shlomo
2023-02-03 14:34 ` Simon Horman
2023-02-01 16:10 ` [PATCH net-next 2/9] net/sched: act_pedit, setup offload action for action stats query Oz Shlomo
2023-02-01 20:59 ` Pedro Tammela
2023-02-02 7:21 ` Oz Shlomo
2023-02-03 15:31 ` Marcelo Ricardo Leitner
2023-02-05 13:00 ` Oz Shlomo
2023-02-01 16:10 ` [PATCH net-next 3/9] net/sched: pass flow_stats instead of multiple stats args Oz Shlomo
2023-02-03 14:34 ` Simon Horman
2023-02-01 16:10 ` [PATCH net-next 4/9] net/sched: introduce flow_offload action cookie Oz Shlomo
2023-02-03 14:38 ` Simon Horman
2023-02-01 16:10 ` [PATCH net-next 5/9] net/sched: support per action hw stats Oz Shlomo
2023-02-03 14:33 ` Simon Horman
2023-02-05 13:01 ` Oz Shlomo
2023-02-03 14:51 ` Simon Horman
2023-02-05 13:02 ` Oz Shlomo
2023-02-01 16:10 ` [PATCH net-next 6/9] net/mlx5e: TC, add hw counter to branching actions Oz Shlomo
2023-02-01 16:10 ` [PATCH net-next 7/9] net/mlx5e: TC, store tc action cookies per attr Oz Shlomo
2023-02-03 16:11 ` Marcelo Ricardo Leitner
2023-02-05 13:13 ` Oz Shlomo
2023-02-01 16:10 ` [PATCH net-next 8/9] net/sched: TC, map tc action cookie to a hw counter Oz Shlomo
2023-02-01 16:10 ` [PATCH net-next 9/9] net/sched: TC, support per action stats Oz Shlomo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230201161039.20714-1-ozsh@nvidia.com \
--to=ozsh@nvidia.com \
--cc=baowen.zheng@corigine.com \
--cc=ecree.xilinx@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@nvidia.com \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=roid@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).